"maybe-uninitialized" warnings emitted by

[edk2-devel] [PATCH v1 0/2] "maybe-uninitialized" warnings emitted by

Posted by Sergei Dmitrouk 2 years, 12 months ago

Compiling for IA32 target with gcc-5.5.0 emits "maybe-uninitialized" warnings.
Compilation command: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t GCC49

Sergei Dmitrouk (2):
  ShellPkg/UefiShellCommandLib: suppress incorrect gcc warning
  OvmfPkg/VirtioFsDxe: suppress incorrect gcc warnings

 OvmfPkg/VirtioFsDxe/SimpleFsOpen.c                    | 11 +++++++++++
 .../Library/UefiShellCommandLib/UefiShellCommandLib.c |  5 +++++
 2 files changed, 16 insertions(+)

-- 
2.17.6



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75045): https://edk2.groups.io/g/devel/message/75045
Mute This Topic: https://groups.io/mt/82760956/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] "maybe-uninitialized" warnings emitted by

Posted by Laszlo Ersek 2 years, 11 months ago

On 05/12/21 00:56, Sergei Dmitrouk wrote:
> Compiling for IA32 target with gcc-5.5.0 emits "maybe-uninitialized" warnings.
> Compilation command: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t GCC49
> 
> Sergei Dmitrouk (2):
>   ShellPkg/UefiShellCommandLib: suppress incorrect gcc warning
>   OvmfPkg/VirtioFsDxe: suppress incorrect gcc warnings
> 
>  OvmfPkg/VirtioFsDxe/SimpleFsOpen.c                    | 11 +++++++++++
>  .../Library/UefiShellCommandLib/UefiShellCommandLib.c |  5 +++++
>  2 files changed, 16 insertions(+)
> 

Merged as commit range 22ac5cc9d9db..d82c4693f8d5, via
<https://github.com/tianocore/edk2/pull/1643>.

I've gone ahead and merged the ShellPkg patch too, with only my R-b. I
had written the original code, and I've carefully verified Sergei's
patch too. Sergei learned the edk2 contribution process, and got it
right, at the first posting attempt; I wouldn't like to make him wait
several days for a ShellPkg ACK, with such a small patch.

Thanks for the contribution!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75112): https://edk2.groups.io/g/devel/message/75112
Mute This Topic: https://groups.io/mt/82760956/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-