[edk2-devel] [PATCH v1 0/5] Dot graph generator for PPTT

Joey Gouly posted 5 patches 2 years, 12 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
.../UefiShellAcpiViewCommandLib.inf           |   4 +-
.../UefiShellAcpiViewCommandLib/AcpiParser.h  |  79 +++--
.../AcpiTableParser.h                         |   6 +-
.../UefiShellAcpiViewCommandLib/AcpiView.h    |  25 +-
.../AcpiViewConfig.h                          |   3 +-
.../DotGenerator.h                            |  97 ++++++
.../AcpiTableParser.c                         |  20 +-
.../UefiShellAcpiViewCommandLib/AcpiView.c    | 117 +++++--
.../DotGenerator.c                            | 276 +++++++++++++++++
.../Parsers/Bgrt/BgrtParser.c                 |  10 +-
.../Parsers/Dbg2/Dbg2Parser.c                 |   8 +-
.../Parsers/Dsdt/DsdtParser.c                 |   8 +-
.../Parsers/Facs/FacsParser.c                 |  10 +-
.../Parsers/Fadt/FadtParser.c                 |  27 +-
.../Parsers/Gtdt/GtdtParser.c                 |   8 +-
.../Parsers/Iort/IortParser.c                 |   8 +-
.../Parsers/Madt/MadtParser.c                 |   8 +-
.../Parsers/Mcfg/McfgParser.c                 |   8 +-
.../Parsers/Pptt/PpttParser.c                 | 285 +++++++++++++++---
.../Parsers/Rsdp/RsdpParser.c                 |  10 +-
.../Parsers/Slit/SlitParser.c                 |   8 +-
.../Parsers/Spcr/SpcrParser.c                 |   8 +-
.../Parsers/Srat/SratParser.c                 |   8 +-
.../Parsers/Ssdt/SsdtParser.c                 |   8 +-
.../Parsers/Xsdt/XsdtParser.c                 |  10 +-
.../UefiShellAcpiViewCommandLib.c             |  24 +-
.../UefiShellAcpiViewCommandLib.uni           |   9 +-
27 files changed, 903 insertions(+), 189 deletions(-)
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.h
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.c
[edk2-devel] [PATCH v1 0/5] Dot graph generator for PPTT
Posted by Joey Gouly 2 years, 12 months ago
This series adds functionality to print a dot graph of a PPTT table.
This helps with understanding and debugging PPTT tables.
The dot graph generator functionality is generic and could be used by
other tables that would benefit from graph output.

Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)

The changes can be seen at https://github.com/jgouly/edk2/tree/1484_pptt_dot_graph_v1

Marc Moisson-Franckhauser (5):
  ShellPkg: Replace 'Trace' parameter with 'ParseFlags'
  ShellPkg: add a helper function for getting a new file name
  ShellPkg: add a Graph option to the Parser Flags
  ShellPkg: add dot file generator functions
  ShellPkg: add PPTT dot file genration

 .../UefiShellAcpiViewCommandLib.inf           |   4 +-
 .../UefiShellAcpiViewCommandLib/AcpiParser.h  |  79 +++--
 .../AcpiTableParser.h                         |   6 +-
 .../UefiShellAcpiViewCommandLib/AcpiView.h    |  25 +-
 .../AcpiViewConfig.h                          |   3 +-
 .../DotGenerator.h                            |  97 ++++++
 .../AcpiTableParser.c                         |  20 +-
 .../UefiShellAcpiViewCommandLib/AcpiView.c    | 117 +++++--
 .../DotGenerator.c                            | 276 +++++++++++++++++
 .../Parsers/Bgrt/BgrtParser.c                 |  10 +-
 .../Parsers/Dbg2/Dbg2Parser.c                 |   8 +-
 .../Parsers/Dsdt/DsdtParser.c                 |   8 +-
 .../Parsers/Facs/FacsParser.c                 |  10 +-
 .../Parsers/Fadt/FadtParser.c                 |  27 +-
 .../Parsers/Gtdt/GtdtParser.c                 |   8 +-
 .../Parsers/Iort/IortParser.c                 |   8 +-
 .../Parsers/Madt/MadtParser.c                 |   8 +-
 .../Parsers/Mcfg/McfgParser.c                 |   8 +-
 .../Parsers/Pptt/PpttParser.c                 | 285 +++++++++++++++---
 .../Parsers/Rsdp/RsdpParser.c                 |  10 +-
 .../Parsers/Slit/SlitParser.c                 |   8 +-
 .../Parsers/Spcr/SpcrParser.c                 |   8 +-
 .../Parsers/Srat/SratParser.c                 |   8 +-
 .../Parsers/Ssdt/SsdtParser.c                 |   8 +-
 .../Parsers/Xsdt/XsdtParser.c                 |  10 +-
 .../UefiShellAcpiViewCommandLib.c             |  24 +-
 .../UefiShellAcpiViewCommandLib.uni           |   9 +-
 27 files changed, 903 insertions(+), 189 deletions(-)
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.h
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.c

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74808): https://edk2.groups.io/g/devel/message/74808
Mute This Topic: https://groups.io/mt/82651820/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1 0/5] Dot graph generator for PPTT
Posted by Joey Gouly 2 years, 12 months ago
> From: Joey Gouly <joey.gouly@arm.com>
> Sent: 07 May 2021 11:37


> The changes can be seen at https://github.com/jgouly/edk2/tree/1484_pptt_dot_graph_v1

The CI on github showed some coding style issues with this series. I will fix those locally but wait for more review comments before I send a v2.

Thanks,
Joey

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74813): https://edk2.groups.io/g/devel/message/74813
Mute This Topic: https://groups.io/mt/82651820/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-