[edk2-devel] [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes

Rebecca Cran posted 5 patches 3 years ago
Failed in applying to current master (apply log)
ArmPkg/ArmPkg.dec                                                              |  1 +
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
8 files changed, 194 insertions(+), 6 deletions(-)
[edk2-devel] [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes
Posted by Rebecca Cran 3 years ago
Add the set of improvements requested during the initial series to move
closer to a full/proper implementation, fix the
chassis SKU number string, and fix a typo in a comment.

This is a breaking change wrt SbsaQemu in edk2-platforms.

Rebecca Cran (5):
  ArmPkg: Allow platforms to override PCI supported state in
    SmbiosMiscDxe
  ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record
  ArmPkg: Allow platforms to report their boot status via OemMiscLib
    call
  ArmPkg: Fix calculation of offset of chassis SKU Number in
    SmbiosMiscDxe
  ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe

 ArmPkg/ArmPkg.dec                                                              |  1 +
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
 ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
 8 files changed, 194 insertions(+), 6 deletions(-)

-- 
2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73563): https://edk2.groups.io/g/devel/message/73563
Mute This Topic: https://groups.io/mt/81741552/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes
Posted by Leif Lindholm 3 years ago
On Tue, Mar 30, 2021 at 20:16:14 -0600, Rebecca Cran wrote:
> Add the set of improvements requested during the initial series to move
> closer to a full/proper implementation, fix the
> chassis SKU number string, and fix a typo in a comment.
> 
> This is a breaking change wrt SbsaQemu in edk2-platforms.

I can't find a corresponding patch for that.
Are you looking for the APIs in this set to stabilise first?

/
    Leif

> Rebecca Cran (5):
>   ArmPkg: Allow platforms to override PCI supported state in
>     SmbiosMiscDxe
>   ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record
>   ArmPkg: Allow platforms to report their boot status via OemMiscLib
>     call
>   ArmPkg: Fix calculation of offset of chassis SKU Number in
>     SmbiosMiscDxe
>   ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe
> 
>  ArmPkg/ArmPkg.dec                                                              |  1 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
>  ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
>  8 files changed, 194 insertions(+), 6 deletions(-)
> 
> -- 
> 2.26.2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74053): https://edk2.groups.io/g/devel/message/74053
Mute This Topic: https://groups.io/mt/81741552/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes
Posted by Rebecca Cran 3 years ago
On 4/13/21 10:25 AM, Leif Lindholm wrote:
> On Tue, Mar 30, 2021 at 20:16:14 -0600, Rebecca Cran wrote:
>> Add the set of improvements requested during the initial series to move
>> closer to a full/proper implementation, fix the
>> chassis SKU number string, and fix a typo in a comment.
>>
>> This is a breaking change wrt SbsaQemu in edk2-platforms.
> 
> I can't find a corresponding patch for that.
> Are you looking for the APIs in this set to stabilise first?

I haven't sent it out yet. I think having this set reviewed and accepted 
first would be best, to avoid extra churn.

-- 
Rebecca Cran

> 
> /
>      Leif
> 
>> Rebecca Cran (5):
>>    ArmPkg: Allow platforms to override PCI supported state in
>>      SmbiosMiscDxe
>>    ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record
>>    ArmPkg: Allow platforms to report their boot status via OemMiscLib
>>      call
>>    ArmPkg: Fix calculation of offset of chassis SKU Number in
>>      SmbiosMiscDxe
>>    ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe
>>
>>   ArmPkg/ArmPkg.dec                                                              |  1 +
>>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
>>   ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
>>   ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
>>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
>>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
>>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
>>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
>>   8 files changed, 194 insertions(+), 6 deletions(-)
>>
>> -- 
>> 2.26.2
>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74071): https://edk2.groups.io/g/devel/message/74071
Mute This Topic: https://groups.io/mt/81741552/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes
Posted by Leif Lindholm 2 years, 11 months ago
On Tue, Mar 30, 2021 at 20:16:14 -0600, Rebecca Cran wrote:
> Add the set of improvements requested during the initial series to move
> closer to a full/proper implementation, fix the
> chassis SKU number string, and fix a typo in a comment.
> 
> This is a breaking change wrt SbsaQemu in edk2-platforms.
> 
> Rebecca Cran (5):
>   ArmPkg: Allow platforms to override PCI supported state in
>     SmbiosMiscDxe
>   ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record
>   ArmPkg: Allow platforms to report their boot status via OemMiscLib
>     call
>   ArmPkg: Fix calculation of offset of chassis SKU Number in
>     SmbiosMiscDxe
>   ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe

As discussed on list, patch 1/5 was dropped.

I fixed up a trailing newline in
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c from 2/5.

For the remainder of the set:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 8d2012035db3..5b90b8abb404.

>  ArmPkg/ArmPkg.dec                                                              |  1 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
>  ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
>  8 files changed, 194 insertions(+), 6 deletions(-)
> 
> -- 
> 2.26.2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74450): https://edk2.groups.io/g/devel/message/74450
Mute This Topic: https://groups.io/mt/81741552/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-