[edk2-devel] [edk2-platforms] [patch V4 20/37] Platform/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib

Dandan Bi posted 37 patches 4 years, 10 months ago
[edk2-devel] [edk2-platforms] [patch V4 20/37] Platform/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
Posted by Dandan Bi 4 years, 10 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
V4:
New updated to consume the MdeLibs.dsc.inc for RegisterFilterLibNull in all dsc files.
Rather than consuming MdeLibs.dsc.in Armada7k8k.dsc.inc.

V3:
Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
[LibraryClasses] section since we can specify different [LibraryClasses]
section for libary instances in MdeLibs.dsc.inc.

V2:
Update Platform dsc to consume the MdeLibs.dsc.inc rather than
consuming RegisterFilterLibNull instance directly.
---
 Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 ++
 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 ++
 Platform/Marvell/Cn913xDb/Cn913xDbA.dsc        | 1 +
 3 files changed, 5 insertions(+)

diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
index 0c2c7489f1..5df7498f71 100644
--- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
+++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
@@ -27,10 +27,12 @@ [Defines]
   DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   DEFINE NETWORK_ISCSI_ENABLE           = FALSE
 
 !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
 
+!include MdePkg/MdeLibs.dsc.inc
+
 [Components.common]
   Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf
 
 [Components.AARCH64]
   Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf
diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
index 40aeb62cfa..2698bd6573 100644
--- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
+++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
@@ -27,10 +27,12 @@ [Defines]
   DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   DEFINE NETWORK_ISCSI_ENABLE           = FALSE
 
 !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
 
+!include MdePkg/MdeLibs.dsc.inc
+
 [Components.common]
   Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf
 
 [Components.AARCH64]
   Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf
diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
index a754c3ea39..67355f3988 100644
--- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
+++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
@@ -37,10 +37,11 @@ [Defines]
   DEFINE NETWORK_TLS_ENABLE             = FALSE
   DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   DEFINE NETWORK_ISCSI_ENABLE           = FALSE
 
 !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+!include MdePkg/MdeLibs.dsc.inc
 !include Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc
 !if $(CN9131) || $(CN9132)
 !include Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc
 !endif
 !if $(CN9132)
-- 
2.18.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73473): https://edk2.groups.io/g/devel/message/73473
Mute This Topic: https://groups.io/mt/81671686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms] [patch V4 20/37] Platform/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
Posted by Marcin Wojtas 4 years, 10 months ago
niedz., 28 mar 2021 o 15:12 Dandan Bi <dandan.bi@intel.com> napisał(a):
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Thanks,
Marcin

> ---
> V4:
> New updated to consume the MdeLibs.dsc.inc for RegisterFilterLibNull in all dsc files.
> Rather than consuming MdeLibs.dsc.in Armada7k8k.dsc.inc.
>
> V3:
> Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
> [LibraryClasses] section since we can specify different [LibraryClasses]
> section for libary instances in MdeLibs.dsc.inc.
>
> V2:
> Update Platform dsc to consume the MdeLibs.dsc.inc rather than
> consuming RegisterFilterLibNull instance directly.
> ---
>  Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 ++
>  Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 ++
>  Platform/Marvell/Cn913xDb/Cn913xDbA.dsc        | 1 +
>  3 files changed, 5 insertions(+)
>
> diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> index 0c2c7489f1..5df7498f71 100644
> --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> @@ -27,10 +27,12 @@ [Defines]
>    DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
>    DEFINE NETWORK_ISCSI_ENABLE           = FALSE
>
>  !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>
> +!include MdePkg/MdeLibs.dsc.inc
> +
>  [Components.common]
>    Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf
>
>  [Components.AARCH64]
>    Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf
> diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> index 40aeb62cfa..2698bd6573 100644
> --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> @@ -27,10 +27,12 @@ [Defines]
>    DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
>    DEFINE NETWORK_ISCSI_ENABLE           = FALSE
>
>  !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>
> +!include MdePkg/MdeLibs.dsc.inc
> +
>  [Components.common]
>    Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf
>
>  [Components.AARCH64]
>    Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf
> diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> index a754c3ea39..67355f3988 100644
> --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> @@ -37,10 +37,11 @@ [Defines]
>    DEFINE NETWORK_TLS_ENABLE             = FALSE
>    DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
>    DEFINE NETWORK_ISCSI_ENABLE           = FALSE
>
>  !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +!include MdePkg/MdeLibs.dsc.inc
>  !include Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc
>  !if $(CN9131) || $(CN9132)
>  !include Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc
>  !endif
>  !if $(CN9132)
> --
> 2.18.0.windows.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73532): https://edk2.groups.io/g/devel/message/73532
Mute This Topic: https://groups.io/mt/81671686/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-