[edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib

Dandan Bi posted 35 patches 4 years, 10 months ago
There is a newer version of this series
[edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
Posted by Dandan Bi 4 years, 10 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
V3:
Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
[LibraryClasses] section since we can specify different [LibraryClasses]
section for libary instances in MdeLibs.dsc.inc.
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 4cdafe8b1f..9802da98c4 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -2,10 +2,13 @@
 #Copyright (c) 2011-2012, ARM Limited. All rights reserved.
 #Copyright (C) 2016 Marvell International Ltd.
 #
 #SPDX-License-Identifier: BSD-2-Clause-Patent
 #
+
+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   ArmadaIcuLib|Silicon/Marvell/Library/IcuLib/IcuLib.inf
   ArmadaSoCDescLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf
   ArmPlatformLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf
   ComPhyLib|Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf
-- 
2.18.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73385): https://edk2.groups.io/g/devel/message/73385
Mute This Topic: https://groups.io/mt/81623462/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
Posted by Michael D Kinney 4 years, 10 months ago
Hi Dandan,

Another patch I think can be dropped to remove dsc.inc including dsc.inc
from another package.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dandan Bi
> Sent: Friday, March 26, 2021 1:39 AM
> To: devel@edk2.groups.io
> Cc: Marcin Wojtas <mw@semihalf.com>; Leif Lindholm <leif@nuviainc.com>
> Subject: [edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> 
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
> 
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
> 
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> V3:
> Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
> [LibraryClasses] section since we can specify different [LibraryClasses]
> section for libary instances in MdeLibs.dsc.inc.
> ---
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 4cdafe8b1f..9802da98c4 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -2,10 +2,13 @@
>  #Copyright (c) 2011-2012, ARM Limited. All rights reserved.
>  #Copyright (C) 2016 Marvell International Ltd.
>  #
>  #SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> +
> +!include MdePkg/MdeLibs.dsc.inc
> +
>  [LibraryClasses.common]
>    ArmadaIcuLib|Silicon/Marvell/Library/IcuLib/IcuLib.inf
>    ArmadaSoCDescLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf
>    ArmPlatformLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf
>    ComPhyLib|Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf
> --
> 2.18.0.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73399): https://edk2.groups.io/g/devel/message/73399
Mute This Topic: https://groups.io/mt/81623462/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-