1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments

Ni, Ray posted 1 patch 3 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210323011527.437-1-ray.ni@intel.com
.../PiSmmCommunication/PiSmmCommunicationPei.c   | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
[edk2-devel] [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
Posted by Ni, Ray 3 years, 1 month ago 
The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.

But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.

This change updates the accordingly comments.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
 .../PiSmmCommunication/PiSmmCommunicationPei.c   | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
 /** @file
 PiSmmCommunication PEI Driver.
 
-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   +----------------------------------+<--
   | EFI_SMM_COMMUNICATION_CONTEXT    |
   |   SwSmiNumber                    | <- SMRAM
-  |   BufferPtrAddress               |----------------
-  +----------------------------------+                |
-                                                      |
-  +----------------------------------+                |
-  | EFI_SMM_COMMUNICATION_ACPI_TABLE |                |
-  |   SwSmiNumber                    | <- AcpiTable   |
-  |   BufferPtrAddress               |---             |
-  +----------------------------------+   |            |
-                                         |            |
-  +----------------------------------+<---------------
+  |   BufferPtrAddress               |---
+  +----------------------------------+   |
+                                         |
+  +----------------------------------+<--
   | Communication Buffer Pointer     | <- AcpiNvs
   +----------------------------------+---
                                          |
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73155): https://edk2.groups.io/g/devel/message/73155
Mute This Topic: https://groups.io/mt/81541408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
Posted by Laszlo Ersek 3 years, 1 month ago 
On 03/23/21 02:15, Ray Ni wrote:
> The comments in PiSmmCommunicationPei.c describe the whole memory
> layout of the SMRAM regarding the SMM communication.
> 
> But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
> PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
> removed the code that produces the ACPI Table.
> 
> This change updates the accordingly comments.
> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  .../PiSmmCommunication/PiSmmCommunicationPei.c   | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> index 68e5003ad4..110165b20b 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> @@ -1,7 +1,7 @@
>  /** @file
>  PiSmmCommunication PEI Driver.
>  
> -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>  
>  **/
> @@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>    +----------------------------------+<--
>    | EFI_SMM_COMMUNICATION_CONTEXT    |
>    |   SwSmiNumber                    | <- SMRAM
> -  |   BufferPtrAddress               |----------------
> -  +----------------------------------+                |
> -                                                      |
> -  +----------------------------------+                |
> -  | EFI_SMM_COMMUNICATION_ACPI_TABLE |                |
> -  |   SwSmiNumber                    | <- AcpiTable   |
> -  |   BufferPtrAddress               |---             |
> -  +----------------------------------+   |            |
> -                                         |            |
> -  +----------------------------------+<---------------
> +  |   BufferPtrAddress               |---
> +  +----------------------------------+   |
> +                                         |
> +  +----------------------------------+<--
>    | Communication Buffer Pointer     | <- AcpiNvs
>    +----------------------------------+---
>                                           |
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73184): https://edk2.groups.io/g/devel/message/73184
Mute This Topic: https://groups.io/mt/81541408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
Posted by Dong, Eric 3 years, 1 month ago 
Reviewed-by: Eric Dong <eric.dong@intel.com>

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Tuesday, March 23, 2021 9:15 AM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments

The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.

But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.

This change updates the accordingly comments.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
 .../PiSmmCommunication/PiSmmCommunicationPei.c   | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
 /** @file

 PiSmmCommunication PEI Driver.

 

-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>

 SPDX-License-Identifier: BSD-2-Clause-Patent

 

 **/

@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   +----------------------------------+<--

   | EFI_SMM_COMMUNICATION_CONTEXT    |

   |   SwSmiNumber                    | <- SMRAM

-  |   BufferPtrAddress               |----------------

-  +----------------------------------+                |

-                                                      |

-  +----------------------------------+                |

-  | EFI_SMM_COMMUNICATION_ACPI_TABLE |                |

-  |   SwSmiNumber                    | <- AcpiTable   |

-  |   BufferPtrAddress               |---             |

-  +----------------------------------+   |            |

-                                         |            |

-  +----------------------------------+<---------------

+  |   BufferPtrAddress               |---

+  +----------------------------------+   |

+                                         |

+  +----------------------------------+<--

   | Communication Buffer Pointer     | <- AcpiNvs

   +----------------------------------+---

                                          |

-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73186): https://edk2.groups.io/g/devel/message/73186
Mute This Topic: https://groups.io/mt/81541408/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.