[v1] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

[edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

Posted by Sunny Wang 3 years ago

PL011 is not a valid ACPI identifier so don't expose it as a _CID.
Since _CID (Comptable ID) is optional, let's just drop it.

Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Signed-off-by: Sunny Wang <sunny.wang@arm.com>
---
 Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
index c17c74e174..61353213fe 100644
--- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
+++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
@@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
     // UART PL011
     Device(COM0) {
       Name(_HID, "ARMH0011")
-      Name(_CID, "PL011")
       Name(_UID, Zero)
       Name(_CRS, ResourceTemplate() {
         Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
-- 
2.31.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73150): https://edk2.groups.io/g/devel/message/73150
Mute This Topic: https://groups.io/mt/81519213/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

Posted by Ard Biesheuvel 3 years ago

On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>

Compatible

> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
>      // UART PL011
>      Device(COM0) {
>        Name(_HID, "ARMH0011")
> -      Name(_CID, "PL011")
>        Name(_UID, Zero)
>        Name(_CRS, ResourceTemplate() {
>          Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73070): https://edk2.groups.io/g/devel/message/73070
Mute This Topic: https://groups.io/mt/81519213/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

Posted by Sami Mujawar 3 years ago

Hi Sunny,

Thank you for this patch.

I will merge this change shortly with the typo fixed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 22/03/2021, 08:07, "Ard Biesheuvel" <ardb@kernel.org> wrote:

    On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
    >
    > PL011 is not a valid ACPI identifier so don't expose it as a _CID.
    > Since _CID (Comptable ID) is optional, let's just drop it.
    >

    Compatible

    > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
    > Cc: Sami Mujawar <sami.mujawar@arm.com>
    > Cc: Pierre Gondois <Pierre.Gondois@arm.com>
    > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
    > Signed-off-by: Sunny Wang <sunny.wang@arm.com>

    Acked-by: Ard Biesheuvel <ardb@kernel.org>

    > ---
    >  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
    >  1 file changed, 1 deletion(-)
    >
    > diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
    > index c17c74e174..61353213fe 100644
    > --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
    > +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
    > @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
    >      // UART PL011
    >      Device(COM0) {
    >        Name(_HID, "ARMH0011")
    > -      Name(_CID, "PL011")
    >        Name(_UID, Zero)
    >        Name(_CRS, ResourceTemplate() {
    >          Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
    > --
    > 2.31.0.windows.1
    >

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73138): https://edk2.groups.io/g/devel/message/73138
Mute This Topic: https://groups.io/mt/81519213/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

Posted by Sunny Wang 3 years ago

Good catch, Ard. Thanks.

Since this was not on EDKII emailing list (thanks to Sami for offline pointing this out to me), I resend this patch for testing my email address and fixing this typo.

Best Regards,
Sunny Wang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel via groups.io
Sent: Monday, March 22, 2021 4:07 PM
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table

On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>

Compatible

> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
>      // UART PL011
>      Device(COM0) {
>        Name(_HID, "ARMH0011")
> -      Name(_CID, "PL011")
>        Name(_UID, Zero)
>        Name(_CRS, ResourceTemplate() {
>          Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73175): https://edk2.groups.io/g/devel/message/73175
Mute This Topic: https://groups.io/mt/81519213/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-