Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

[edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

Posted by Zhiguang Liu 3 years, 1 month ago

The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume MmUnblockMemoryLib.
It cause multiple platforms build failure.
    f463dbadede138dc96a66dae6f361c54f0b3093c
    MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface

This change added NULL MmUnblockMemoryLib instance in MinPlatformPkg dsc include files

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
index fa9098d525..ee91dd8bd6 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
@@ -116,6 +116,7 @@
 !endif
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.inf
-- 
2.30.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72860): https://edk2.groups.io/g/devel/message/72860
Mute This Topic: https://groups.io/mt/81371819/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

Posted by Kun Qin 3 years, 1 month ago

Hi Zhiguang,

I have already sent this patch series to resolve dependencies in 
edk2-platform (although the change is slightly different):
https://edk2.groups.io/g/devel/message/72645

Specifically:
https://edk2.groups.io/g/devel/message/72646

Could you please let me know if the change above resolves the dependency 
issue for you?

The patch series have 2 other patches not being reviewed yet. I plan to 
send out another round tomorrow to include reviewed-by tags. But please 
let me know if you prefer your change below to check in first, I will 
just drop my patch #1 when sending v2.

Thanks,
Kun

On 03/16/2021 02:06, Zhiguang Liu wrote:
> The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume MmUnblockMemoryLib.
> It cause multiple platforms build failure.
>      f463dbadede138dc96a66dae6f361c54f0b3093c
>      MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface
> 
> This change added NULL MmUnblockMemoryLib instance in MinPlatformPkg dsc include files
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> index fa9098d525..ee91dd8bd6 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> @@ -116,6 +116,7 @@
>   !endif
> 
>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> 
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> 
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>   
> 
>   [LibraryClasses.common.UEFI_DRIVER]
> 
>     Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.inf
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72861): https://edk2.groups.io/g/devel/message/72861
Mute This Topic: https://groups.io/mt/81371819/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

Posted by Zhiguang Liu 3 years, 1 month ago

Hi Kun,
Your patch is ok for me. Please keep this change in your patch series.

Hi All, 
Please ignore this patch since the same solution is already included in Kun's patch serials.

Thanks
Zhiguang


> -----Original Message-----
> From: Kun Qin <kuqin12@gmail.com>
> Sent: Tuesday, March 16, 2021 5:18 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong,
> Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve
> MmUnblockMemoryLib
> 
> Hi Zhiguang,
> 
> I have already sent this patch series to resolve dependencies in edk2-
> platform (although the change is slightly different):
> https://edk2.groups.io/g/devel/message/72645
> 
> Specifically:
> https://edk2.groups.io/g/devel/message/72646
> 
> Could you please let me know if the change above resolves the dependency
> issue for you?
> 
> The patch series have 2 other patches not being reviewed yet. I plan to send
> out another round tomorrow to include reviewed-by tags. But please let me
> know if you prefer your change below to check in first, I will just drop my
> patch #1 when sending v2.
> 
> Thanks,
> Kun
> 
> On 03/16/2021 02:06, Zhiguang Liu wrote:
> > The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume
> MmUnblockMemoryLib.
> > It cause multiple platforms build failure.
> >      f463dbadede138dc96a66dae6f361c54f0b3093c
> >      MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock
> memory
> > interface
> >
> > This change added NULL MmUnblockMemoryLib instance in
> MinPlatformPkg
> > dsc include files
> >
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> >
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> > index fa9098d525..ee91dd8bd6 100644
> > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> > @@ -116,6 +116,7 @@
> >   !endif
> >
> >     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> >
> >
> > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolic
> > yLibRuntimeDxe.inf
> >
> > +
> > +
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> ckMemory
> > + LibNull.inf
> >
> >
> >
> >   [LibraryClasses.common.UEFI_DRIVER]
> >
> >
> >
> Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.
> > inf
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72871): https://edk2.groups.io/g/devel/message/72871
Mute This Topic: https://groups.io/mt/81371819/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-