[v7] Add support for running StandaloneMm as OP-TEE TA

[edk2-devel] [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA

Posted by Ilias Apalodimas 3 years, 1 month ago

Hi,
This is v7 of [1]

Changes since V6:
 - Added param[in,out] in comments
 - Fixed an error on Maintainers entry 

Changes since V5:
 - Addressed coding style fixes from Pierre
 - Removed redundant checks in memory allocation and block usage
 - Removed unused COMPRESSION_TOOL_GUID
 - Renamed the files and directories following Leif's sugestion
 - Added Sami and myself as maintainers

Changes since V4:
 - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't
   report.
 - Adding missing error handling in InitializeFvAndVariableStoreHeaders().
   An allocation wasn't properly checked for success

Changes since V3:
 - Coding style fixes proposed by Sami
 - Fixed all reported PatchCheck errors
 - Added overflow checks on the base aaddress allocated for EFI variables.
   The size of the partition is user defined (via Pcd's) and the memory layout
   and allocation address depends on OP-TEE. So let's make sure we won't overflow
   when calculating the 3 partitions needed for FTW
 - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing
 - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc
 - Added reviewed-by tags on patch 2/2

Changes since V2:
 - Allocate a dynamic number of pages based on the Pcd values instead
   of a static number
 - Clean up unused structs in header file
 - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0

Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver

[1] https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661

Ilias Apalodimas (3):
  Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
  StMMRpmb: Add support for building StandaloneMm image for OP-TEE
  Maintainers: Add maintainers for StandAloneMM and RPMB driver

 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c         |  81 ++
 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf       |  43 +
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf    |  58 ++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c     | 861 ++++++++++++++++++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h     |  51 ++
 Maintainers.txt                               |  10 +
 .../PlatformStandaloneMmRpmb.dsc              | 162 ++++
 .../PlatformStandaloneMmRpmb.fdf              | 111 +++
 8 files changed, 1377 insertions(+)
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf

-- 
2.30.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72743): https://edk2.groups.io/g/devel/message/72743
Mute This Topic: https://groups.io/mt/81309166/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA

Posted by Sami Mujawar 3 years ago

Hi ilias,

Thank you for this series.

Pushed as afb0ce7e9756..89f6170d6686

Regards,

Sami Mujawar


From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Saturday, 13 March 2021 at 18:32
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, Pierre Gondois <Pierre.Gondois@arm.com>
Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sughosh.ganu@linaro.org <sughosh.ganu@linaro.org>, leif@nuviainc.com <leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA
Hi,
This is v7 of [1]

Changes since V6:
 - Added param[in,out] in comments
 - Fixed an error on Maintainers entry

Changes since V5:
 - Addressed coding style fixes from Pierre
 - Removed redundant checks in memory allocation and block usage
 - Removed unused COMPRESSION_TOOL_GUID
 - Renamed the files and directories following Leif's sugestion
 - Added Sami and myself as maintainers

Changes since V4:
 - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't
   report.
 - Adding missing error handling in InitializeFvAndVariableStoreHeaders().
   An allocation wasn't properly checked for success

Changes since V3:
 - Coding style fixes proposed by Sami
 - Fixed all reported PatchCheck errors
 - Added overflow checks on the base aaddress allocated for EFI variables.
   The size of the partition is user defined (via Pcd's) and the memory layout
   and allocation address depends on OP-TEE. So let's make sure we won't overflow
   when calculating the 3 partitions needed for FTW
 - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing
 - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc
 - Added reviewed-by tags on patch 2/2

Changes since V2:
 - Allocate a dynamic number of pages based on the Pcd values instead
   of a static number
 - Clean up unused structs in header file
 - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0

Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver

[1] https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661

Ilias Apalodimas (3):
  Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
  StMMRpmb: Add support for building StandaloneMm image for OP-TEE
  Maintainers: Add maintainers for StandAloneMM and RPMB driver

 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c         |  81 ++
 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf       |  43 +
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf    |  58 ++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c     | 861 ++++++++++++++++++
 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h     |  51 ++
 Maintainers.txt                               |  10 +
 .../PlatformStandaloneMmRpmb.dsc              | 162 ++++
 .../PlatformStandaloneMmRpmb.fdf              | 111 +++
 8 files changed, 1377 insertions(+)
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c
 create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
 create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf

--
2.30.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73418): https://edk2.groups.io/g/devel/message/73418
Mute This Topic: https://groups.io/mt/81309166/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA

Posted by Ilias Apalodimas 3 years ago

On Sun, Mar 28, 2021 at 10:52:19AM +0000, Sami Mujawar wrote:
> Hi ilias,
> 
> Thank you for this series.
> 
> Pushed as afb0ce7e9756..89f6170d6686
> 

Thanks Sami!

> Regards,
> 
> Sami Mujawar
> 
> 
> From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Date: Saturday, 13 March 2021 at 18:32
> To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sughosh.ganu@linaro.org <sughosh.ganu@linaro.org>, leif@nuviainc.com <leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Subject: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA
> Hi,
> This is v7 of [1]
> 
> Changes since V6:
>  - Added param[in,out] in comments
>  - Fixed an error on Maintainers entry
> 
> Changes since V5:
>  - Addressed coding style fixes from Pierre
>  - Removed redundant checks in memory allocation and block usage
>  - Removed unused COMPRESSION_TOOL_GUID
>  - Renamed the files and directories following Leif's sugestion
>  - Added Sami and myself as maintainers
> 
> Changes since V4:
>  - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't
>    report.
>  - Adding missing error handling in InitializeFvAndVariableStoreHeaders().
>    An allocation wasn't properly checked for success
> 
> Changes since V3:
>  - Coding style fixes proposed by Sami
>  - Fixed all reported PatchCheck errors
>  - Added overflow checks on the base aaddress allocated for EFI variables.
>    The size of the partition is user defined (via Pcd's) and the memory layout
>    and allocation address depends on OP-TEE. So let's make sure we won't overflow
>    when calculating the 3 partitions needed for FTW
>  - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing
>  - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc
>  - Added reviewed-by tags on patch 2/2
> 
> Changes since V2:
>  - Allocate a dynamic number of pages based on the Pcd values instead
>    of a static number
>  - Clean up unused structs in header file
>  - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0
> 
> Changes since V1:
> Some enhancements made by Ilias to the Optee Rpmb driver
> 
> [1] https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661
> 
> Ilias Apalodimas (3):
>   Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
>   StMMRpmb: Add support for building StandaloneMm image for OP-TEE
>   Maintainers: Add maintainers for StandAloneMM and RPMB driver
> 
>  Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c         |  81 ++
>  Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf       |  43 +
>  Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf    |  58 ++
>  Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c     | 861 ++++++++++++++++++
>  Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h     |  51 ++
>  Maintainers.txt                               |  10 +
>  .../PlatformStandaloneMmRpmb.dsc              | 162 ++++
>  .../PlatformStandaloneMmRpmb.fdf              | 111 +++
>  8 files changed, 1377 insertions(+)
>  create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c
>  create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf
>  create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf
>  create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c
>  create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h
>  create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
>  create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf
> 
> --
> 2.30.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73419): https://edk2.groups.io/g/devel/message/73419
Mute This Topic: https://groups.io/mt/81309166/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-