[edk2-devel] [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model

Sami Mujawar posted 12 patches 3 years, 2 months ago
Failed in applying to current master (apply log)
Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf                                                |  38 --
Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl                                                      | 123 -------
Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc                                                     |  80 -----
Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h                                                 |  40 ---
Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc                                                     | 169 ---------
Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc                                                     |  85 -----
Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc                                                     |  82 -----
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                              |  49 ++-
Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf                                              |  33 +-
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          |  27 +-
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl       | 204 +++++++++++
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 376 +++++++++++++++++++-
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  36 +-
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  10 +-
Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c                                       | 110 +++++-
Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf                                     |   4 +-
Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h                                      |   6 +-
Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h                                            |   5 +-
Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf                            |  12 +-
Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c                                     |  31 +-
Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c        | 208 +++++++++++
Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf      |  48 +++
Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni      |  14 +
23 files changed, 1124 insertions(+), 666 deletions(-)
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc
delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc
create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c
create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf
create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni
[edk2-devel] [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model
Posted by Sami Mujawar 3 years, 2 months ago
The Armv8-A Base RevC AEM FVP model includes a SMMUv3 and a PCIe
subsystem. The FVP RevC model has an AHCI controller that appears
as a device on the PCIe bus. The model parameters further allow
a file on the host PC to be exposed as a SATA disk.

AHCI is one of the defined boot mechanisms for a standards-based
Operating System. Therefore, add support for the FVP RevC model.

More information on the Armv8-A Base RevC AEM FVP model can be
found at: https://developer.arm.com/tools-and-software/
simulation-models/fixed-virtual-platforms/arm-ecosystem-models

The ACPI support for RevC model is implemented using Dynamic
Tables Framework. This enables unification of the firmware
for FVP_Base_AEMv8A-AEMv8A and FVP_Base_RevC-2xAEMv8A models
such that the same firmware binary can be used by both models.

The last patch in this series drops support for the traditional
ACPI tables as these are now redundant.

The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1599_fvp_revc_v1

Sami Mujawar (12):
  Platform/ARM/VExpressPkg: FVP RevC SysID.Rev defintion
  Platform/ARM/VExpressPkg: Add PCIe Host Bridge lib for FVP
  Platform/ARM/VExpressPkg: Memory map for FVP RevC model
  Platform/ARM/VExpressPkg: Configure SMMUv3 for FVP RevC
  Platform/ARM/VExpressPkg: Helper macro to map reference token
  Platform/ARM/VExpressPkg: ACPI support for FVP RevC model
  Platform/ARM/VExpressPkg: Add support for FVP RevC model
  Platform/ARM/VExpressPkg: Update ACPI Revision to 6.3
  Platform/ARM/VExpressPkg: Add SMC91x device description
  Platform/ARM/VExpressPkg: Add Virtio Block Device description
  Platform/ARM/VExpressPkg: Make Dynamic Tables Framework default
  Platform/ARM/VExpressPkg: Remove redundant traditional ACPI support

 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf                                                |  38 --
 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl                                                      | 123 -------
 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc                                                     |  80 -----
 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h                                                 |  40 ---
 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc                                                     | 169 ---------
 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc                                                     |  85 -----
 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc                                                     |  82 -----
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                              |  49 ++-
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf                                              |  33 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          |  27 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl       | 204 +++++++++++
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 376 +++++++++++++++++++-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  36 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  10 +-
 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c                                       | 110 +++++-
 Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf                                     |   4 +-
 Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h                                      |   6 +-
 Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h                                            |   5 +-
 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf                            |  12 +-
 Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c                                     |  31 +-
 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c        | 208 +++++++++++
 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf      |  48 +++
 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni      |  14 +
 23 files changed, 1124 insertions(+), 666 deletions(-)
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc
 delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc
 create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
 create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c
 create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf
 create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71634): https://edk2.groups.io/g/devel/message/71634
Mute This Topic: https://groups.io/mt/80580210/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model
Posted by Ard Biesheuvel 3 years, 2 months ago
On Fri, 12 Feb 2021 at 11:24, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> The Armv8-A Base RevC AEM FVP model includes a SMMUv3 and a PCIe
> subsystem. The FVP RevC model has an AHCI controller that appears
> as a device on the PCIe bus. The model parameters further allow
> a file on the host PC to be exposed as a SATA disk.
>
> AHCI is one of the defined boot mechanisms for a standards-based
> Operating System. Therefore, add support for the FVP RevC model.
>
> More information on the Armv8-A Base RevC AEM FVP model can be
> found at: https://developer.arm.com/tools-and-software/
> simulation-models/fixed-virtual-platforms/arm-ecosystem-models
>
> The ACPI support for RevC model is implemented using Dynamic
> Tables Framework. This enables unification of the firmware
> for FVP_Base_AEMv8A-AEMv8A and FVP_Base_RevC-2xAEMv8A models
> such that the same firmware binary can be used by both models.
>
> The last patch in this series drops support for the traditional
> ACPI tables as these are now redundant.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1599_fvp_revc_v1
>
> Sami Mujawar (12):
>   Platform/ARM/VExpressPkg: FVP RevC SysID.Rev defintion
>   Platform/ARM/VExpressPkg: Add PCIe Host Bridge lib for FVP
>   Platform/ARM/VExpressPkg: Memory map for FVP RevC model
>   Platform/ARM/VExpressPkg: Configure SMMUv3 for FVP RevC
>   Platform/ARM/VExpressPkg: Helper macro to map reference token
>   Platform/ARM/VExpressPkg: ACPI support for FVP RevC model
>   Platform/ARM/VExpressPkg: Add support for FVP RevC model
>   Platform/ARM/VExpressPkg: Update ACPI Revision to 6.3
>   Platform/ARM/VExpressPkg: Add SMC91x device description
>   Platform/ARM/VExpressPkg: Add Virtio Block Device description
>   Platform/ARM/VExpressPkg: Make Dynamic Tables Framework default
>   Platform/ARM/VExpressPkg: Remove redundant traditional ACPI support
>

For the series,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as f62887cbb37e..404a76c577fc

Thanks!


>  Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf                                                |  38 --
>  Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl                                                      | 123 -------
>  Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc                                                     |  80 -----
>  Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h                                                 |  40 ---
>  Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc                                                     | 169 ---------
>  Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc                                                     |  85 -----
>  Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc                                                     |  82 -----
>  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                              |  49 ++-
>  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf                                              |  33 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          |  27 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl       | 204 +++++++++++
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 376 +++++++++++++++++++-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  36 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  10 +-
>  Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c                                       | 110 +++++-
>  Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf                                     |   4 +-
>  Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h                                      |   6 +-
>  Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h                                            |   5 +-
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf                            |  12 +-
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c                                     |  31 +-
>  Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c        | 208 +++++++++++
>  Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf      |  48 +++
>  Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni      |  14 +
>  23 files changed, 1124 insertions(+), 666 deletions(-)
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc
>  delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc
>  create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
>  create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c
>  create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf
>  create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71662): https://edk2.groups.io/g/devel/message/71662
Mute This Topic: https://groups.io/mt/80580210/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-