[edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume

Laszlo Ersek posted 4 patches 3 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210119155440.2262-1-lersek@redhat.com
OvmfPkg/CpuS3DataDxe/CpuS3Data.c                                   | 70 +----------------
OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf                              |  1 -
UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                                | 32 --------
UefiCpuPkg/Include/AcpiCpuData.h                                   |  4 +
UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 80 +++++++++++---------
5 files changed, 48 insertions(+), 139 deletions(-)
[edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume
Posted by Laszlo Ersek 3 years, 3 months ago
Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=3159
Repo:   https://pagure.io/lersek/edk2.git
Branch: remove-cpu-reg-table-alloc-3159-v2

Updates in v2:

- v1 patches have not received any updates, I've only picked up the
  feedback tags.

- Patch v2 #1 -- for RegisterCpuFeaturesLib -- is new; authored by Ray
  and updated slightly by myself. Star and/or Eric should please approve
  this patch.

v1 was posted at:

  [edk2-devel] [PATCH 0/3] UefiCpuPkg, OvmfPkg: do not allocate useless
  register tables for S3 resume

  Message-Id: <20210112191934.12459-1-lersek@redhat.com>
  https://edk2.groups.io/g/devel/message/70167
  https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00652.html

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>

Thanks
Laszlo

Laszlo Ersek (3):
  UefiCpuPkg/AcpiCpuData: update comments on register table fields
  UefiCpuPkg/CpuS3DataDxe: do not allocate useless register tables
  OvmfPkg/CpuS3DataDxe: do not allocate useless register tables

Ray Ni (1):
  UefiCpuPkg/CpuFeature: Don't assume CpuS3DataDxe alloc RegisterTable

 OvmfPkg/CpuS3DataDxe/CpuS3Data.c                                   | 70 +----------------
 OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf                              |  1 -
 UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                                | 32 --------
 UefiCpuPkg/Include/AcpiCpuData.h                                   |  4 +
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 80 +++++++++++---------
 5 files changed, 48 insertions(+), 139 deletions(-)


base-commit: 83facfd184021874f95a6a34b2e47e0ebb34a762
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70548): https://edk2.groups.io/g/devel/message/70548
Mute This Topic: https://groups.io/mt/79954423/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume
Posted by Laszlo Ersek 3 years, 3 months ago
On 01/19/21 16:54, Laszlo Ersek wrote:
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=3159
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: remove-cpu-reg-table-alloc-3159-v2
> 
> Updates in v2:
> 
> - v1 patches have not received any updates, I've only picked up the
>   feedback tags.

I didn't regenerate the CC's for the v1-originated patches, so the CC
list still uses Ard's @arm.com email address. I don't think that's a
problem for this specific posting (and I expect to merge this series
once Eric or Star approves patch v2 #1).

Thanks
Laszlo

> 
> - Patch v2 #1 -- for RegisterCpuFeaturesLib -- is new; authored by Ray
>   and updated slightly by myself. Star and/or Eric should please approve
>   this patch.
> 
> v1 was posted at:
> 
>   [edk2-devel] [PATCH 0/3] UefiCpuPkg, OvmfPkg: do not allocate useless
>   register tables for S3 resume
> 
>   Message-Id: <20210112191934.12459-1-lersek@redhat.com>
>   https://edk2.groups.io/g/devel/message/70167
>   https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00652.html
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   UefiCpuPkg/AcpiCpuData: update comments on register table fields
>   UefiCpuPkg/CpuS3DataDxe: do not allocate useless register tables
>   OvmfPkg/CpuS3DataDxe: do not allocate useless register tables
> 
> Ray Ni (1):
>   UefiCpuPkg/CpuFeature: Don't assume CpuS3DataDxe alloc RegisterTable
> 
>  OvmfPkg/CpuS3DataDxe/CpuS3Data.c                                   | 70 +----------------
>  OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf                              |  1 -
>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                                | 32 --------
>  UefiCpuPkg/Include/AcpiCpuData.h                                   |  4 +
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 80 +++++++++++---------
>  5 files changed, 48 insertions(+), 139 deletions(-)
> 
> 
> base-commit: 83facfd184021874f95a6a34b2e47e0ebb34a762
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70553): https://edk2.groups.io/g/devel/message/70553
Mute This Topic: https://groups.io/mt/79954423/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume
Posted by Zeng, Star 3 years, 3 months ago
Series Reviewed-by: Star Zeng <star.zeng@intel.com>

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, January 19, 2021 11:55 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Dong, Eric
> <eric.dong@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Philippe Mathieu-Daudé <philmd@redhat.com>; Kumar, Rahul1
> <rahul1.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless
> register tables for S3 resume
> 
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=3159
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: remove-cpu-reg-table-alloc-3159-v2
> 
> Updates in v2:
> 
> - v1 patches have not received any updates, I've only picked up the
>   feedback tags.
> 
> - Patch v2 #1 -- for RegisterCpuFeaturesLib -- is new; authored by Ray
>   and updated slightly by myself. Star and/or Eric should please approve
>   this patch.
> 
> v1 was posted at:
> 
>   [edk2-devel] [PATCH 0/3] UefiCpuPkg, OvmfPkg: do not allocate useless
>   register tables for S3 resume
> 
>   Message-Id: <20210112191934.12459-1-lersek@redhat.com>
>   https://edk2.groups.io/g/devel/message/70167
>   https://www.redhat.com/archives/edk2-devel-archive/2021-
> January/msg00652.html
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   UefiCpuPkg/AcpiCpuData: update comments on register table fields
>   UefiCpuPkg/CpuS3DataDxe: do not allocate useless register tables
>   OvmfPkg/CpuS3DataDxe: do not allocate useless register tables
> 
> Ray Ni (1):
>   UefiCpuPkg/CpuFeature: Don't assume CpuS3DataDxe alloc RegisterTable
> 
>  OvmfPkg/CpuS3DataDxe/CpuS3Data.c                                   | 70 +---------------
> -
>  OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf                              |  1 -
>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                                | 32 --------
>  UefiCpuPkg/Include/AcpiCpuData.h                                   |  4 +
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 80
> +++++++++++---------
>  5 files changed, 48 insertions(+), 139 deletions(-)
> 
> 
> base-commit: 83facfd184021874f95a6a34b2e47e0ebb34a762
> --
> 2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70569): https://edk2.groups.io/g/devel/message/70569
Mute This Topic: https://groups.io/mt/79954423/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume
Posted by Laszlo Ersek 3 years, 2 months ago
On 01/20/21 10:28, Zeng, Star wrote:
> Series Reviewed-by: Star Zeng <star.zeng@intel.com>

Series merged as commit range e843a21e23ea..339371ef78eb, via
<https://github.com/tianocore/edk2/pull/1373>.

Thanks!
Laszlo

> 
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Tuesday, January 19, 2021 11:55 PM
>> To: edk2-devel-groups-io <devel@edk2.groups.io>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Dong, Eric
>> <eric.dong@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
>> Philippe Mathieu-Daudé <philmd@redhat.com>; Kumar, Rahul1
>> <rahul1.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
>> <star.zeng@intel.com>
>> Subject: [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless
>> register tables for S3 resume
>>
>> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=3159
>> Repo:   https://pagure.io/lersek/edk2.git
>> Branch: remove-cpu-reg-table-alloc-3159-v2
>>
>> Updates in v2:
>>
>> - v1 patches have not received any updates, I've only picked up the
>>   feedback tags.
>>
>> - Patch v2 #1 -- for RegisterCpuFeaturesLib -- is new; authored by Ray
>>   and updated slightly by myself. Star and/or Eric should please approve
>>   this patch.
>>
>> v1 was posted at:
>>
>>   [edk2-devel] [PATCH 0/3] UefiCpuPkg, OvmfPkg: do not allocate useless
>>   register tables for S3 resume
>>
>>   Message-Id: <20210112191934.12459-1-lersek@redhat.com>
>>   https://edk2.groups.io/g/devel/message/70167
>>   https://www.redhat.com/archives/edk2-devel-archive/2021-
>> January/msg00652.html
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   UefiCpuPkg/AcpiCpuData: update comments on register table fields
>>   UefiCpuPkg/CpuS3DataDxe: do not allocate useless register tables
>>   OvmfPkg/CpuS3DataDxe: do not allocate useless register tables
>>
>> Ray Ni (1):
>>   UefiCpuPkg/CpuFeature: Don't assume CpuS3DataDxe alloc RegisterTable
>>
>>  OvmfPkg/CpuS3DataDxe/CpuS3Data.c                                   | 70 +---------------
>> -
>>  OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf                              |  1 -
>>  UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c                                | 32 --------
>>  UefiCpuPkg/Include/AcpiCpuData.h                                   |  4 +
>>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 80
>> +++++++++++---------
>>  5 files changed, 48 insertions(+), 139 deletions(-)
>>
>>
>> base-commit: 83facfd184021874f95a6a34b2e47e0ebb34a762
>> --
>> 2.19.1.3.g30247aa5d201
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70596): https://edk2.groups.io/g/devel/message/70596
Mute This Topic: https://groups.io/mt/79954423/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-