1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.

nmd5434 posted 1 patch 3 years, 3 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
Posted by nmd5434 3 years, 3 months ago 
From: Zarcd Zhong <zarcd.zhong@intel.com>

    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149

    Address MEM64 BAR in type unknown if sizing fail in high 32bit.

    L: devel@edk2.groups.io
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Hao A Wu <hao.a.wu@intel.com>

    Reviewed-by: Ray Ni <ray.ni@intel.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 1b64924b7b..a24065e8ba 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -1686,6 +1686,7 @@ PciIovParseVfBar (
                 );
 
       if (EFI_ERROR (Status)) {
+        PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
         return Offset + 4;
       }
 
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70427): https://edk2.groups.io/g/devel/message/70427
Mute This Topic: https://groups.io/mt/79438989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
Posted by Zhong, Zarcd 3 years, 3 months ago 
Hi All,

 Below mail is sent by GIT send-email.  Please help to push it to EDKII. Thanks.



-----Original Message-----
From: nmd5434 <nmd114@sina.com> 
Sent: Friday, January 15, 2021 5:34 PM
To: devel@edk2.groups.io
Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.

From: Zarcd Zhong <zarcd.zhong@intel.com>

    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149

    Address MEM64 BAR in type unknown if sizing fail in high 32bit.

    L: devel@edk2.groups.io
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Hao A Wu <hao.a.wu@intel.com>

    Reviewed-by: Ray Ni <ray.ni@intel.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 1b64924b7b..a24065e8ba 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -1686,6 +1686,7 @@ PciIovParseVfBar (
                 );
 
       if (EFI_ERROR (Status)) {
+        PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
         return Offset + 4;
       }
 
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70428): https://edk2.groups.io/g/devel/message/70428
Mute This Topic: https://groups.io/mt/79438989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
Posted by Wu, Hao A 3 years, 2 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> nmd5434
> Sent: Friday, January 15, 2021 5:34 PM
> To: devel@edk2.groups.io
> Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle
> BAR sizing fail in high 32bit of MEM64.
> 
> From: Zarcd Zhong <zarcd.zhong@intel.com>
> 
>     REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
> 
>     Address MEM64 BAR in type unknown if sizing fail in high 32bit.
> 
>     L: devel@edk2.groups.io
>     Cc: Ray Ni <ray.ni@intel.com>
>     Cc: Hao A Wu <hao.a.wu@intel.com>
> 
>     Reviewed-by: Ray Ni <ray.ni@intel.com>


Found that there is no "Signed-off-by:" tag.
Will add the tag when pushing this change.

Best Regards,
Hao Wu


> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 1b64924b7b..a24065e8ba 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -1686,6 +1686,7 @@ PciIovParseVfBar (
>                  );
> 
>        if (EFI_ERROR (Status)) {
> +        PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
>          return Offset + 4;
>        }
> 
> --
> 2.16.2.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70469): https://edk2.groups.io/g/devel/message/70469
Mute This Topic: https://groups.io/mt/79438989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
Posted by Wu, Hao A 3 years, 2 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Monday, January 18, 2021 9:12 AM
> To: devel@edk2.groups.io; nmd114@sina.com
> Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe:
> Handle BAR sizing fail in high 32bit of MEM64.
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > nmd5434
> > Sent: Friday, January 15, 2021 5:34 PM
> > To: devel@edk2.groups.io
> > Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> > Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle
> > BAR sizing fail in high 32bit of MEM64.
> >
> > From: Zarcd Zhong <zarcd.zhong@intel.com>
> >
> >     REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
> >
> >     Address MEM64 BAR in type unknown if sizing fail in high 32bit.
> >
> >     L: devel@edk2.groups.io
> >     Cc: Ray Ni <ray.ni@intel.com>
> >     Cc: Hao A Wu <hao.a.wu@intel.com>
> >
> >     Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> 
> Found that there is no "Signed-off-by:" tag.
> Will add the tag when pushing this change.


Patch pushed via:
PR - https://github.com/tianocore/edk2/pull/1360
Commit - https://github.com/tianocore/edk2/commit/a7ef2a03b96c464c776a139c104471fb2b84e39b

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > index 1b64924b7b..a24065e8ba 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > @@ -1686,6 +1686,7 @@ PciIovParseVfBar (
> >                  );
> >
> >        if (EFI_ERROR (Status)) {
> > +        PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
> >          return Offset + 4;
> >        }
> >
> > --
> > 2.16.2.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70472): https://edk2.groups.io/g/devel/message/70472
Mute This Topic: https://groups.io/mt/79438989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.