[v3] Add support for using FF-A calls

[edk2-devel] [PATCH v3 00/13] Add support for using FF-A calls

Posted by Sughosh Ganu 3 years, 3 months ago

The following patch series adds support for using the Firmware
Framework(FF-A) as a transport mechanism for requesting services from
the Secure Partition Manager(SPM). This is done through a Pcd which
can be used to enable the FF-A mechanism or to use the earlier used
SVC calls.

The patches have been pushed to my github repository[1]

Changes since V2:
* Added a STATIC storage class specifier for mSpmMajorVer and
  mSpmMinorVer variables
* Added a STATIC storage class specifier for mSpmMajorVerFfa and
  mSpmMinorVerFfa variables
* Add braces for if/else statements
* Add a check for EFI_NOT_FOUND as a possible return value from
  LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint function
* Check for the return value in Arg0 after the Direct Request call to
  handle errors returned
* Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
  response won't be expected in return to a Direct Request call to get
  the memory attributes
* Check for the return value in Arg0 after the Direct Request call to
  handle errors returned
* Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
  response won't be expected in return to a Direct Request call to set
  the memory attributes

Changes since V1:
Handled review comments from Sami Mujawar

[1] - https://github.com/SNG-ARM/edk2/tree/implement_ffa_svc_optional_v3

Achin Gupta (7):
  ArmPkg/IndustryStandard: Add barebones FF-A header
  ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
  StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry
    point
  StandaloneMmPkg: Add option to use FF-A calls for communication with
    SPM
  StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library
  StandaloneMmMmuLib: Allow FF-A calls to get memory region's attributes
  StandaloneMmMmuLib: Allow FF-A calls to set memory region's attributes

Ilias Apalodimas (2):
  MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase
    to Pcd
  StandaloneMmPkg: Allow sending FFA Direct Request message to
    StandaloneMm

Sughosh Ganu (4):
  ArmPkg: Introduce support for PcdFfaEnable
  StandaloneMmPkg: Add macros for SPM version
  StandaloneMmPkg: Add the SPM version for FF-A
  StandaloneMmPkg: Add option to use FF-A calls for getting SPM version

 ArmPkg/ArmPkg.dec                             |   6 +
 .../ArmMmuStandaloneMmLib.inf                 |   3 +
 .../RuntimeDxe/VariableStandaloneMm.inf       |   6 +-
 .../StandaloneMmCoreEntryPoint.inf            |   3 +
 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h   |  44 +++++
 ArmPkg/Include/IndustryStandard/ArmMmSvc.h    |   3 +
 ArmPkg/Include/Library/ArmSvcLib.h            |  10 +-
 .../AArch64/ArmMmuStandaloneMmLib.c           | 167 +++++++++++++++---
 .../StandaloneMmCpu/AArch64/EventHandle.c     |   4 +-
 .../AArch64/StandaloneMmCoreEntryPoint.c      | 133 +++++++++++---
 ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S     |   4 +-
 11 files changed, 322 insertions(+), 61 deletions(-)
 create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h

-- 
2.17.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70357): https://edk2.groups.io/g/devel/message/70357
Mute This Topic: https://groups.io/mt/79696437/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 00/13] Add support for using FF-A calls

Posted by gaoliming 3 years, 2 months ago

Sughosh:
  This is a new feature. Can you submit one BZ
(https://bugzilla.tianocore.org/) to record it?

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70357+4905953+8761045@groups.io
> <bounce+27952+70357+4905953+8761045@groups.io> 代表 Sughosh Ganu
> 发送时间: 2021年1月15日 14:14
> 收件人: devel@edk2.groups.io
> 抄送: Sami Mujawar <sami.mujawar@arm.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com>; Sahil
> Malhotra <sahil.malhotra@linaro.org>; Ilias Apalodimas
> <ilias.apalodimas@linaro.org>
> 主题: [edk2-devel] [PATCH v3 00/13] Add support for using FF-A calls
> 
> 
> The following patch series adds support for using the Firmware
> Framework(FF-A) as a transport mechanism for requesting services from
> the Secure Partition Manager(SPM). This is done through a Pcd which
> can be used to enable the FF-A mechanism or to use the earlier used
> SVC calls.
> 
> The patches have been pushed to my github repository[1]
> 
> Changes since V2:
> * Added a STATIC storage class specifier for mSpmMajorVer and
>   mSpmMinorVer variables
> * Added a STATIC storage class specifier for mSpmMajorVerFfa and
>   mSpmMinorVerFfa variables
> * Add braces for if/else statements
> * Add a check for EFI_NOT_FOUND as a possible return value from
>   LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint function
> * Check for the return value in Arg0 after the Direct Request call to
>   handle errors returned
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
>   response won't be expected in return to a Direct Request call to get
>   the memory attributes
> * Check for the return value in Arg0 after the Direct Request call to
>   handle errors returned
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
>   response won't be expected in return to a Direct Request call to set
>   the memory attributes
> 
> Changes since V1:
> Handled review comments from Sami Mujawar
> 
> [1] -
> https://github.com/SNG-ARM/edk2/tree/implement_ffa_svc_optional_v3
> 
> Achin Gupta (7):
>   ArmPkg/IndustryStandard: Add barebones FF-A header
>   ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
>   StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry
>     point
>   StandaloneMmPkg: Add option to use FF-A calls for communication with
>     SPM
>   StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU
> library
>   StandaloneMmMmuLib: Allow FF-A calls to get memory region's attributes
>   StandaloneMmMmuLib: Allow FF-A calls to set memory region's attributes
> 
> Ilias Apalodimas (2):
>   MdeModulePkg/VariableStandaloneMm: Set
> PcdFlashNvStorageVariableBase
>     to Pcd
>   StandaloneMmPkg: Allow sending FFA Direct Request message to
>     StandaloneMm
> 
> Sughosh Ganu (4):
>   ArmPkg: Introduce support for PcdFfaEnable
>   StandaloneMmPkg: Add macros for SPM version
>   StandaloneMmPkg: Add the SPM version for FF-A
>   StandaloneMmPkg: Add option to use FF-A calls for getting SPM version
> 
>  ArmPkg/ArmPkg.dec                             |   6 +
>  .../ArmMmuStandaloneMmLib.inf                 |   3 +
>  .../RuntimeDxe/VariableStandaloneMm.inf       |   6 +-
>  .../StandaloneMmCoreEntryPoint.inf            |   3 +
>  ArmPkg/Include/IndustryStandard/ArmFfaSvc.h   |  44 +++++
>  ArmPkg/Include/IndustryStandard/ArmMmSvc.h    |   3 +
>  ArmPkg/Include/Library/ArmSvcLib.h            |  10 +-
>  .../AArch64/ArmMmuStandaloneMmLib.c           | 167
> +++++++++++++++---
>  .../StandaloneMmCpu/AArch64/EventHandle.c     |   4 +-
>  .../AArch64/StandaloneMmCoreEntryPoint.c      | 133 +++++++++++---
>  ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S     |   4 +-
>  11 files changed, 322 insertions(+), 61 deletions(-)
>  create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
> 
> --
> 2.17.1
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71773): https://edk2.groups.io/g/devel/message/71773
Mute This Topic: https://groups.io/mt/80722065/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-