[edk2-devel] [PATCH v5 00/10] Add extra pci roots support for Arm

Jiahui Cen via groups.io posted 10 patches 5 days, 3 hours ago
Failed in applying to current master (apply log)
OvmfPkg/OvmfPkg.dec                                                                                        |   4 +
ArmVirtPkg/ArmVirtKvmTool.dsc                                                                              |   1 +
ArmVirtPkg/ArmVirtQemu.dsc                                                                                 |   2 +
ArmVirtPkg/ArmVirtQemuKernel.dsc                                                                           |   2 +
OvmfPkg/AmdSev/AmdSevX64.dsc                                                                               |   1 +
OvmfPkg/Bhyve/BhyveX64.dsc                                                                                 |   1 +
OvmfPkg/OvmfPkgIa32.dsc                                                                                    |   1 +
OvmfPkg/OvmfPkgIa32X64.dsc                                                                                 |   1 +
OvmfPkg/OvmfPkgX64.dsc                                                                                     |   1 +
OvmfPkg/OvmfXen.dsc                                                                                        |   1 +
ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf                                             |   3 +
OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf                                                      |   4 +-
OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf                                        |  43 +++
OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h                                                          | 182 +++++++++++
OvmfPkg/Library/PciHostBridgeLib/PciHostBridge.h                                                           |  56 ----
ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c                                               | 164 ++++------
OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c                                                        | 322 +-------------------
OvmfPkg/Library/PciHostBridgeLib/XenSupport.c                                                              |   5 +-
OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} | 237 +++++++-------
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc                                                                       |   1 +
20 files changed, 433 insertions(+), 599 deletions(-)
create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h
copy OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} (58%)

[edk2-devel] [PATCH v5 00/10] Add extra pci roots support for Arm

Posted by Jiahui Cen via groups.io 5 days, 3 hours ago
v4->v5:
* Revert some risky renames.
* Explicitly list PcdLib dependency.
* Fix issues reported by PatchCheck.py.

v3->v4:
* Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
* Fix library dependencies.

v2->v3:
* Rename utility functions under the PciHostBridgeUtilityLib namespace.
* Remove some unused Library dependencies.
* Sort the Include headers.

v1->v2:
* Separated into four patches.
* Factor the same logic parts into a new library.

v4: https://edk2.groups.io/g/devel/message/70147
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/

This patch series adds support for extra pci roots for ARM.

In order to avoid duplicated codes, we introduce a new library
PciHostBridgeUtilityLib which extracts common interfaces from
OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
roots scanning. Using the utility lib, the uefi could scan for extra
root buses and recognize multiple roots for ARM.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
Signed-off-by: Yubo Miao <miaoyubo@huawei.com>

Jiahui Cen (10):
  OvmfPkg: Introduce PciHostBridgeUtilityLib class
  ArmVirtPkg: Refactor with PciHostBridgeUtilityLib
  OvmfPkg/PciHostBridgeLib: List missing PcdLib dependency
  OvmfPkg/PciHostBridgeLib: Extract Init/UninitRootBridge
  OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of
    InitRootBridge
  ArmVirtPkg/FdtPciHostBridgeLib: Refactor Init/UninitRootBridge()
  OvmfPkg/PciHostBridgeLib: Extract Get/FreeRootBridges
  OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of
    GetRootBridges
  ArmVirtPkg/FdtPciHostBridgeLib: Refactor Get/FreeRootBridges()
  ArmVirtPkg/ArmVirtQemu: Add support for HotPlug

 OvmfPkg/OvmfPkg.dec                                                                                        |   4 +
 ArmVirtPkg/ArmVirtKvmTool.dsc                                                                              |   1 +
 ArmVirtPkg/ArmVirtQemu.dsc                                                                                 |   2 +
 ArmVirtPkg/ArmVirtQemuKernel.dsc                                                                           |   2 +
 OvmfPkg/AmdSev/AmdSevX64.dsc                                                                               |   1 +
 OvmfPkg/Bhyve/BhyveX64.dsc                                                                                 |   1 +
 OvmfPkg/OvmfPkgIa32.dsc                                                                                    |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc                                                                                 |   1 +
 OvmfPkg/OvmfPkgX64.dsc                                                                                     |   1 +
 OvmfPkg/OvmfXen.dsc                                                                                        |   1 +
 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf                                             |   3 +
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf                                                      |   4 +-
 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf                                        |  43 +++
 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h                                                          | 182 +++++++++++
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridge.h                                                           |  56 ----
 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c                                               | 164 ++++------
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c                                                        | 322 +-------------------
 OvmfPkg/Library/PciHostBridgeLib/XenSupport.c                                                              |   5 +-
 OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} | 237 +++++++-------
 ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc                                                                       |   1 +
 20 files changed, 433 insertions(+), 599 deletions(-)
 create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
 create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h
 copy OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} (58%)

-- 
2.29.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70237): https://edk2.groups.io/g/devel/message/70237
Mute This Topic: https://groups.io/mt/79647744/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v5 00/10] Add extra pci roots support for Arm

Posted by Laszlo Ersek 5 days, 3 hours ago
On 01/13/21 11:33, Jiahui Cen wrote:
> v4->v5:
> * Revert some risky renames.
> * Explicitly list PcdLib dependency.
> * Fix issues reported by PatchCheck.py.

... I wasn't done reviewing v4, I just stopped reviewing the v4 series
for today. (There's only so much review I can perform in a single day --
I spent a bit more than two hours reviewing patches 1-5 in the v4 series.)

I think I'll ignore v5 for now, and continue with the rest of v4
tomorrow (patch #6 and onwards). Then I'll compare v4 <-> v6.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70248): https://edk2.groups.io/g/devel/message/70248
Mute This Topic: https://groups.io/mt/79647744/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-