[v4] Add extra pci roots support for Arm

[edk2-devel] [PATCH v4 0/9] Add extra pci roots support for Arm

Posted by Jiahui Cen via groups.io 3 years, 3 months ago

v3->v4:
* Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
* Fix library dependencies.

v2->v3:
* Rename utility functions under the PciHostBridgeUtilityLib namespace.
* Remove some unused Library dependencies.
* Sort the Include headers.

v1->v2:
* Separated into four patches.
* Factor the same logic parts into a new library.

v3: https://edk2.groups.io/g/devel/message/69382
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/

This patch series adds support for extra pci roots for ARM.

In order to avoid duplicated codes, we introduce a new library
PciHostBridgeUtilityLib which extracts common interfaces from
OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
roots scanning. Using the utility lib, the uefi could scan for extra
root buses and recognize multiple roots for ARM.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
Signed-off-by: Yubo Miao <miaoyubo@huawei.com>

Jiahui Cen (9):
  OvmfPkg: Introduce PciHostBridgeUtilityLib class
  ArmVirtPkg: Refactor with PciHostBridgeUtilityLib
  OvmfPkg/PciHostBridgeLib: Extract InitRootBridge/UninitRootBridge
  OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of
    InitRootBridge
  ArmVirtPkg/FdtPciHostBridgeLib: Rebase to InitRootBridge() /
    UninitRootBridge()
  OvmfPkg/PciHostBridgeLib: Extract GetRootBridges/FreeRootBridges
  OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of
    GetRootBridges
  ArmVirtPkg/FdtPciHostBridgeLib: Refactor GetRootBridges() /
    FreeRootBridges()
  ArmVirtPkg/ArmVirtQemu: Add support for HotPlug

 OvmfPkg/OvmfPkg.dec                                                                                        |   4 +
 ArmVirtPkg/ArmVirtKvmTool.dsc                                                                              |   1 +
 ArmVirtPkg/ArmVirtQemu.dsc                                                                                 |   2 +
 ArmVirtPkg/ArmVirtQemuKernel.dsc                                                                           |   2 +
 OvmfPkg/AmdSev/AmdSevX64.dsc                                                                               |   1 +
 OvmfPkg/Bhyve/BhyveX64.dsc                                                                                 |   1 +
 OvmfPkg/OvmfPkgIa32.dsc                                                                                    |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc                                                                                 |   1 +
 OvmfPkg/OvmfPkgX64.dsc                                                                                     |   1 +
 OvmfPkg/OvmfXen.dsc                                                                                        |   1 +
 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf                                             |   3 +
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf                                                      |   3 +-
 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf                                        |  43 +++
 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h                                                          | 182 +++++++++++
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridge.h                                                           |  56 ----
 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c                                               | 164 ++++------
 OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c                                                        | 321 +-------------------
 OvmfPkg/Library/PciHostBridgeLib/XenSupport.c                                                              |   4 +-
 OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} | 247 ++++++++-------
 ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc                                                                       |   1 +
 20 files changed, 435 insertions(+), 604 deletions(-)
 create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
 create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h
 copy OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.c => PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c} (57%)

-- 
2.29.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70147): https://edk2.groups.io/g/devel/message/70147
Mute This Topic: https://groups.io/mt/79619790/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/9] Add extra pci roots support for Arm

Posted by Laszlo Ersek 3 years, 3 months ago

On 01/12/21 10:45, Jiahui Cen wrote:
> v3->v4:
> * Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
> * Fix library dependencies.
> 
> v2->v3:
> * Rename utility functions under the PciHostBridgeUtilityLib namespace.
> * Remove some unused Library dependencies.
> * Sort the Include headers.
> 
> v1->v2:
> * Separated into four patches.
> * Factor the same logic parts into a new library.
> 
> v3: https://edk2.groups.io/g/devel/message/69382
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
> QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/
> 
> This patch series adds support for extra pci roots for ARM.
> 
> In order to avoid duplicated codes, we introduce a new library
> PciHostBridgeUtilityLib which extracts common interfaces from
> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
> roots scanning. Using the utility lib, the uefi could scan for extra
> root buses and recognize multiple roots for ARM.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>

I've finished reviewing this version; please submit v6.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70282): https://edk2.groups.io/g/devel/message/70282
Mute This Topic: https://groups.io/mt/79619790/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/9] Add extra pci roots support for Arm

Posted by Jiahui Cen via groups.io 3 years, 3 months ago

Hi Laszlo,

On 2021/1/14 19:53, Laszlo Ersek wrote:
> On 01/12/21 10:45, Jiahui Cen wrote:
>> v3->v4:
>> * Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
>> * Fix library dependencies.
>>
>> v2->v3:
>> * Rename utility functions under the PciHostBridgeUtilityLib namespace.
>> * Remove some unused Library dependencies.
>> * Sort the Include headers.
>>
>> v1->v2:
>> * Separated into four patches.
>> * Factor the same logic parts into a new library.
>>
>> v3: https://edk2.groups.io/g/devel/message/69382
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>> QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/
>>
>> This patch series adds support for extra pci roots for ARM.
>>
>> In order to avoid duplicated codes, we introduce a new library
>> PciHostBridgeUtilityLib which extracts common interfaces from
>> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
>> roots scanning. Using the utility lib, the uefi could scan for extra
>> root buses and recognize multiple roots for ARM.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Peter Grehan <grehan@freebsd.org>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Julien Grall <julien@xen.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
> 
> I've finished reviewing this version; please submit v6.
> 

Thanks for the detailed review. I'll carefully fix them as you points
and submit v6 soon.

Thanks,
Jiahui

> Thanks
> Laszlo
> 
> .
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70287): https://edk2.groups.io/g/devel/message/70287
Mute This Topic: https://groups.io/mt/79619790/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/9] Add extra pci roots support for Arm

Posted by Laszlo Ersek 3 years, 3 months ago

On 01/14/21 13:51, Jiahui Cen via groups.io wrote:
> Hi Laszlo,
> 
> On 2021/1/14 19:53, Laszlo Ersek wrote:
>> On 01/12/21 10:45, Jiahui Cen wrote:
>>> v3->v4:
>>> * Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
>>> * Fix library dependencies.
>>>
>>> v2->v3:
>>> * Rename utility functions under the PciHostBridgeUtilityLib namespace.
>>> * Remove some unused Library dependencies.
>>> * Sort the Include headers.
>>>
>>> v1->v2:
>>> * Separated into four patches.
>>> * Factor the same logic parts into a new library.
>>>
>>> v3: https://edk2.groups.io/g/devel/message/69382
>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>>> QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/
>>>
>>> This patch series adds support for extra pci roots for ARM.
>>>
>>> In order to avoid duplicated codes, we introduce a new library
>>> PciHostBridgeUtilityLib which extracts common interfaces from
>>> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
>>> roots scanning. Using the utility lib, the uefi could scan for extra
>>> root buses and recognize multiple roots for ARM.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Cc: Rebecca Cran <rebecca@bsdio.com>
>>> Cc: Peter Grehan <grehan@freebsd.org>
>>> Cc: Anthony Perard <anthony.perard@citrix.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>>
>> I've finished reviewing this version; please submit v6.
>>
> 
> Thanks for the detailed review. I'll carefully fix them as you points
> and submit v6 soon.

I'm looking forward to v6; I'd really like to merge that, so I can move
on to reviewing other patches.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70507): https://edk2.groups.io/g/devel/message/70507
Mute This Topic: https://groups.io/mt/79619790/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-