[edk2-devel] [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output.

Ashley E Desimone posted 1 patch 3 months, 3 weeks ago
Failed in applying to current master (apply log)
edkrepo/commands/manifest_command.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

[edk2-devel] [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output.

Posted by Ashley E Desimone 3 months, 3 weeks ago
When displaying verbose output the manifest command now
shows the dev lead list for each project.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
---
 edkrepo/commands/manifest_command.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/edkrepo/commands/manifest_command.py b/edkrepo/commands/manifest_command.py
index 5c6184f..eb192db 100644
--- a/edkrepo/commands/manifest_command.py
+++ b/edkrepo/commands/manifest_command.py
@@ -9,6 +9,7 @@
 
 import copy
 import os
+import csv
 
 from colorama import Fore
 
@@ -21,8 +22,9 @@ from edkrepo.common.ui_functions import init_color_console
 from edkrepo.common.workspace_maintenance.manifest_repos_maintenance import list_available_manifest_repos
 from edkrepo.common.workspace_maintenance.manifest_repos_maintenance import pull_all_manifest_repos
 from edkrepo.common.workspace_maintenance.manifest_repos_maintenance import find_source_manifest_repo
+from edkrepo.common.workspace_maintenance.manifest_repos_maintenance import find_project_in_single_index
 from edkrepo.config.config_factory import get_workspace_manifest
-from edkrepo_manifest_parser.edk_manifest import CiIndexXml
+from edkrepo_manifest_parser.edk_manifest import CiIndexXml, ManifestXml
 
 
 class ManifestCommand(EdkrepoCommand):
@@ -100,6 +102,8 @@ class ManifestCommand(EdkrepoCommand):
                     print("  {}".format(project))
                 if args.verbose:
                     print("   -> {}".format(ci_index_xml.get_project_xml(project)))
+                    proj_manifest = ManifestXml(find_project_in_single_index(project, ci_index_xml, man_repos[repo][0])[1])
+                    print("   -> DevLead: {}".format(' '.join(x for x in proj_manifest.project_info.dev_leads)))
 
             if args.archived:
                 print()
@@ -111,3 +115,5 @@ class ManifestCommand(EdkrepoCommand):
                         print("  {}".format(project))
                     if args.verbose:
                         print("   -> {}".format(ci_index_xml.get_project_xml(project)))
+                        proj_manifest = ManifestXml(find_project_in_single_index(project, ci_index_xml, man_repos[repo][0])[1])
+                        print("   -> DevLead: {}".format(' '.join(x for x in proj_manifest.project_info.dev_leads)))
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70071): https://edk2.groups.io/g/devel/message/70071
Mute This Topic: https://groups.io/mt/79532061/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output.

Posted by Nate DeSimone 3 months, 2 weeks ago
Pushed: https://github.com/tianocore/edk2-staging/commit/efcd4c9

> -----Original Message-----
> From: Ashley E Desimone <ashley.e.desimone@intel.com>
> Sent: Friday, January 8, 2021 11:16 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C
> <erik.c.bjorge@intel.com>
> Subject: [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead
> information in verbose manifest command output.
> 
> When displaying verbose output the manifest command now shows the dev
> lead list for each project.
> 
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> ---
>  edkrepo/commands/manifest_command.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/edkrepo/commands/manifest_command.py
> b/edkrepo/commands/manifest_command.py
> index 5c6184f..eb192db 100644
> --- a/edkrepo/commands/manifest_command.py
> +++ b/edkrepo/commands/manifest_command.py
> @@ -9,6 +9,7 @@
> 
>  import copy
>  import os
> +import csv
> 
>  from colorama import Fore
> 
> @@ -21,8 +22,9 @@ from edkrepo.common.ui_functions import
> init_color_console  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import list_available_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import pull_all_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import find_source_manifest_repo
> +from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> +import find_project_in_single_index
>  from edkrepo.config.config_factory import get_workspace_manifest -from
> edkrepo_manifest_parser.edk_manifest import CiIndexXml
> +from edkrepo_manifest_parser.edk_manifest import CiIndexXml,
> +ManifestXml
> 
> 
>  class ManifestCommand(EdkrepoCommand):
> @@ -100,6 +102,8 @@ class ManifestCommand(EdkrepoCommand):
>                      print("  {}".format(project))
>                  if args.verbose:
>                      print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                    proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                    print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> 
>              if args.archived:
>                  print()
> @@ -111,3 +115,5 @@ class ManifestCommand(EdkrepoCommand):
>                          print("  {}".format(project))
>                      if args.verbose:
>                          print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                        proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                        print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> --
> 2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70563): https://edk2.groups.io/g/devel/message/70563
Mute This Topic: https://groups.io/mt/79532061/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead information in verbose manifest command output.

Posted by Nate DeSimone 3 months, 2 weeks ago
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Ashley E Desimone <ashley.e.desimone@intel.com>
> Sent: Friday, January 8, 2021 11:16 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C
> <erik.c.bjorge@intel.com>
> Subject: [Edk2-Staging/EdkRepo] [PATCH] EdkRepo: Show dev lead
> information in verbose manifest command output.
> 
> When displaying verbose output the manifest command now shows the dev
> lead list for each project.
> 
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> ---
>  edkrepo/commands/manifest_command.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/edkrepo/commands/manifest_command.py
> b/edkrepo/commands/manifest_command.py
> index 5c6184f..eb192db 100644
> --- a/edkrepo/commands/manifest_command.py
> +++ b/edkrepo/commands/manifest_command.py
> @@ -9,6 +9,7 @@
> 
>  import copy
>  import os
> +import csv
> 
>  from colorama import Fore
> 
> @@ -21,8 +22,9 @@ from edkrepo.common.ui_functions import
> init_color_console  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import list_available_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import pull_all_manifest_repos  from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> import find_source_manifest_repo
> +from
> edkrepo.common.workspace_maintenance.manifest_repos_maintenance
> +import find_project_in_single_index
>  from edkrepo.config.config_factory import get_workspace_manifest -from
> edkrepo_manifest_parser.edk_manifest import CiIndexXml
> +from edkrepo_manifest_parser.edk_manifest import CiIndexXml,
> +ManifestXml
> 
> 
>  class ManifestCommand(EdkrepoCommand):
> @@ -100,6 +102,8 @@ class ManifestCommand(EdkrepoCommand):
>                      print("  {}".format(project))
>                  if args.verbose:
>                      print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                    proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                    print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> 
>              if args.archived:
>                  print()
> @@ -111,3 +115,5 @@ class ManifestCommand(EdkrepoCommand):
>                          print("  {}".format(project))
>                      if args.verbose:
>                          print("   -> {}".format(ci_index_xml.get_project_xml(project)))
> +                        proj_manifest =
> ManifestXml(find_project_in_single_index(project, ci_index_xml,
> man_repos[repo][0])[1])
> +                        print("   -> DevLead: {}".format(' '.join(x for x in
> proj_manifest.project_info.dev_leads)))
> --
> 2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70462): https://edk2.groups.io/g/devel/message/70462
Mute This Topic: https://groups.io/mt/79532061/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-