[edk2-devel] [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules

Nhi Pham via groups.io posted 4 patches 2 weeks, 5 days ago
Failed in applying to current master (apply log)
.../RealTimeClockRuntimeDxe.inf               |   2 +
EmbeddedPkg/Include/Library/TimeBaseLib.h     |  90 +++++++++++-
EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 134 +++++++++++++++---
.../RealTimeClockRuntimeDxe/RealTimeClock.c   |  88 +-----------
4 files changed, 201 insertions(+), 113 deletions(-)

[edk2-devel] [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules

Posted by Nhi Pham via groups.io 2 weeks, 5 days ago
This patch series replaces all time checking functions and leverage
the helper function in TimeBaseLib library.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Nhi Pham (4):
  EmbeddedPkg/TimeBaseLib: Update comment blocks for API functions
  EmbeddedPkg/TimeBaseLib: Fix for minor code formatting
  EmbeddedPkg/TimeBaseLib: Add function to check Timezone and Daylight
  EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from
    TimeBaseLib

 .../RealTimeClockRuntimeDxe.inf               |   2 +
 EmbeddedPkg/Include/Library/TimeBaseLib.h     |  90 +++++++++++-
 EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 134 +++++++++++++++---
 .../RealTimeClockRuntimeDxe/RealTimeClock.c   |  88 +-----------
 4 files changed, 201 insertions(+), 113 deletions(-)

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69841): https://edk2.groups.io/g/devel/message/69841
Mute This Topic: https://groups.io/mt/79477827/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules

Posted by Leif Lindholm 2 weeks, 4 days ago
On Wed, Jan 06, 2021 at 23:08:59 +0700, Nhi Pham wrote:
> This patch series replaces all time checking functions and leverage
> the helper function in TimeBaseLib library.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Pushed as 8015f3f6d400..55ee36b0c490.

Many thanks for this cleanup, especially for adding the doxygen
comments to the pre-existing functions.

> Nhi Pham (4):
>   EmbeddedPkg/TimeBaseLib: Update comment blocks for API functions
>   EmbeddedPkg/TimeBaseLib: Fix for minor code formatting
>   EmbeddedPkg/TimeBaseLib: Add function to check Timezone and Daylight
>   EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from
>     TimeBaseLib
> 
>  .../RealTimeClockRuntimeDxe.inf               |   2 +
>  EmbeddedPkg/Include/Library/TimeBaseLib.h     |  90 +++++++++++-
>  EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 134 +++++++++++++++---
>  .../RealTimeClockRuntimeDxe/RealTimeClock.c   |  88 +-----------
>  4 files changed, 201 insertions(+), 113 deletions(-)
> 
> -- 
> 2.17.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69943): https://edk2.groups.io/g/devel/message/69943
Mute This Topic: https://groups.io/mt/79477827/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-