Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds

[edk2-devel] [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds

Posted by Marcin Wojtas 3 years, 11 months ago

As the SignedCapsulePkg requires ArmSoftFloatLib resolution
for ARM builds, add missing dependency for all Marvell
platforms.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reported-by: Laszlo Ersek <lersek@redhat.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 017c6287f7..e8e7300441 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -211,6 +211,9 @@
   # Add support for GCC stack protector
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
 
+[LibraryClasses.ARM]
+  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+
 ################################################################################
 #
 # Pcd Section - list of all EDK II PCD Entries defined by this Platform
-- 
2.29.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69506): https://edk2.groups.io/g/devel/message/69506
Mute This Topic: https://groups.io/mt/79296629/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds

Posted by Rebecca Cran 3 years, 11 months ago

On 12/29/20 11:31 AM, Marcin Wojtas wrote:
> As the SignedCapsulePkg requires ArmSoftFloatLib resolution
> for ARM builds, add missing dependency for all Marvell
> platforms.
> 
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 017c6287f7..e8e7300441 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -211,6 +211,9 @@
>     # Add support for GCC stack protector
>     NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>   
> +[LibraryClasses.ARM]
> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>

Thanks - that was good timing!

-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69507): https://edk2.groups.io/g/devel/message/69507
Mute This Topic: https://groups.io/mt/79296629/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds

Posted by Ard Biesheuvel 3 years, 10 months ago

On 12/29/20 7:40 PM, Rebecca Cran wrote:
> On 12/29/20 11:31 AM, Marcin Wojtas wrote:
>> As the SignedCapsulePkg requires ArmSoftFloatLib resolution
>> for ARM builds, add missing dependency for all Marvell
>> platforms.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Reported-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> index 017c6287f7..e8e7300441 100644
>> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> @@ -211,6 +211,9 @@
>>     # Add support for GCC stack protector
>>     NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>>   +[LibraryClasses.ARM]
>> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>> +
> 
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> 
> Thanks - that was good timing!
> 

Pushed as eec4526f3bc2..a34e27a1fa79

Thanks!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69599): https://edk2.groups.io/g/devel/message/69599
Mute This Topic: https://groups.io/mt/79296629/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-