[v2] Fix Ecc reported errors from ArmPlatformPkg

[edk2-devel] [PATCH v2 edk2-platforms 0/2] Fix Ecc reported errors from ArmPlatformPkg

PierreGondois posted 2 patches 3 years, 4 months ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

.../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    |   4 +-
.../Library/HdLcdArmSgiLib/HdLcdArmSgi.c      |   4 +-
Platform/ARM/VExpressPkg/ArmVExpressPkg.dec   |   3 +-
.../Include/Library/LcdPlatformLib.h          | 215 ------------------
.../Library/ArmMaliDpLib/ArmMaliDpLib.c       |   4 +-
.../HdLcdArmVExpressLib/HdLcdArmVExpress.c    |   4 +-
.../PL111LcdArmVExpress.c                     |  34 +--
7 files changed, 26 insertions(+), 242 deletions(-)
delete mode 100644 Platform/ARM/VExpressPkg/Include/Library/LcdPlatformLib.h

Expand all Fold all

[edk2-devel] [PATCH v2 edk2-platforms 0/2] Fix Ecc reported errors from ArmPlatformPkg

Posted by PierreGondois 3 years, 4 months ago

From: Pierre Gondois <Pierre.Gondois@arm.com>

The Ecc tools available in the BaseTools package checks for
good practice coding standards. Some errors reported while
running Ecc on edk2/ArmPlatformPkg require modifications
in the edk2-platforms.

This patch set has a dependency over a similar patch set
named "Fix Ecc reported errors in ArmPlatformPkg" for edk2
and should not be merged independently.

The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/pg/1537_Ecc_ArmPlatformPkg_v2

Pierre Gondois (2):
  Platform/ARM/VExpressPkg: Remove LcdPlatformLib.h
  Platform/ARM: Fix Ecc error 8005

 .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    |   4 +-
 .../Library/HdLcdArmSgiLib/HdLcdArmSgi.c      |   4 +-
 Platform/ARM/VExpressPkg/ArmVExpressPkg.dec   |   3 +-
 .../Include/Library/LcdPlatformLib.h          | 215 ------------------
 .../Library/ArmMaliDpLib/ArmMaliDpLib.c       |   4 +-
 .../HdLcdArmVExpressLib/HdLcdArmVExpress.c    |   4 +-
 .../PL111LcdArmVExpress.c                     |  34 +--
 7 files changed, 26 insertions(+), 242 deletions(-)
 delete mode 100644 Platform/ARM/VExpressPkg/Include/Library/LcdPlatformLib.h

--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68710): https://edk2.groups.io/g/devel/message/68710
Mute This Topic: https://groups.io/mt/78876414/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 edk2-platforms 0/2] Fix Ecc reported errors from ArmPlatformPkg

Posted by Ard Biesheuvel 3 years, 4 months ago

On 12/11/20 11:38 AM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> The Ecc tools available in the BaseTools package checks for
> good practice coding standards. Some errors reported while
> running Ecc on edk2/ArmPlatformPkg require modifications
> in the edk2-platforms.
> 
> This patch set has a dependency over a similar patch set
> named "Fix Ecc reported errors in ArmPlatformPkg" for edk2
> and should not be merged independently.
> 
> The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/pg/1537_Ecc_ArmPlatformPkg_v2
> 
> Pierre Gondois (2):
>   Platform/ARM/VExpressPkg: Remove LcdPlatformLib.h
>   Platform/ARM: Fix Ecc error 8005
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 3ada6025ce23..162f4a41a860

Thanks,
Ard.


>  .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    |   4 +-
>  .../Library/HdLcdArmSgiLib/HdLcdArmSgi.c      |   4 +-
>  Platform/ARM/VExpressPkg/ArmVExpressPkg.dec   |   3 +-
>  .../Include/Library/LcdPlatformLib.h          | 215 ------------------
>  .../Library/ArmMaliDpLib/ArmMaliDpLib.c       |   4 +-
>  .../HdLcdArmVExpressLib/HdLcdArmVExpress.c    |   4 +-
>  .../PL111LcdArmVExpress.c                     |  34 +--
>  7 files changed, 26 insertions(+), 242 deletions(-)
>  delete mode 100644 Platform/ARM/VExpressPkg/Include/Library/LcdPlatformLib.h
> 
> --
> 2.17.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69616): https://edk2.groups.io/g/devel/message/69616
Mute This Topic: https://groups.io/mt/78876414/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-