1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib

Wadhawan, Divneil R posted 1 patch 3 years, 4 months ago
Failed in applying to current master (apply log)
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
Posted by Wadhawan, Divneil R 3 years, 4 months ago 
o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
  required in building of MdeModulePkg

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>

Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
---
 UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
index 96e40e973c..0dabd6a6f3 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
@@ -12,7 +12,7 @@
   FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
   VERSION_STRING  = 1.0
   MODULE_TYPE     = UEFI_DRIVER
-  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
+  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_DRIVER UEFI_APPLICATION
 
 [Sources]
   UnitTestLib.c
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68353): https://edk2.groups.io/g/devel/message/68353
Mute This Topic: https://groups.io/mt/78715275/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
Posted by Michael D Kinney 3 years, 4 months ago 
Divneil,

Thank you for reposting with a correct commit message and email format.

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike


> -----Original Message-----
> From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> Sent: Friday, December 4, 2020 10:12 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
> 
> o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
>   required in building of MdeModulePkg
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> ---
>  UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> index 96e40e973c..0dabd6a6f3 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> @@ -12,7 +12,7 @@
>    FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
>    VERSION_STRING  = 1.0
>    MODULE_TYPE     = UEFI_DRIVER
> -  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> +  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> SMM_CORE UEFI_DRIVER UEFI_APPLICATION
> 
>  [Sources]
>    UnitTestLib.c
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68356): https://edk2.groups.io/g/devel/message/68356
Mute This Topic: https://groups.io/mt/78715275/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
Posted by Michael D Kinney 3 years, 4 months ago 
Merged

https://github.com/tianocore/edk2/pull/1182


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 4, 2020 5:44 PM
> To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
> 
> Divneil,
> 
> Thank you for reposting with a correct commit message and email format.
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > Sent: Friday, December 4, 2020 10:12 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>
> > Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
> >
> > o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
> >   required in building of MdeModulePkg
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > ---
> >  UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > index 96e40e973c..0dabd6a6f3 100644
> > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > @@ -12,7 +12,7 @@
> >    FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
> >    VERSION_STRING  = 1.0
> >    MODULE_TYPE     = UEFI_DRIVER
> > -  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> > +  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> > SMM_CORE UEFI_DRIVER UEFI_APPLICATION
> >
> >  [Sources]
> >    UnitTestLib.c
> > --
> > 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68357): https://edk2.groups.io/g/devel/message/68357
Mute This Topic: https://groups.io/mt/78715275/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
Posted by Wadhawan, Divneil R 3 years, 4 months ago 
Thanks Mike for helping out with the process.

Regards,
Divneil

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Saturday, December 5, 2020 7:34 AM
To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib

Merged

https://github.com/tianocore/edk2/pull/1182


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, December 4, 2020 5:44 PM
> To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>; 
> devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> <Bret.Barkelew@microsoft.com>
> Subject: RE: [Patch V2] UnitTestFrameworkPg: Fix build failure of 
> MdeModulePkg with UnitTestLib
> 
> Divneil,
> 
> Thank you for reposting with a correct commit message and email format.
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > Sent: Friday, December 4, 2020 10:12 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan 
> > <sean.brogan@microsoft.com>; Bret Barkelew 
> > <Bret.Barkelew@microsoft.com>
> > Subject: [Patch V2] UnitTestFrameworkPg: Fix build failure of 
> > MdeModulePkg with UnitTestLib
> >
> > o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
> >   required in building of MdeModulePkg
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> > ---
> >  UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git 
> > a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > index 96e40e973c..0dabd6a6f3 100644
> > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
> > @@ -12,7 +12,7 @@
> >    FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
> >    VERSION_STRING  = 1.0
> >    MODULE_TYPE     = UEFI_DRIVER
> > -  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
> > +  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> > SMM_CORE UEFI_DRIVER UEFI_APPLICATION
> >
> >  [Sources]
> >    UnitTestLib.c
> > --
> > 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68362): https://edk2.groups.io/g/devel/message/68362
Mute This Topic: https://groups.io/mt/78715275/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.