MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++---------- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +-- 2 files changed, 15 insertions(+), 15 deletions(-)
Fix typos in MdePkg/Include/IndustryStandard/SmBios.h and make
corresponding changes to the ShellPkg smbiosview command.
Testing:
Built OvmfPkgX64, OvmfPkgIa32, OvmfPkgIa32X64 for DEBUG, RELEASE, NOOPT
Built edk2-platforms RPi4, SbsaQemu for DEBUG, RELEASE, NOOPT
Built edk2-platforms Armada80x0McBin for RELEASE
Built edk2-platforms Intel UpXtreme, GalagoPro3, KabylakeRvp3
Ran stuart_ci_build with X64,AARCH64,RISCV64,IA32 for NO-TARGET,NOOPT,RELEASE,DEBUG
Ran OVMF X64 and verified smbiosview runs correctly.
Ran Gitlab CI: https://github.com/tianocore/edk2/pull/1178
Changes from v1:
Added updates to fix the smbiosview shell command.
Rebecca Cran (3):
MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct
MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
ProcessorManufacturer
MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion
MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +--
2 files changed, 15 insertions(+), 15 deletions(-)
--
2.26.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68321): https://edk2.groups.io/g/devel/message/68321
Mute This Topic: https://groups.io/mt/78703523/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Rebecca: Thanks for your updating to make edk2 pass build with this change. Can you also provide the patch to edk2-platforms if the change is small? Thanks Liming > -----邮件原件----- > 发件人: Rebecca Cran <rebecca@nuviainc.com> > 发送时间: 2020年12月4日 13:11 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com> > 主题: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in > IndustryStandard/SmBios.h > > Fix typos in MdePkg/Include/IndustryStandard/SmBios.h and make > corresponding changes to the ShellPkg smbiosview command. > > Testing: > > Built OvmfPkgX64, OvmfPkgIa32, OvmfPkgIa32X64 for DEBUG, RELEASE, > NOOPT > Built edk2-platforms RPi4, SbsaQemu for DEBUG, RELEASE, NOOPT > Built edk2-platforms Armada80x0McBin for RELEASE > Built edk2-platforms Intel UpXtreme, GalagoPro3, KabylakeRvp3 > > Ran stuart_ci_build with X64,AARCH64,RISCV64,IA32 for > NO-TARGET,NOOPT,RELEASE,DEBUG > > Ran OVMF X64 and verified smbiosview runs correctly. > > Ran Gitlab CI: https://github.com/tianocore/edk2/pull/1178 > > Changes from v1: > > Added updates to fix the smbiosview shell command. > > Rebecca Cran (3): > MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS > struct > MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field > ProcessorManufacturer > MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion > > MdePkg/Include/IndustryStandard/SmBios.h > | 26 ++++++++++---------- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | > 4 +-- > 2 files changed, 15 insertions(+), 15 deletions(-) > > -- > 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68439): https://edk2.groups.io/g/devel/message/68439 Mute This Topic: https://groups.io/mt/78797809/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> On Dec 7, 2020, at 10:38 PM, gaoliming <gaoliming@byosoft.com.cn> wrote: > > Rebecca: > Thanks for your updating to make edk2 pass build with this change. > > Can you also provide the patch to edk2-platforms if the change is small? No changes to edk2-platforms are needed. — Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68440): https://edk2.groups.io/g/devel/message/68440 Mute This Topic: https://groups.io/mt/78797809/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
That's great. So, this patch set has no impact to edk2-platforms. For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Thanks Liming > -----邮件原件----- > 发件人: bounce+27952+68440+4905953+8761045@groups.io > <bounce+27952+68440+4905953+8761045@groups.io> 代表 Rebecca Cran > 发送时间: 2020年12月8日 13:53 > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney > <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Ray > Ni <ray.ni@intel.com> > 主题: Re: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in > IndustryStandard/SmBios.h > > > > > On Dec 7, 2020, at 10:38 PM, gaoliming <gaoliming@byosoft.com.cn> > wrote: > > > > Rebecca: > > Thanks for your updating to make edk2 pass build with this change. > > > > Can you also provide the patch to edk2-platforms if the change is small? > > No changes to edk2-platforms are needed. > > — > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68442): https://edk2.groups.io/g/devel/message/68442 Mute This Topic: https://groups.io/mt/78798115/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.