[edk2-devel] [PATCH 2/2] OvmfPkg: add "gGrubFileGuid=Grub" to GuidCheck.IgnoreDuplicates

Laszlo Ersek posted 2 patches 5 years, 2 months ago
[edk2-devel] [PATCH 2/2] OvmfPkg: add "gGrubFileGuid=Grub" to GuidCheck.IgnoreDuplicates
Posted by Laszlo Ersek 5 years, 2 months ago
The patch series linked at

  https://bugzilla.tianocore.org/show_bug.cgi?id=3077#c4

is rejected by GuidCheck with the following error message:

> GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07
> NAME: gGrubFileGuid FILE: /home/vsts/work/1/s/OvmfPkg/OvmfPkg.dec
> GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07
> NAME: Grub FILE: /home/vsts/work/1/s/OvmfPkg/AmdSev/Grub/Grub.inf

This GUID identity is by design in the TianoCore#3077 feature; add a CI
exception for it.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/OvmfPkg.ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
index 68d2de704d19..8e2da2803b30 100644
--- a/OvmfPkg/OvmfPkg.ci.yaml
+++ b/OvmfPkg/OvmfPkg.ci.yaml
@@ -127,7 +127,7 @@
         "IgnoreGuidName": ["ResetVector", "XenResetVector"], # Expected duplication for gEfiFirmwareVolumeTopFileGuid
         "IgnoreGuidValue": [],
         "IgnoreFoldersAndFiles": [],
-        "IgnoreDuplicates": [],
+        "IgnoreDuplicates": ["gGrubFileGuid=Grub"],
     },
 
     ## options defined .pytool/Plugin/LibraryClassCheck
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68315): https://edk2.groups.io/g/devel/message/68315
Mute This Topic: https://groups.io/mt/78702237/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 2/2] OvmfPkg: add "gGrubFileGuid=Grub" to GuidCheck.IgnoreDuplicates
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago
On 12/4/20 4:21 AM, Laszlo Ersek wrote:
> The patch series linked at
> 
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3077#c4
> 
> is rejected by GuidCheck with the following error message:
> 
>> GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07
>> NAME: gGrubFileGuid FILE: /home/vsts/work/1/s/OvmfPkg/OvmfPkg.dec
>> GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07
>> NAME: Grub FILE: /home/vsts/work/1/s/OvmfPkg/AmdSev/Grub/Grub.inf
> 
> This GUID identity is by design in the TianoCore#3077 feature; add a CI
> exception for it.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/OvmfPkg.ci.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68340): https://edk2.groups.io/g/devel/message/68340
Mute This Topic: https://groups.io/mt/78702237/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-