Maintainers.txt | 6 + Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ Readme.md | 3 + 3 files changed, 176 insertions(+) create mode 100644 Platform/Ampere/Readme.md
This short patch series introduces the support for Ampere Computing's Arm64 hardware platforms, specifically the Mt. Jade platform based on Ampere's Altra Family processor at this moment. A public fork of EDK2 for supporting Mt. Jade is currently available at https://github.com/AmpereComputing/edk2-platforms Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Nhi Pham (1): Maintainers.txt: Update for Ampere platforms Phong Vo (2): Platform/Ampere: Add Readme.md Update Readme.md Maintainers.txt | 6 + Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ Readme.md | 3 + 3 files changed, 176 insertions(+) create mode 100644 Platform/Ampere/Readme.md -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68210): https://edk2.groups.io/g/devel/message/68210 Mute This Topic: https://groups.io/mt/78678098/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, Dec 03, 2020 at 11:03:59 +0700, Nhi Pham wrote: > This short patch series introduces the support for Ampere Computing's > Arm64 hardware platforms, Well, it doesn't really, does it? It adds a Maintainers.txt entry, a Readme.md describing a fork somewhere, and links that Readme into the top-level one. I think it's great you've posted it here for people to see, but can you clarify your intent somewhat? Is this a precursor to a full upstreaming effort? I don't see a point in merging just this, although I can (and will) provide some feedback on the documentation. Best Regards, Leif > specifically the Mt. Jade platform based on > Ampere's Altra Family processor at this moment. > > A public fork of EDK2 for supporting Mt. Jade is currently available at > https://github.com/AmpereComputing/edk2-platforms > > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Nhi Pham (1): > Maintainers.txt: Update for Ampere platforms > > Phong Vo (2): > Platform/Ampere: Add Readme.md > Update Readme.md > > Maintainers.txt | 6 + > Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ > Readme.md | 3 + > 3 files changed, 176 insertions(+) > create mode 100644 Platform/Ampere/Readme.md > > -- > 2.17.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68240): https://edk2.groups.io/g/devel/message/68240 Mute This Topic: https://groups.io/mt/78678098/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Leif, Please find my response inline. On Thu, Dec 3, 2020 at 06:46 PM, Leif Lindholm wrote: > > On Thu, Dec 03, 2020 at 11:03:59 +0700, Nhi Pham wrote: > >> This short patch series introduces the support for Ampere Computing's >> Arm64 hardware platforms, > > Well, it doesn't really, does it? > It adds a Maintainers.txt entry, a Readme.md describing a fork > somewhere, and links that Readme into the top-level one. > > I think it's great you've posted it here for people to see, but can > you clarify your intent somewhat? > Is this a precursor to a full upstreaming effort? Yes, this patch series works as bootstrap that we will push all Mt. Jade code in one shot (about 35 commits) to the edk2-platforms for review after this is approved and merged. This series provides Maintainers and Reviewers in the Maintainer.txt who are responsible for giving code review feedback (Reviewed-by tag) if stewards can not review a large patch series. Thanks, Nhi > > > I don't see a point in merging just this, although I can (and will) > provide some feedback on the documentation. > > Best Regards, > > Leif > > >> specifically the Mt. Jade platform based on >> Ampere's Altra Family processor at this moment. >> >> A public fork of EDK2 for supporting Mt. Jade is currently available at >> https://github.com/AmpereComputing/edk2-platforms >> >> Cc: Leif Lindholm <leif@nuviainc.com> >> Cc: Michael D Kinney <michael.d.kinney@intel.com> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> >> >> Nhi Pham (1): >> Maintainers.txt: Update for Ampere platforms >> >> Phong Vo (2): >> Platform/Ampere: Add Readme.md >> Update Readme.md >> >> Maintainers.txt | 6 + >> Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ >> Readme.md | 3 + >> 3 files changed, 176 insertions(+) >> create mode 100644 Platform/Ampere/Readme.md >> >> -- >> 2.17.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68242): https://edk2.groups.io/g/devel/message/68242 Mute This Topic: https://groups.io/mt/78678098/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Nhi, On Thu, Dec 03, 2020 at 04:15:27 -0800, Nhi Pham via groups.io wrote: > Hi Leif, > > Please find my response inline. > > On Thu, Dec 3, 2020 at 06:46 PM, Leif Lindholm wrote: > > > > > On Thu, Dec 03, 2020 at 11:03:59 +0700, Nhi Pham wrote: > > > >> This short patch series introduces the support for Ampere Computing's > >> Arm64 hardware platforms, > > > > Well, it doesn't really, does it? > > It adds a Maintainers.txt entry, a Readme.md describing a fork > > somewhere, and links that Readme into the top-level one. > > > > I think it's great you've posted it here for people to see, but can > > you clarify your intent somewhat? > > Is this a precursor to a full upstreaming effort? > > Yes, this patch series works as bootstrap that we will push all > Mt. Jade code in one shot (about 35 commits) to the edk2-platforms > for review after this is approved and merged. This series provides > Maintainers and Reviewers in the Maintainer.txt who are responsible > for giving code review feedback (Reviewed-by tag) if stewards can > not review a large patch series. Glad to hear it! However, can we keep the Platform/Ampere/Readme.md aligned with what is currentlt merged in edk2-platforms? I have given some feedback on that file directly, but I think given the above statement it would be more appropriate to start with a very small document describing that upstreaming is in progress, and a link to https://github.com/AmpereComputing/edk2-platforms/blob/ampere/Platform/Ampere/Readme.md . Best Regards, Leif > > Thanks, > Nhi > > > > > > > I don't see a point in merging just this, although I can (and will) > > provide some feedback on the documentation. > > > > Best Regards, > > > > Leif > > > > > >> specifically the Mt. Jade platform based on > >> Ampere's Altra Family processor at this moment. > >> > >> A public fork of EDK2 for supporting Mt. Jade is currently available at > >> https://github.com/AmpereComputing/edk2-platforms > >> > >> Cc: Leif Lindholm <leif@nuviainc.com> > >> Cc: Michael D Kinney <michael.d.kinney@intel.com> > >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > >> > >> Nhi Pham (1): > >> Maintainers.txt: Update for Ampere platforms > >> > >> Phong Vo (2): > >> Platform/Ampere: Add Readme.md > >> Update Readme.md > >> > >> Maintainers.txt | 6 + > >> Platform/Ampere/Readme.md | 167 ++++++++++++++++++++ > >> Readme.md | 3 + > >> 3 files changed, 176 insertions(+) > >> create mode 100644 Platform/Ampere/Readme.md > >> > >> -- > >> 2.17.1 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68246): https://edk2.groups.io/g/devel/message/68246 Mute This Topic: https://groups.io/mt/78678098/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.