1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h

Rebecca Cran posted 3 patches 3 years, 4 months ago
Failed in applying to current master (apply log)
MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
[edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by Rebecca Cran 3 years, 4 months ago 
Since the edk2-stable202011 tag has been created, I'm resubmitting the
SmBios.h typo fixes.

Rebecca Cran (3):
  MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct
  MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
    ProcessorManufacturer
  MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field FirmwareVersion

 MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)

-- 
2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68193): https://edk2.groups.io/g/devel/message/68193
Mute This Topic: https://groups.io/mt/78667574/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by gaoliming 3 years, 4 months ago 
Rebecca:
  I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
There are many platform SmbiosDxe driver to depend on them. 
  So, this change impacts widely. This change is just to rename field name.
There is no real functionality change. I suggest to add comments for those
typo fields instead of changing them. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68193+4905953+8761045@groups.io
> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
> 发送时间: 2020年12月3日 3:03
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> 
> Since the edk2-stable202011 tag has been created, I'm resubmitting the
> SmBios.h typo fixes.
> 
> Rebecca Cran (3):
>   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
>   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>     ProcessorManufacturer
>   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> FirmwareVersion
> 
>  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> --
> 2.26.2
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68204): https://edk2.groups.io/g/devel/message/68204
Mute This Topic: https://groups.io/mt/78675566/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by Leif Lindholm 3 years, 4 months ago 
Liming,

These aren't randomly named fields, they are incorrect representations
of an industry standard.

We are now in the period just after stable tag, breaking platforms is
perfectly acceptable.

Also, we just happily broke all known platforms during soft freeze by
merging the VariablePolicy set.

/
    Leif

On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> Rebecca:
>   I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
> There are many platform SmbiosDxe driver to depend on them. 
>   So, this change impacts widely. This change is just to rename field name.
> There is no real functionality change. I suggest to add comments for those
> typo fields instead of changing them. 
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+68193+4905953+8761045@groups.io
> > <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
> > 发送时间: 2020年12月3日 3:03
> > 收件人: devel@edk2.groups.io
> > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > 
> > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > SmBios.h typo fixes.
> > 
> > Rebecca Cran (3):
> >   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > struct
> >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> >     ProcessorManufacturer
> >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > FirmwareVersion
> > 
> >  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> >  1 file changed, 13 insertions(+), 13 deletions(-)
> > 
> > --
> > 2.26.2
> > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68238): https://edk2.groups.io/g/devel/message/68238
Mute This Topic: https://groups.io/mt/78675566/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by gaoliming 3 years, 4 months ago 
Leif:
  I don't mean to object the incompatible change. I understand that the field name is changed for the readable source code. So, I propose to add comments for it to achieve the same goal.

Thanks
Liming
> -----邮件原件-----
> 发件人: Leif Lindholm <leif@nuviainc.com>
> 发送时间: 2020年12月3日 19:24
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: rebecca@nuviainc.com; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>;
> 'Laszlo Ersek' <lersek@redhat.com>
> 主题: Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> 
> Liming,
> 
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
> 
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
> 
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
> 
> /
>     Leif
> 
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> > Rebecca:
> >   I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in
> edk2-platforms.
> > There are many platform SmbiosDxe driver to depend on them.
> >   So, this change impacts widely. This change is just to rename field name.
> > There is no real functionality change. I suggest to add comments for those
> > typo fields instead of changing them.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+68193+4905953+8761045@groups.io
> > > <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca
> Cran
> > > 发送时间: 2020年12月3日 3:03
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu@intel.com>
> > > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > >
> > > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > > SmBios.h typo fixes.
> > >
> > > Rebecca Cran (3):
> > >   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > > struct
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> > >     ProcessorManufacturer
> > >   MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > > FirmwareVersion
> > >
> > >  MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> > >  1 file changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.26.2
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> > 
> >
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68306): https://edk2.groups.io/g/devel/message/68306
Mute This Topic: https://groups.io/mt/78700310/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by Sean 3 years, 4 months ago 
As a downstream consumer and maintainer I strongly support correcting 
these fields.

If a platform dev model can't handle this type of breaking change then 
this project is paralyzed and bigger things should be addressed.

Thanks
Sean

On 12/3/2020 3:24 AM, Leif Lindholm wrote:
> Liming,
> 
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
> 
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
> 
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
> 
> /
>      Leif
> 
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
>> Rebecca:
>>    I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
>> There are many platform SmbiosDxe driver to depend on them.
>>    So, this change impacts widely. This change is just to rename field name.
>> There is no real functionality change. I suggest to add comments for those
>> typo fields instead of changing them.
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: bounce+27952+68193+4905953+8761045@groups.io
>>> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
>>> 发送时间: 2020年12月3日 3:03
>>> 收件人: devel@edk2.groups.io
>>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>>> Zhiguang Liu <zhiguang.liu@intel.com>
>>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>>
>>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>>> SmBios.h typo fixes.
>>>
>>> Rebecca Cran (3):
>>>    MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>>> struct
>>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>>      ProcessorManufacturer
>>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>>> FirmwareVersion
>>>
>>>   MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>>
>>> --
>>> 2.26.2
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68313): https://edk2.groups.io/g/devel/message/68313
Mute This Topic: https://groups.io/mt/78675566/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Posted by Rebecca Cran 3 years, 4 months ago 
Liming,


Yes lots of platforms use the structures, but most (all?) don't 
reference the fields themselves.

For example, searching for "FirwareVersion" in edk2-platforms gives just 
one results:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:576: 
0,                    // FirwareVersion


Same for 'Processor64BitCapble:


../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:276: 
// Processor64BitCapble            :1;


I did find a problem with this patch: SmbiosView in edk2 needs updated 
at the same time - so I'll send out a v2 shortly.


-- 

Rebecca Cran


On 12/2/20 6:18 PM, gaoliming wrote:
> Rebecca:
>    I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms.
> There are many platform SmbiosDxe driver to depend on them.
>    So, this change impacts widely. This change is just to rename field name.
> There is no real functionality change. I suggest to add comments for those
> typo fields instead of changing them.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+68193+4905953+8761045@groups.io
>> <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca Cran
>> 发送时间: 2020年12月3日 3:03
>> 收件人: devel@edk2.groups.io
>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Zhiguang Liu <zhiguang.liu@intel.com>
>> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>>
>> Since the edk2-stable202011 tag has been created, I'm resubmitting the
>> SmBios.h typo fixes.
>>
>> Rebecca Cran (3):
>>    MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
>> struct
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
>>      ProcessorManufacturer
>>    MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
>> FirmwareVersion
>>
>>   MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
>>
>>
>>
>>
>>
>
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68205): https://edk2.groups.io/g/devel/message/68205
Mute This Topic: https://groups.io/mt/78675566/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.