Hi Leif,
Thanks for your comment, let me update the patches.
Regards,
Vu
On 12/2/2020 19:44, Leif Lindholm wrote:
> Hi Vu,
>
> Thanks for this.
>
> However, as previously communicated to your colleague:
> ---
> As for the mechanism, please generate a separate patch set, adding
> --no-binary to the git format-patch command line.
> Then make the commits available in a public repository referred to in
> the cover letter.
> ----
>
> As a feedback detail - please drop any leading _ characters from
> include file header guards (or other macros), these are reserved for
> toolchain use.
>
> Also, since this is the first on-list communication about this
> platform, it would be helpful if the cover letter stated what these
> files are and why they are being upstreamed.
>
> Best Regards,
>
> Leif
>
> On Tue, Dec 01, 2020 at 15:54:07 +0700, Vu Nguyen wrote:
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>
>> Vu Nguyen (2):
>> AmpereAltraBinPkg: Add PciePhyLib library and header
>> edk2-non-osi: Add AmpereAltraBinPkg maintainers
>>
>> Maintainers.txt | 4 +
>> Silicon/Ampere/License.txt | 25 +++
>> .../Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec | 16 ++
>> .../Library/PciePhyLib/PciePhyLib.inf | 23 +++
>> .../Include/Library/PciePhyLib.h | 165 ++++++++++++++++++
>> .../Library/PciePhyLib/PciePhyLib.lib | Bin 0 -> 26026 bytes
>> 6 files changed, 233 insertions(+)
>> create mode 100644 Silicon/Ampere/License.txt
>> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec
>> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
>> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.lib
>>
>> --
>> 2.17.1
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68186): https://edk2.groups.io/g/devel/message/68186
Mute This Topic: https://groups.io/mt/78636961/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-