1. Patchew
  2. EDK2
  3. [edk2-devel] [EFI Shell PATCH v2 0/2] Support EFI Redfish protocols
  4. View patch

[edk2-devel] [EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

Abner Chang posted 2 patches 5 years, 3 months ago
There is a newer version of this series
[edk2-devel] [EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
Posted by Abner Chang 5 years, 3 months ago 
Add handle parsing for EFI Redfish Discover protocol.
Add handle parsing for EFI RestEx protocol.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Peter O'Hanley <peter.ohanley@hpe.com>
---
 .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c   | 8 ++++++--
 .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
 .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 500a95a89a..c00337d6b2 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -3,7 +3,7 @@
 
   Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
-  (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
+  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[] = {
   {STRING_TOKEN(STR_NET_HTTP),              &gEfiHttpProtocolGuid,                            NULL},
   {STRING_TOKEN(STR_NET_HTTP_U),            &gEfiHttpUtilitiesProtocolGuid,                   NULL},
   {STRING_TOKEN(STR_REST),                  &gEfiRestProtocolGuid,                            NULL},
-
+//
+// UEFI 2.8
+//
+  {STRING_TOKEN(STR_REST_EX),               &gEfiRestExProtocolGuid,                          NULL},
+  {STRING_TOKEN(STR_REDFISH_DISCOVER),      &gEfiRedfishDiscoverProtocolGuid,                 NULL},
 //
 // PI 1.5
 //
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index 93b69cd8e9..446cd8d609 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -2,7 +2,7 @@
 #  Provides interface to advanced shell functionality for parsing both handle and protocol database.
 #  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>
 #  (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
-#  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
+#  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -269,6 +269,8 @@
   gEfiHttpProtocolGuid                                    ## UNDEFINED
   gEfiHttpUtilitiesProtocolGuid                           ## UNDEFINED
   gEfiRestProtocolGuid                                    ## UNDEFINED
+  gEfiRestExProtocolGuid                                  ## UNDEFINED
+  gEfiRedfishDiscoverProtocolGuid                         ## UNDEFINED
   gEfiMmEndOfDxeProtocolGuid                              ## UNDEFINED
   gEfiMmIoTrapDispatchProtocolGuid                        ## UNDEFINED
   gEfiMmPowerButtonDispatchProtocolGuid                   ## UNDEFINED
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
index 9c8028d0d5..69fcbdfe0e 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
@@ -2,7 +2,7 @@
 //
 // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
 // (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
-// (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
+// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR>
 // SPDX-License-Identifier: BSD-2-Clause-Patent
 //
 // Module Name:
@@ -308,6 +308,8 @@
 #string STR_NET_HTTP              #language en-US "Http"
 #string STR_NET_HTTP_U            #language en-US "HttpUtilities"
 #string STR_REST                  #language en-US "Rest"
+#string STR_REST_EX               #language en-US "RestEx"
+#string STR_REDFISH_DISCOVER      #language en-US "RedfishDiscover"
 
 #string STR_MM_EOD                #language en-US "MmEndOfDxe"
 #string STR_MM_ITD                #language en-US "MmIoTrapDispatch"
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67084): https://edk2.groups.io/g/devel/message/67084
Mute This Topic: https://groups.io/mt/78070340/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
Posted by Gao, Zhichao 5 years, 1 month ago 
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Please make sure #1 pass the review and it should be merged along with #1.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
> Sent: Friday, November 6, 2020 3:48 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Nickle
> Wang <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> Subject: [edk2-devel] [EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib:
> Support EFI Redfish protocols
> 
> Add handle parsing for EFI Redfish Discover protocol.
> Add handle parsing for EFI RestEx protocol.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c   | 8 ++++++--
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
>   .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++-
>  3 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 500a95a89a..c00337d6b2 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -3,7 +3,7 @@
> 
>    Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
> -  (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[]
> = {
>    {STRING_TOKEN(STR_NET_HTTP),              &gEfiHttpProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_NET_HTTP_U),            &gEfiHttpUtilitiesProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_REST),                  &gEfiRestProtocolGuid,
> NULL},
> -
> +//
> +// UEFI 2.8
> +//
> +  {STRING_TOKEN(STR_REST_EX),               &gEfiRestExProtocolGuid,
> NULL},
> +  {STRING_TOKEN(STR_REDFISH_DISCOVER),
> &gEfiRedfishDiscoverProtocolGuid,                 NULL},
>  //
>  // PI 1.5
>  //
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index 93b69cd8e9..446cd8d609 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -2,7 +2,7 @@
>  #  Provides interface to advanced shell functionality for parsing both handle and
> protocol database.
>  #  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>  #  (C)
> Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -#  (C)
> Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +#  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> +LP<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -269,6 +269,8 @@
>    gEfiHttpProtocolGuid                                    ## UNDEFINED
>    gEfiHttpUtilitiesProtocolGuid                           ## UNDEFINED
>    gEfiRestProtocolGuid                                    ## UNDEFINED
> +  gEfiRestExProtocolGuid                                  ## UNDEFINED
> +  gEfiRedfishDiscoverProtocolGuid                         ## UNDEFINED
>    gEfiMmEndOfDxeProtocolGuid                              ## UNDEFINED
>    gEfiMmIoTrapDispatchProtocolGuid                        ## UNDEFINED
>    gEfiMmPowerButtonDispatchProtocolGuid                   ## UNDEFINED
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> index 9c8028d0d5..69fcbdfe0e 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> @@ -2,7 +2,7 @@
>  //
>  // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>  // (C)
> Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -// (C)
> Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> +LP<BR>
>  // SPDX-License-Identifier: BSD-2-Clause-Patent  //  // Module Name:
> @@ -308,6 +308,8 @@
>  #string STR_NET_HTTP              #language en-US "Http"
>  #string STR_NET_HTTP_U            #language en-US "HttpUtilities"
>  #string STR_REST                  #language en-US "Rest"
> +#string STR_REST_EX               #language en-US "RestEx"
> +#string STR_REDFISH_DISCOVER      #language en-US "RedfishDiscover"
> 
>  #string STR_MM_EOD                #language en-US "MmEndOfDxe"
>  #string STR_MM_ITD                #language en-US "MmIoTrapDispatch"
> --
> 2.17.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69470): https://edk2.groups.io/g/devel/message/69470
Mute This Topic: https://groups.io/mt/78070340/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
Posted by Abner Chang 5 years, 1 month ago 
Sure. Thanks Zhichao. 
We will have to wait for UEFI 2.9 release then merge these two patches to master branch.

Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Monday, December 28, 2020 11:22 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: Re: [edk2-devel] [EFI Shell PATCH v2 2/2]
> ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Please make sure #1 pass the review and it should be merged along with #1.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> > Chang
> > Sent: Friday, November 6, 2020 3:48 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > Nickle Wang <nickle.wang@hpe.com>; Peter O'Hanley
> > <peter.ohanley@hpe.com>
> > Subject: [edk2-devel] [EFI Shell PATCH v2 2/2]
> ShellPkg/UefiHandleParsingLib:
> > Support EFI Redfish protocols
> >
> > Add handle parsing for EFI Redfish Discover protocol.
> > Add handle parsing for EFI RestEx protocol.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > ---
> >  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c   | 8 ++++++--
> >  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
> >   .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++-
> >  3 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > index 500a95a89a..c00337d6b2 100644
> > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > @@ -3,7 +3,7 @@
> >
> >    Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> >    (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> > L.P.<BR>
> > -  (C) Copyright 2015-2016 Hewlett Packard Enterprise Development
> > LP<BR>
> > +  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> > + LP<BR>
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[]
> > = {
> >    {STRING_TOKEN(STR_NET_HTTP),              &gEfiHttpProtocolGuid,
> > NULL},
> >    {STRING_TOKEN(STR_NET_HTTP_U),            &gEfiHttpUtilitiesProtocolGuid,
> > NULL},
> >    {STRING_TOKEN(STR_REST),                  &gEfiRestProtocolGuid,
> > NULL},
> > -
> > +//
> > +// UEFI 2.8
> > +//
> > +  {STRING_TOKEN(STR_REST_EX),               &gEfiRestExProtocolGuid,
> > NULL},
> > +  {STRING_TOKEN(STR_REDFISH_DISCOVER),
> > &gEfiRedfishDiscoverProtocolGuid,                 NULL},
> >  //
> >  // PI 1.5
> >  //
> > diff --git
> > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > index 93b69cd8e9..446cd8d609 100644
> > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > @@ -2,7 +2,7 @@
> >  #  Provides interface to advanced shell functionality for parsing
> > both handle and protocol database.
> >  #  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> > <BR>  #  (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> > L.P.<BR> -#  (C) Copyright 2015 Hewlett Packard Enterprise Development
> > LP<BR>
> > +#  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> > +LP<BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -269,6 +269,8 @@
> >    gEfiHttpProtocolGuid                                    ## UNDEFINED
> >    gEfiHttpUtilitiesProtocolGuid                           ## UNDEFINED
> >    gEfiRestProtocolGuid                                    ## UNDEFINED
> > +  gEfiRestExProtocolGuid                                  ## UNDEFINED
> > +  gEfiRedfishDiscoverProtocolGuid                         ## UNDEFINED
> >    gEfiMmEndOfDxeProtocolGuid                              ## UNDEFINED
> >    gEfiMmIoTrapDispatchProtocolGuid                        ## UNDEFINED
> >    gEfiMmPowerButtonDispatchProtocolGuid                   ## UNDEFINED
> > diff --git
> > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> > index 9c8028d0d5..69fcbdfe0e 100644
> > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> > @@ -2,7 +2,7 @@
> >  //
> >  // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> > <BR>  // (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> > L.P.<BR> -// (C) Copyright 2015-2016 Hewlett Packard Enterprise
> > Development LP<BR>
> > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> > +LP<BR>
> >  // SPDX-License-Identifier: BSD-2-Clause-Patent  //  // Module Name:
> > @@ -308,6 +308,8 @@
> >  #string STR_NET_HTTP              #language en-US "Http"
> >  #string STR_NET_HTTP_U            #language en-US "HttpUtilities"
> >  #string STR_REST                  #language en-US "Rest"
> > +#string STR_REST_EX               #language en-US "RestEx"
> > +#string STR_REDFISH_DISCOVER      #language en-US "RedfishDiscover"
> >
> >  #string STR_MM_EOD                #language en-US "MmEndOfDxe"
> >  #string STR_MM_ITD                #language en-US "MmIoTrapDispatch"
> > --
> > 2.17.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69471): https://edk2.groups.io/g/devel/message/69471
Mute This Topic: https://groups.io/mt/78070340/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.