[v1] Add AEST parser support to Acpiview

[edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Posted by Sami Mujawar 3 years, 5 months ago

Resending v2 patch series with Bugzilla IDs added. No code change
since v2 patch seiries.

Arm Error Source Table (AEST) enables kernel-first handling of
errors in a system that supports the Armv8 RAS extensions. AEST
is described in the ACPI for the Armv8 RAS Extensions 1.1,
Platform Design Document, dated 28 September 2020.
(https://developer.arm.com/documentation/den0085/0101/)

This v2 patch series:
 - adds AEST parser support to Acpiview.
 - addresses the review feedback for v1 series.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1429_aest_parser_v2

Marc Moisson-Franckhauser (2):
  MdePkg/IndustryStandard: AEST Table definition
  ShellPkg/Acpiview: AEST Parser

 MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h                        | 357 +++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  21 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c       | 755 ++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |   3 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |   3 +-
 7 files changed, 1142 insertions(+), 5 deletions(-)
 create mode 100644 MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66928): https://edk2.groups.io/g/devel/message/66928
Mute This Topic: https://groups.io/mt/78007253/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Posted by Sami Mujawar 3 years, 4 months ago

Hi Zhichao,

May I have your feedback for this series, please?

I have raised two Bugzilla tickets for these patches:
 - Bug 3049 - Add defintion for Arm Error Source Table (AEST) [https://bugzilla.tianocore.org/show_bug.cgi?id=3049]
 - Bug 3048 - Acpiview: Add support for parsing Arm Error Source Table (AEST) [https://bugzilla.tianocore.org/show_bug.cgi?id=3048]

The links for these patches on the mailing list are as below:
 - https://edk2.groups.io/g/devel/message/66928
- https://edk2.groups.io/g/devel/message/66929
- https://edk2.groups.io/g/devel/message/66930

Regards,

Sami Mujawar

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com> 
Sent: 03 November 2020 02:32 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Resending v2 patch series with Bugzilla IDs added. No code change
since v2 patch seiries.

Arm Error Source Table (AEST) enables kernel-first handling of
errors in a system that supports the Armv8 RAS extensions. AEST
is described in the ACPI for the Armv8 RAS Extensions 1.1,
Platform Design Document, dated 28 September 2020.
(https://developer.arm.com/documentation/den0085/0101/)

This v2 patch series:
 - adds AEST parser support to Acpiview.
 - addresses the review feedback for v1 series.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1429_aest_parser_v2

Marc Moisson-Franckhauser (2):
  MdePkg/IndustryStandard: AEST Table definition
  ShellPkg/Acpiview: AEST Parser

 MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h                        | 357 +++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  21 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c       | 755 ++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |   3 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |   3 +-
 7 files changed, 1142 insertions(+), 5 deletions(-)
 create mode 100644 MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69088): https://edk2.groups.io/g/devel/message/69088
Mute This Topic: https://groups.io/mt/78007253/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Posted by Gao, Zhichao 3 years, 4 months ago

For #1 and #2, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Thursday, December 17, 2020 5:34 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Matteo Carlini
> <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd
> <nd@arm.com>
> Subject: Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to
> Acpiview
> 
> Hi Zhichao,
> 
> May I have your feedback for this series, please?
> 
> I have raised two Bugzilla tickets for these patches:
>  - Bug 3049 - Add defintion for Arm Error Source Table (AEST)
> [https://bugzilla.tianocore.org/show_bug.cgi?id=3049]
>  - Bug 3048 - Acpiview: Add support for parsing Arm Error Source Table (AEST)
> [https://bugzilla.tianocore.org/show_bug.cgi?id=3048]
> 
> The links for these patches on the mailing list are as below:
>  - https://edk2.groups.io/g/devel/message/66928
> - https://edk2.groups.io/g/devel/message/66929
> - https://edk2.groups.io/g/devel/message/66930
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 03 November 2020 02:32 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; ray.ni@intel.com;
> zhichao.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben
> Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v2-resend 0/2] Add AEST parser support to Acpiview
> 
> Resending v2 patch series with Bugzilla IDs added. No code change since v2
> patch seiries.
> 
> Arm Error Source Table (AEST) enables kernel-first handling of errors in a system
> that supports the Armv8 RAS extensions. AEST is described in the ACPI for the
> Armv8 RAS Extensions 1.1, Platform Design Document, dated 28 September 2020.
> (https://developer.arm.com/documentation/den0085/0101/)
> 
> This v2 patch series:
>  - adds AEST parser support to Acpiview.
>  - addresses the review feedback for v1 series.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1429_aest_parser_v2
> 
> Marc Moisson-Franckhauser (2):
>   MdePkg/IndustryStandard: AEST Table definition
>   ShellPkg/Acpiview: AEST Parser
> 
>  MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h                        | 357
> +++++++++
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  21 +
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4
> +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c       |
> 755 ++++++++++++++++++++
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> |   4 +-
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.i
> nf |   3 +-
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.
> uni |   3 +-
>  7 files changed, 1142 insertions(+), 5 deletions(-)  create mode 100644
> MdePkg/Include/IndustryStandard/ArmErrorSourceTable.h
>  create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69469): https://edk2.groups.io/g/devel/message/69469
Mute This Topic: https://groups.io/mt/78007253/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Posted by Sami Mujawar 3 years, 3 months ago

Hi Zhichao,

Is there anything else needed before this series can be merged?

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69918): https://edk2.groups.io/g/devel/message/69918
Mute This Topic: https://groups.io/mt/78007253/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Posted by Gao, Zhichao 3 years, 3 months ago

On my side, no. I would create a PR later.

Thanks,
Zhichao

From: Sami Mujawar <sami.mujawar@arm.com>
Sent: Thursday, January 7, 2021 8:32 PM
To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2-resend 0/2] Add AEST parser support to Acpiview

Hi Zhichao,

Is there anything else needed before this series can be merged?

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70008): https://edk2.groups.io/g/devel/message/70008
Mute This Topic: https://groups.io/mt/78007253/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-