[edk2-devel] [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support

Gao, Zhichao posted 7 patches 5 years, 3 months ago
There is a newer version of this series
[edk2-devel] [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support
Posted by Gao, Zhichao 5 years, 3 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027

Remove the deprecated MD5 support of Hash2DxeCrypto
driver.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c   | 1 -
 SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
index d96bc136e2..50a6157bd9 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
@@ -120,7 +120,6 @@ typedef struct {
 } EFI_HASH_INFO;
 
 EFI_HASH_INFO  mHashInfo[] = {
-  {&gEfiHashAlgorithmMD5Guid,     sizeof(EFI_MD5_HASH2),    Md5GetContextSize,    Md5Init,    Md5Update,    Md5Final  },
   {&gEfiHashAlgorithmSha1Guid,    sizeof(EFI_SHA1_HASH2),   Sha1GetContextSize,   Sha1Init,   Sha1Update,   Sha1Final   },
   {&gEfiHashAlgorithmSha256Guid,  sizeof(EFI_SHA256_HASH2), Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
   {&gEfiHashAlgorithmSha384Guid,  sizeof(EFI_SHA384_HASH2), Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },
diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
index a0b57f0514..a65943056a 100644
--- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
+++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
@@ -4,7 +4,7 @@
 #  This module will use EDKII crypto library to HASH2 protocol.
 #
 #  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
-#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.<BR>
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 ##
@@ -44,7 +44,6 @@
   UefiLib
 
 [Guids]
-  gEfiHashAlgorithmMD5Guid              ## CONSUMES               ## GUID
   gEfiHashAlgorithmSha1Guid             ## CONSUMES               ## GUID
   gEfiHashAlgorithmSha256Guid           ## CONSUMES               ## GUID
   gEfiHashAlgorithmSha384Guid           ## CONSUMES               ## GUID
-- 
2.21.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66622): https://edk2.groups.io/g/devel/message/66622
Mute This Topic: https://groups.io/mt/77831677/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support
Posted by Yao, Jiewen 5 years, 3 months ago
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Tuesday, October 27, 2020 10:43 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>
> Subject: [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027
> 
> Remove the deprecated MD5 support of Hash2DxeCrypto
> driver.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c   | 1 -
>  SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> index d96bc136e2..50a6157bd9 100644
> --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> @@ -120,7 +120,6 @@ typedef struct {
>  } EFI_HASH_INFO;
> 
>  EFI_HASH_INFO  mHashInfo[] = {
> -  {&gEfiHashAlgorithmMD5Guid,     sizeof(EFI_MD5_HASH2),
> Md5GetContextSize,    Md5Init,    Md5Update,    Md5Final  },
>    {&gEfiHashAlgorithmSha1Guid,    sizeof(EFI_SHA1_HASH2),
> Sha1GetContextSize,   Sha1Init,   Sha1Update,   Sha1Final   },
>    {&gEfiHashAlgorithmSha256Guid,  sizeof(EFI_SHA256_HASH2),
> Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
>    {&gEfiHashAlgorithmSha384Guid,  sizeof(EFI_SHA384_HASH2),
> Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },
> diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> index a0b57f0514..a65943056a 100644
> --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> @@ -4,7 +4,7 @@
>  #  This module will use EDKII crypto library to HASH2 protocol.
>  #
>  #  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
> -#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> @@ -44,7 +44,6 @@
>    UefiLib
> 
>  [Guids]
> -  gEfiHashAlgorithmMD5Guid              ## CONSUMES               ## GUID
>    gEfiHashAlgorithmSha1Guid             ## CONSUMES               ## GUID
>    gEfiHashAlgorithmSha256Guid           ## CONSUMES               ## GUID
>    gEfiHashAlgorithmSha384Guid           ## CONSUMES               ## GUID
> --
> 2.21.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66627): https://edk2.groups.io/g/devel/message/66627
Mute This Topic: https://groups.io/mt/77831677/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-