Platform/Qemu/Sbsa: Fix build break due to need for RngLib

[edk2-devel] [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib

Posted by Andrew Goodbody 5 years, 4 months ago

Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
entropy in rand_pool") introduced RngLib dependency for OpensslLib
and caused QEMU platforms build to break for lack of an RngLib instance.

Add the reference to RngLib to the SbsaQemu.dsc file

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index d42b9cd4de..0e6d738bee 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -141,6 +141,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   #
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
 
   #
-- 
2.18.4



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65886): https://edk2.groups.io/g/devel/message/65886
Mute This Topic: https://groups.io/mt/77316343/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib

Posted by Ard Biesheuvel 5 years, 4 months ago

On 10/5/20 1:26 PM, Andrew Goodbody wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused QEMU platforms build to break for lack of an RngLib instance.
> 
> Add the reference to RngLib to the SbsaQemu.dsc file
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 8ef23e848b76..1288ede92a1c

Thanks,

> 
> ---
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index d42b9cd4de..0e6d738bee 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -141,6 +141,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
>     #
>     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
>   
>     #
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65892): https://edk2.groups.io/g/devel/message/65892
Mute This Topic: https://groups.io/mt/77316343/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-