[edk2-devel] [platforms: PATCH] Silicon/Marvell: Fix RngLib build error

Marcin Wojtas posted 1 patch 3 years, 6 months ago
Failed in applying to current master (apply log)
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [platforms: PATCH] Silicon/Marvell: Fix RngLib build error
Posted by Marcin Wojtas 3 years, 6 months ago
Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
entropy in rand_pool") introduced RngLib dependency for OpensslLib
and caused Marvell platforms build to break for lack of an RngLib instance.

This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 42f8bbba92..ce8e120ea4 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -27,6 +27,7 @@
   FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
   IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
   PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
+  RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
 !endif
 
 !if $(NETWORK_TLS_ENABLE)
-- 
2.28.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65870): https://edk2.groups.io/g/devel/message/65870
Mute This Topic: https://groups.io/mt/77298525/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [platforms: PATCH] Silicon/Marvell: Fix RngLib build error
Posted by Ard Biesheuvel 3 years, 6 months ago
On 10/4/20 4:22 PM, Marcin Wojtas wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused Marvell platforms build to break for lack of an RngLib instance.
> 
> This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
> around the the EFI_RNG_PROTOCOL that the platform already produces.
> 
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as b728a4ef5038..96a98e4d3255

Thanks,

> ---
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 42f8bbba92..ce8e120ea4 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -27,6 +27,7 @@
>     FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
>     IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
>     PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
> +  RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>   !endif
>   
>   !if $(NETWORK_TLS_ENABLE)
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65871): https://edk2.groups.io/g/devel/message/65871
Mute This Topic: https://groups.io/mt/77298525/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-