[edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.

Maciej Rabeda posted 1 patch 3 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20201002114423.2443-1-maciej.rabeda@linux.intel.com
NetworkPkg/NetworkPkg.dsc | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
Posted by Maciej Rabeda 3 years, 6 months ago
Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
causes NetworkPkg build to fail due to lack of RngLib entry in
NetworkPkg's .dsc file.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
---
 NetworkPkg/NetworkPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index 503d828f91e6..716d04fdadb2 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++ b/NetworkPkg/NetworkPkg.dsc
@@ -40,6 +40,7 @@
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+  RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
 
 !ifdef CONTINUOUS_INTEGRATION
   BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
-- 
2.24.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65833): https://edk2.groups.io/g/devel/message/65833
Mute This Topic: https://groups.io/mt/77259829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
Posted by Siyuan, Fu 3 years, 6 months ago
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>

> -----Original Message-----
> From: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Sent: 2020年10月2日 19:44
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
> 
> Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
> causes NetworkPkg build to fail due to lack of RngLib entry in
> NetworkPkg's .dsc file.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> ---
>  NetworkPkg/NetworkPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 503d828f91e6..716d04fdadb2 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -40,6 +40,7 @@
>    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> 
> 
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
> inf
> 
>    SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> 
> +  RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
> 
> 
> 
>  !ifdef CONTINUOUS_INTEGRATION
> 
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> 
> --
> 2.24.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66055): https://edk2.groups.io/g/devel/message/66055
Mute This Topic: https://groups.io/mt/77259829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
Posted by Maciej Rabeda 3 years, 6 months ago
Merged:
https://github.com/tianocore/edk2/commit/091ab12b340a05c99ce0e31d29293ce58c7014e2
https://github.com/tianocore/edk2/pull/994

On 09-Oct-20 10:41, Siyuan, Fu wrote:
> Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
>
>> -----Original Message-----
>> From: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Sent: 2020年10月2日 19:44
>> To: devel@edk2.groups.io
>> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
>> Subject: [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
>>
>> Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
>> causes NetworkPkg build to fail due to lack of RngLib entry in
>> NetworkPkg's .dsc file.
>>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> ---
>>   NetworkPkg/NetworkPkg.dsc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
>> index 503d828f91e6..716d04fdadb2 100644
>> --- a/NetworkPkg/NetworkPkg.dsc
>> +++ b/NetworkPkg/NetworkPkg.dsc
>> @@ -40,6 +40,7 @@
>>     DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>>
>>
>> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
>> inf
>>
>>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>>
>> +  RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
>>
>>
>>
>>   !ifdef CONTINUOUS_INTEGRATION
>>
>>     BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
>>
>> --
>> 2.24.0.windows.2
>
>
> 
>
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66056): https://edk2.groups.io/g/devel/message/66056
Mute This Topic: https://groups.io/mt/77259829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-