1. Highlight incompatible change
2. Define Release Maintainer Role

Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guptha Soumya K <soumya.k.guptha@intel.com>
---
 Who-we-are.md | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/Who-we-are.md b/Who-we-are.md
index d9c7045..1972a4b 100644
--- a/Who-we-are.md
+++ b/Who-we-are.md
@@ -48,14 +48,18 @@ A Contributor is anyone with interest in contributing to Tianocore.org
     for code contributions to any of the EDK II Projects on
     Tianocore.org such as:
 
--   Post patches to edk2-devel
+-   Post patches to edk2-devel. 
+
+-   For the incompatible change, coordinate with the impacted platform maintainer and
+    make the agreement who will follow up to update the impacted platforms before
+    the patch set is merged. The impacted platforms include all ones in Edk2 and Edk2Platforms.
 
 -   Ask questions (edk2-discuss, edk2-rfc, edk2-devel)
 
 -   File bugs (TianoCore Bugzilla)
 
 -   Test and review patches for others as defined in the [process
-    rule](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process)s
+    rule](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process)
 
 -   Author or correct wiki articles
 
@@ -113,7 +117,8 @@ The role of a maintainer is to:
 
 1.  Process review requests in FIFO order.
 
-2.  Never let a pending request get older than a calendar week.
+2.  Never let a pending request get older than a calendar week. Initial
+    feedback can be provided first if the patch set is complex or big.
 
 3.  If you are out-of-office for an extended period of time, inform the
     Stewards and/or your co-maintainers about pending requests. Use
@@ -183,6 +188,23 @@ A Reviewer is anyone with interest in contributing to Tianocore.org
 
 -   Same rules apply from the Contributors.
 
+## Release Maintainer
+--------
+
+### Definition 
+
+Release Maintainer is responsible to create the quarterly stable tag.
+
+### Role
+
+-   Collect the feature planning for each stable tag.(https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning)
+
+-   Schedule the release date (including soft feature freeze, hard feature freeze and release)
+
+-   Creat the stable tag with the release notes on tag page.(https://github.com/tianocore/edk2/tags)
+
+-   Send the announcement mail on soft feature freeze, hard feature freeze and the stable tag completement.
+
 ## Steward
 -------
 
-- 
2.27.0.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65765): https://edk2.groups.io/g/devel/message/65765
Mute This Topic: https://groups.io/mt/77214184/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

The content looks great; some superficial comments:

On 09/30/20 11:40, Liming Gao wrote:
> 1. Highlight incompatible change
> 2. Define Release Maintainer Role

can we split this in two patches?

>
> Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Guptha Soumya K <soumya.k.guptha@intel.com>
> ---
>  Who-we-are.md | 28 +++++++++++++++++++++++++---
>  1 file changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/Who-we-are.md b/Who-we-are.md
> index d9c7045..1972a4b 100644
> --- a/Who-we-are.md
> +++ b/Who-we-are.md
> @@ -48,14 +48,18 @@ A Contributor is anyone with interest in contributing to Tianocore.org
>      for code contributions to any of the EDK II Projects on
>      Tianocore.org such as:
>
> --   Post patches to edk2-devel
> +-   Post patches to edk2-devel.
> +
> +-   For the incompatible change, coordinate with the impacted platform maintainer and

I suggest replacing

  the incompatible change

with

  changes incompatible with current platforms

> +    make the agreement who will follow up to update the impacted platforms before
> +    the patch set is merged. The impacted platforms include all ones in Edk2 and Edk2Platforms.
>
>  -   Ask questions (edk2-discuss, edk2-rfc, edk2-devel)
>
>  -   File bugs (TianoCore Bugzilla)
>
>  -   Test and review patches for others as defined in the [process
> -    rule](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process)s
> +    rule](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process)
>
>  -   Author or correct wiki articles
>
> @@ -113,7 +117,8 @@ The role of a maintainer is to:
>
>  1.  Process review requests in FIFO order.
>
> -2.  Never let a pending request get older than a calendar week.
> +2.  Never let a pending request get older than a calendar week. Initial
> +    feedback can be provided first if the patch set is complex or big.
>
>  3.  If you are out-of-office for an extended period of time, inform the
>      Stewards and/or your co-maintainers about pending requests. Use

This could deserve its own patch -- my understanding is that this
clarification was really important to you, so it's not a small thing.

> @@ -183,6 +188,23 @@ A Reviewer is anyone with interest in contributing to Tianocore.org
>
>  -   Same rules apply from the Contributors.
>
> +## Release Maintainer
> +--------
> +
> +### Definition
> +
> +Release Maintainer is responsible to create the quarterly stable tag.
> +
> +### Role
> +
> +-   Collect the feature planning for each stable tag.(https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning)

Do we need a space after the period?

> +
> +-   Schedule the release date (including soft feature freeze, hard feature freeze and release)
> +
> +-   Creat the stable tag with the release notes on tag page.(https://github.com/tianocore/edk2/tags)

Typo: should be "Create".

Also, space after period.

> +
> +-   Send the announcement mail on soft feature freeze, hard feature freeze and the stable tag completement.
> +
>  ## Steward
>  -------
>
>

Finally:

- please use the [wiki PATCH]  subject prefix, or similar (can be set
  with --subject-prefix)

- the subject lines should be a bit more meaningful, such as:

  [wiki PATCH 1/3] Who we are: highlight platform incompatibilities and coordination
  [wiki PATCH 2/3] Who we are: clarify patch review response time expected of Maintainers
  [wiki PATCH 3/3] Who we are: define Release Maintainer Role

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65784): https://edk2.groups.io/g/devel/message/65784
Mute This Topic: https://groups.io/mt/77214184/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-