1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser

Sami Mujawar posted 2 patches 3 years, 6 months ago
Failed in applying to current master (apply log)
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |  15 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  24 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c       | 615 ++++++++++++++++++++
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h       |  33 ++
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |   4 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |   4 +-
7 files changed, 686 insertions(+), 13 deletions(-)
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h
[edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
Posted by Sami Mujawar 3 years, 6 months ago 
This patch series:
 - Addresses the feedback for v1 patch for PCCT parser.
 - Fixes an issue wherein the field validation is not
   invoked when a print formatter is present.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2

Marc Moisson-Franckhauser (1):
  ShellPkg/AcpiView: PCCT Parser

Sami Mujawar (1):
  ShellPkg/AcpiView: Fix field validator invocation

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |  15 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  24 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c       | 615 ++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h       |  33 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |   4 +-
 7 files changed, 686 insertions(+), 13 deletions(-)
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65561): https://edk2.groups.io/g/devel/message/65561
Mute This Topic: https://groups.io/mt/77055380/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
Posted by Sami Mujawar 3 years, 6 months ago 
Hi Zhichao,

Can you let me know anything is needed for this patch series, please?

Regards,

Sami Mujawar

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com> 
Sent: 24 September 2020 12:49 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; ray.ni@intel.com; zhichao.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser

This patch series:
 - Addresses the feedback for v1 patch for PCCT parser.
 - Fixes an issue wherein the field validation is not
   invoked when a print formatter is present.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2

Marc Moisson-Franckhauser (1):
  ShellPkg/AcpiView: PCCT Parser

Sami Mujawar (1):
  ShellPkg/AcpiView: Fix field validator invocation

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |  15 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  24 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c       | 615 ++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h       |  33 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |   4 +-
 7 files changed, 686 insertions(+), 13 deletions(-)
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66491): https://edk2.groups.io/g/devel/message/66491
Mute This Topic: https://groups.io/mt/77055380/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
Posted by Gao, Zhichao 3 years, 6 months ago 
Hi Sami,

I am OK with the patch #1 and #2. I hope you already tested the patch, did you?

Patch #2 is a bug fix and not related to the PCCT parser. You can put it in this patch set but it should be put before the first one. Because its fix also benefit patch #1.

And remind as I said before, it is highly suggested to file a BZ for a patch. For this patch set, BZ is required indeed because you put two different patches into one patch set. Two different BZ ID clearly descript that.
I have no other comments.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Wednesday, October 21, 2020 9:59 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Matteo
> Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>;
> nd <nd@arm.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT
> parser
> 
> Hi Zhichao,
> 
> Can you let me know anything is needed for this patch series, please?
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 24 September 2020 12:49 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; ray.ni@intel.com;
> zhichao.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben
> Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
> 
> This patch series:
>  - Addresses the feedback for v1 patch for PCCT parser.
>  - Fixes an issue wherein the field validation is not
>    invoked when a print formatter is present.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2
> 
> Marc Moisson-Franckhauser (1):
>   ShellPkg/AcpiView: PCCT Parser
> 
> Sami Mujawar (1):
>   ShellPkg/AcpiView: Fix field validator invocation
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |  15 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  24 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4
> +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c       |
> 615 ++++++++++++++++++++
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h       |
> 33 ++
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> |   4 +-
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.i
> nf |   4 +-
>  7 files changed, 686 insertions(+), 13 deletions(-)  create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
>  create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66556): https://edk2.groups.io/g/devel/message/66556
Mute This Topic: https://groups.io/mt/77055380/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
Posted by Sami Mujawar 3 years, 6 months ago 
Hi Zhichao,

Please find my response inline marked [SAMI]

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao via groups.io
Sent: 23 October 2020 06:53 AM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Ni, Ray <ray.ni@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser

Hi Sami,

I am OK with the patch #1 and #2. I hope you already tested the patch, did you?
[SAMI] The patch has been tested by creating a PCCT table with dummy values to test various conditions. [/SAMI]

Patch #2 is a bug fix and not related to the PCCT parser. You can put it in this patch set but it should be put before the first one. Because its fix also benefit patch #1.
[SAMI] I will resend this series with the order changed. [/SAMI]

And remind as I said before, it is highly suggested to file a BZ for a patch. For this patch set, BZ is required indeed because you put two different patches into one patch set. Two different BZ ID clearly descript that.
[SAMI] I will raise 2 bugzilla tickets and reword the commit messages for tracking when I send the updated series. [/SAMI]
I have no other comments.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Wednesday, October 21, 2020 9:59 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Matteo
> Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>;
> nd <nd@arm.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT
> parser
> 
> Hi Zhichao,
> 
> Can you let me know anything is needed for this patch series, please?
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 24 September 2020 12:49 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; ray.ni@intel.com;
> zhichao.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben
> Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser
> 
> This patch series:
>  - Addresses the feedback for v1 patch for PCCT parser.
>  - Fixes an issue wherein the field validation is not
>    invoked when a print formatter is present.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2
> 
> Marc Moisson-Franckhauser (1):
>   ShellPkg/AcpiView: PCCT Parser
> 
> Sami Mujawar (1):
>   ShellPkg/AcpiView: Fix field validator invocation
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |  15 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h                    |  24 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h               |   4
> +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c       |
> 615 ++++++++++++++++++++
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h       |
> 33 ++
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> |   4 +-
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.i
> nf |   4 +-
>  7 files changed, 686 insertions(+), 13 deletions(-)  create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
>  create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 
> 








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66568): https://edk2.groups.io/g/devel/message/66568
Mute This Topic: https://groups.io/mt/77055380/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.