[edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Nate DeSimone posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

[edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Posted by Nate DeSimone 2 weeks ago
Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg
instead of CoffeelakeSiliconBinPkg.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -10,7 +10,7 @@
 [Defines]
   DEFINE      PLATFORM_PACKAGE          = MinPlatformPkg
   DEFINE      PLATFORM_SI_PACKAGE       = CoffeelakeSiliconPkg
-  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
+  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
   DEFINE      PLATFORM_FSP_BIN_PACKAGE  = CometLakeFspBinPkg/CometLake1
   DEFINE      PLATFORM_BOARD_PACKAGE    = CometlakeOpenBoardPkg
   DEFINE      BOARD                     = CometlakeURvp
@@ -39,7 +39,8 @@
   #
   # Include PCD configuration for this board.
   #
-  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
   !include OpenBoardPkgPcd.dsc
   !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
 
-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64956): https://edk2.groups.io/g/devel/message/64956
Mute This Topic: https://groups.io/mt/76577729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Posted by Chaganty, Rangasai V 2 weeks ago
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Wednesday, September 02, 2020 12:15 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of CoffeelakeSiliconBinPkg.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.ds
+++ c
@@ -10,7 +10,7 @@
 [Defines]
   DEFINE      PLATFORM_PACKAGE          = MinPlatformPkg
   DEFINE      PLATFORM_SI_PACKAGE       = CoffeelakeSiliconPkg
-  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
+  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
   DEFINE      PLATFORM_FSP_BIN_PACKAGE  = CometLakeFspBinPkg/CometLake1
   DEFINE      PLATFORM_BOARD_PACKAGE    = CometlakeOpenBoardPkg
   DEFINE      BOARD                     = CometlakeURvp
@@ -39,7 +39,8 @@
   #
   # Include PCD configuration for this board.
   #
-  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
   !include OpenBoardPkgPcd.dsc
   !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
 
--
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64985): https://edk2.groups.io/g/devel/message/64985
Mute This Topic: https://groups.io/mt/76577729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Posted by Chiu, Chasel 2 weeks ago
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Wednesday, September 2, 2020 3:15 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of
> CometlakeSiliconBinPkg
> 
> Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of
> CoffeelakeSiliconBinPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 5
> +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> index 2d9dcb139f..6de834565a 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> s
> +++ c
> @@ -10,7 +10,7 @@
>  [Defines]
>    DEFINE      PLATFORM_PACKAGE          = MinPlatformPkg
>    DEFINE      PLATFORM_SI_PACKAGE       = CoffeelakeSiliconPkg
> -  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
> +  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
>    DEFINE      PLATFORM_FSP_BIN_PACKAGE  =
> CometLakeFspBinPkg/CometLake1
>    DEFINE      PLATFORM_BOARD_PACKAGE    =
> CometlakeOpenBoardPkg
>    DEFINE      BOARD                     = CometlakeURvp
> @@ -39,7 +39,8 @@
>    #
>    # Include PCD configuration for this board.
>    #
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> +
>    !include OpenBoardPkgPcd.dsc
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> --
> 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64961): https://edk2.groups.io/g/devel/message/64961
Mute This Topic: https://groups.io/mt/76577729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

Posted by Kathappan Esakkithevar 2 weeks ago
Reviewed-by: Kathappan Esakkithevar <Kathappan.Esakkithevar@intel.com>

> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Wednesday, September 2, 2020 1:29 PM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy,
> Deepika <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: RE: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add
> usage of CometlakeSiliconBinPkg
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> > -----Original Message-----
> > From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> > Sent: Wednesday, September 2, 2020 3:15 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> > <kathappan.esakkithevar@intel.com>
> > Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage
> > of CometlakeSiliconBinPkg
> >
> > Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead
> of
> > CoffeelakeSiliconBinPkg.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > ---
> >  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 5
> > +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > index 2d9dcb139f..6de834565a 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > +++
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > s
> > +++ c
> > @@ -10,7 +10,7 @@
> >  [Defines]
> >    DEFINE      PLATFORM_PACKAGE          = MinPlatformPkg
> >    DEFINE      PLATFORM_SI_PACKAGE       = CoffeelakeSiliconPkg
> > -  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
> > +  DEFINE      PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
> >    DEFINE      PLATFORM_FSP_BIN_PACKAGE  =
> > CometLakeFspBinPkg/CometLake1
> >    DEFINE      PLATFORM_BOARD_PACKAGE    =
> > CometlakeOpenBoardPkg
> >    DEFINE      BOARD                     = CometlakeURvp
> > @@ -39,7 +39,8 @@
> >    #
> >    # Include PCD configuration for this board.
> >    #
> > -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> >
> > +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> > +
> >    !include OpenBoardPkgPcd.dsc
> >    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> >
> > --
> > 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64969): https://edk2.groups.io/g/devel/message/64969
Mute This Topic: https://groups.io/mt/76577729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-