OvmfPkg: fix race conditions in VCPU hotplug (for edk2-stable202008)

[edk2-devel] [PATCH 0/2] OvmfPkg: fix race conditions in VCPU hotplug (for edk2-stable202008)

Posted by Laszlo Ersek 3 years, 8 months ago

Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2929
Repo:   https://pagure.io/lersek/edk2.git
Branch: cpu_hotplug_races_bz_2929

Proposing these bugfixes for edk2-stable202008. We should either include
them in the release, or revert commit 5ba203b54e59
("OvmfPkg/SmmControl2Dxe: negotiate ICH9_LPC_SMI_F_CPU_HOTPLUG",
2020-08-24). Please see the BZ for more details.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks,
Laszlo

Laszlo Ersek (2):
  OvmfPkg/CpuHotplugSmm: fix CPU hotplug race just before SMI broadcast
  OvmfPkg/CpuHotplugSmm: fix CPU hotplug race just after SMI broadcast

 OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 19 +++++++++++
 OvmfPkg/CpuHotplugSmm/Smbase.c     | 35 ++++++++++++++++----
 2 files changed, 48 insertions(+), 6 deletions(-)

-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64659): https://edk2.groups.io/g/devel/message/64659
Mute This Topic: https://groups.io/mt/76439553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: fix race conditions in VCPU hotplug (for edk2-stable202008)

Posted by Ard Biesheuvel 3 years, 8 months ago

On 8/27/20 12:21 AM, Laszlo Ersek wrote:
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2929
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: cpu_hotplug_races_bz_2929
> 
> Proposing these bugfixes for edk2-stable202008. We should either include
> them in the release, or revert commit 5ba203b54e59
> ("OvmfPkg/SmmControl2Dxe: negotiate ICH9_LPC_SMI_F_CPU_HOTPLUG",
> 2020-08-24). Please see the BZ for more details.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> 


For the series,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

I have no objections to incorporating these changes into the upcoming 
stable tag.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64673): https://edk2.groups.io/g/devel/message/64673
Mute This Topic: https://groups.io/mt/76439553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: fix race conditions in VCPU hotplug (for edk2-stable202008)

Posted by Laszlo Ersek 3 years, 7 months ago

On 08/27/20 09:50, Ard Biesheuvel wrote:
> On 8/27/20 12:21 AM, Laszlo Ersek wrote:
>> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2929
>> Repo:   https://pagure.io/lersek/edk2.git
>> Branch: cpu_hotplug_races_bz_2929
>>
>> Proposing these bugfixes for edk2-stable202008. We should either include
>> them in the release, or revert commit 5ba203b54e59
>> ("OvmfPkg/SmmControl2Dxe: negotiate ICH9_LPC_SMI_F_CPU_HOTPLUG",
>> 2020-08-24). Please see the BZ for more details.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
> 
> 
> For the series,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> I have no objections to incorporating these changes into the upcoming
> stable tag.

Thanks a lot for your help, Ard!

Merged as commit range 63d92674d240..cbccf995920a, via
<https://github.com/tianocore/edk2/pull/905>.

Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64702): https://edk2.groups.io/g/devel/message/64702
Mute This Topic: https://groups.io/mt/76439553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-