[edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement

Qi Zhang posted 8 patches 3 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200814063159.2477-1-qi1.zhang@intel.com
There is a newer version of this series
.../FspmWrapperPeim/FspmWrapperPeim.c         |  90 ++++++-
.../FspmWrapperPeim/FspmWrapperPeim.inf       |  20 +-
.../FspsWrapperPeim/FspsWrapperPeim.c         |  86 +++++-
.../FspsWrapperPeim/FspsWrapperPeim.inf       |  27 +-
.../Include/Library/FspMeasurementLib.h       |  39 +++
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec   |  17 ++
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc   |  10 +-
.../BaseFspMeasurementLib.inf                 |  54 ++++
.../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++
.../Include/Library/FvEventLogRecordLib.h     |  97 +++++++
SecurityPkg/Include/Ppi/Tcg.h                 |   5 +
.../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++
.../FvEventLogRecordLib.inf                   |  40 +++
.../FvEventLogRecordLib.uni                   |  17 ++
SecurityPkg/SecurityPkg.dec                   |   3 +
SecurityPkg/SecurityPkg.dsc                   |   2 +
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             |  12 +-
17 files changed, 939 insertions(+), 25 deletions(-)
create mode 100644 IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h
create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf
create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c
create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h
create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c
create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf
create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni
[edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement
Posted by Qi Zhang 3 years, 8 months ago
v3 change:
  add a new lib FvEventLogRecordLib for gerneric code.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376

The EDKII BIOS calls FSP API in FSP Wrapper Pkg.
This FSP code need to be measured into TPM.

We need add a generic module in FSP Wrapper Pkg code to measure:
1) FSP-T, FSP-M, FSP-S in API mode.
2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported
   as standard FV and they will be measured by TCG-PEI.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>

Jiewen Yao (4):
  IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.
  IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.
  IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.
  IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and
    PcdFspMeasurementConfig.

Qi Zhang (4):
  SecurityPkg/FvEventLogRecordLib: add new lib for firmware measurement
  SecurityPkg/dsc: add FvEventLogRecordLib
  SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
  IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib

 .../FspmWrapperPeim/FspmWrapperPeim.c         |  90 ++++++-
 .../FspmWrapperPeim/FspmWrapperPeim.inf       |  20 +-
 .../FspsWrapperPeim/FspsWrapperPeim.c         |  86 +++++-
 .../FspsWrapperPeim/FspsWrapperPeim.inf       |  27 +-
 .../Include/Library/FspMeasurementLib.h       |  39 +++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec   |  17 ++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc   |  10 +-
 .../BaseFspMeasurementLib.inf                 |  54 ++++
 .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++
 .../Include/Library/FvEventLogRecordLib.h     |  97 +++++++
 SecurityPkg/Include/Ppi/Tcg.h                 |   5 +
 .../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++
 .../FvEventLogRecordLib.inf                   |  40 +++
 .../FvEventLogRecordLib.uni                   |  17 ++
 SecurityPkg/SecurityPkg.dec                   |   3 +
 SecurityPkg/SecurityPkg.dsc                   |   2 +
 SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             |  12 +-
 17 files changed, 939 insertions(+), 25 deletions(-)
 create mode 100644 IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h
 create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf
 create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c
 create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h
 create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c
 create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf
 create mode 100644 SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni

-- 
2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64274): https://edk2.groups.io/g/devel/message/64274
Mute This Topic: https://groups.io/mt/76183465/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement
Posted by Yao, Jiewen 3 years, 8 months ago
Hi Qi
Thanks for the update.
The name FvEventLogRecordLib is confusing. It is more than Fv.
Maybe we can rename it to TcgEventLogRecordLib ?

With naming change, the series reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Thank you
Yao Jiewen


> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Friday, August 14, 2020 2:32 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Chiu,
> Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v3 0/8] Need add a FSP binary measurement
> 
> v3 change:
>   add a new lib FvEventLogRecordLib for gerneric code.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376
> 
> The EDKII BIOS calls FSP API in FSP Wrapper Pkg.
> This FSP code need to be measured into TPM.
> 
> We need add a generic module in FSP Wrapper Pkg code to measure:
> 1) FSP-T, FSP-M, FSP-S in API mode.
> 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported
>    as standard FV and they will be measured by TCG-PEI.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> 
> Jiewen Yao (4):
>   IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.
>   IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.
>   IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.
>   IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and
>     PcdFspMeasurementConfig.
> 
> Qi Zhang (4):
>   SecurityPkg/FvEventLogRecordLib: add new lib for firmware measurement
>   SecurityPkg/dsc: add FvEventLogRecordLib
>   SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
>   IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib
> 
>  .../FspmWrapperPeim/FspmWrapperPeim.c         |  90 ++++++-
>  .../FspmWrapperPeim/FspmWrapperPeim.inf       |  20 +-
>  .../FspsWrapperPeim/FspsWrapperPeim.c         |  86 +++++-
>  .../FspsWrapperPeim/FspsWrapperPeim.inf       |  27 +-
>  .../Include/Library/FspMeasurementLib.h       |  39 +++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec   |  17 ++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc   |  10 +-
>  .../BaseFspMeasurementLib.inf                 |  54 ++++
>  .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++
>  .../Include/Library/FvEventLogRecordLib.h     |  97 +++++++
>  SecurityPkg/Include/Ppi/Tcg.h                 |   5 +
>  .../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++
>  .../FvEventLogRecordLib.inf                   |  40 +++
>  .../FvEventLogRecordLib.uni                   |  17 ++
>  SecurityPkg/SecurityPkg.dec                   |   3 +
>  SecurityPkg/SecurityPkg.dsc                   |   2 +
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             |  12 +-
>  17 files changed, 939 insertions(+), 25 deletions(-)
>  create mode 100644
> IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLi
> b.inf
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c
>  create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni
> 
> --
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64299): https://edk2.groups.io/g/devel/message/64299
Mute This Topic: https://groups.io/mt/76183465/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement
Posted by Wang, Jian J 3 years, 8 months ago
For the whole series, 

	Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Friday, August 14, 2020 2:32 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Chiu,
> Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v3 0/8] Need add a FSP binary measurement
> 
> v3 change:
>   add a new lib FvEventLogRecordLib for gerneric code.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376
> 
> The EDKII BIOS calls FSP API in FSP Wrapper Pkg.
> This FSP code need to be measured into TPM.
> 
> We need add a generic module in FSP Wrapper Pkg code to measure:
> 1) FSP-T, FSP-M, FSP-S in API mode.
> 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported
>    as standard FV and they will be measured by TCG-PEI.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> 
> Jiewen Yao (4):
>   IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.
>   IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.
>   IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.
>   IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and
>     PcdFspMeasurementConfig.
> 
> Qi Zhang (4):
>   SecurityPkg/FvEventLogRecordLib: add new lib for firmware measurement
>   SecurityPkg/dsc: add FvEventLogRecordLib
>   SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
>   IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib
> 
>  .../FspmWrapperPeim/FspmWrapperPeim.c         |  90 ++++++-
>  .../FspmWrapperPeim/FspmWrapperPeim.inf       |  20 +-
>  .../FspsWrapperPeim/FspsWrapperPeim.c         |  86 +++++-
>  .../FspsWrapperPeim/FspsWrapperPeim.inf       |  27 +-
>  .../Include/Library/FspMeasurementLib.h       |  39 +++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec   |  17 ++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc   |  10 +-
>  .../BaseFspMeasurementLib.inf                 |  54 ++++
>  .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++
>  .../Include/Library/FvEventLogRecordLib.h     |  97 +++++++
>  SecurityPkg/Include/Ppi/Tcg.h                 |   5 +
>  .../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++
>  .../FvEventLogRecordLib.inf                   |  40 +++
>  .../FvEventLogRecordLib.uni                   |  17 ++
>  SecurityPkg/SecurityPkg.dec                   |   3 +
>  SecurityPkg/SecurityPkg.dsc                   |   2 +
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             |  12 +-
>  17 files changed, 939 insertions(+), 25 deletions(-)
>  create mode 100644
> IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLi
> b.inf
>  create mode 100644
> IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c
>  create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf
>  create mode 100644
> SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni
> 
> --
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64342): https://edk2.groups.io/g/devel/message/64342
Mute This Topic: https://groups.io/mt/76183465/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-