[edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English

Samer El-Haj-Mahmoud posted 2 patches 5 years, 6 months ago
[edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English
Posted by Samer El-Haj-Mahmoud 5 years, 6 months ago
Set the supported RPi4 platform language to English (US),
and remove French.

This fixes https://github.com/pftf/RPi4/issues/35

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index c481c3534263..68c0e670648f 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -1,6 +1,6 @@
 # @file
 #
-#  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
+#  Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
 #  Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
 #  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
 #  Copyright (c) 2014, Linaro Limited. All rights reserved.
@@ -352,6 +352,9 @@ [PcdsFixedAtBuild.common]
 
   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
 
+  # Default platform supported RFC 4646 languages: (American) English
+  gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
+
 [LibraryClasses.common]
   ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
   ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62788): https://edk2.groups.io/g/devel/message/62788
Mute This Topic: https://groups.io/mt/75654067/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English
Posted by Pete Batard 5 years, 6 months ago
On 2020.07.19 00:04, Samer El-Haj-Mahmoud wrote:
> Set the supported RPi4 platform language to English (US),
> and remove French.
> 
> This fixes https://github.com/pftf/RPi4/issues/35
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c481c3534263..68c0e670648f 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -1,6 +1,6 @@
>   # @file
>   #
> -#  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
>   #  Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
>   #  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> @@ -352,6 +352,9 @@ [PcdsFixedAtBuild.common]
>   
>     gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>   
> +  # Default platform supported RFC 4646 languages: (American) English
> +  gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
> +
>   [LibraryClasses.common]
>     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>     ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> 

Reviewed-by: Pete Batard <pete@akeo.ie>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62835): https://edk2.groups.io/g/devel/message/62835
Mute This Topic: https://groups.io/mt/75654067/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English
Posted by Andrei Warkentin 5 years, 6 months ago
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>

A
________________________________
From: Pete Batard <pete@akeo.ie>
Sent: Monday, July 20, 2020 7:08 AM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English

On 2020.07.19 00:04, Samer El-Haj-Mahmoud wrote:
> Set the supported RPi4 platform language to English (US),
> and remove French.
>
> This fixes https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpftf%2FRPi4%2Fissues%2F35&amp;data=02%7C01%7Cawarkentin%40vmware.com%7Cb4f1633a5be240abb30508d82ca599f5%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637308437048337633&amp;sdata=%2BsazEjNWrQkdIvdtPAvzCdCPpYtSaWNuOYzHIaGGdeg%3D&amp;reserved=0
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> ---
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c481c3534263..68c0e670648f 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -1,6 +1,6 @@
>   # @file
>   #
> -#  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
>   #  Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
>   #  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> @@ -352,6 +352,9 @@ [PcdsFixedAtBuild.common]
>
>     gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>
> +  # Default platform supported RFC 4646 languages: (American) English
> +  gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
> +
>   [LibraryClasses.common]
>     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>     ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>

Reviewed-by: Pete Batard <pete@akeo.ie>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62838): https://edk2.groups.io/g/devel/message/62838
Mute This Topic: https://groups.io/mt/75654067/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-