Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, July 9, 2020 12:05 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in INF
>
> Update INF file to use a [Pcd] section instead of a
> [FixedPcd] section. [FixedPcd] should only be used in an
> INF file if the source code looks up the PCD value using
> the PcdLib FixedPcdGetxx() services. Using [FixedPcd]
> forces a platform to configure the PCD to type FixedAtBuild.
> In this case, PcdDebugPropertyMask supports PCD types
> FixedAtBuild and PatchableInModule. Without this change
> any platform that wants to use PcdDebugPropertyMask as
> type PatchableInModule breaks the build.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> index 4ae3bd1a82..0dc3c4a83a 100644
> --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> @@ -36,5 +36,5 @@ [LibraryClasses]
> BaseLib
> DebugLib
>
> -[FixedPcd]
> +[Pcd]
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## CONSUMES
> --
> 2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#62306): https://edk2.groups.io/g/devel/message/62306
Mute This Topic: https://groups.io/mt/75391622/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-