EmbeddedPkg/PrePiLib: rework FfsProcessSection

[edk2-devel] [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection

Posted by Leif Lindholm 3 years, 9 months ago

https://bugzilla.tianocore.org/show_bug.cgi?id=2820 describes a build
failure caused by misanalysis by the compiler, but the problematic code
was pretty grotty, so here's an attempt at cleaning it up.

This set can also be accessed at:
https://github.com/leiflindholm/edk2/tree/embedded-fwvol-cleanup

Note: this code is only build tested.

Leif Lindholm (5):
  EmbeddedPkg/PrePiLib: style cleanup in FwVol.c
  EmbeddedPkg/PrePiLib: drop else if after return
  EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling
  EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData
  EmbeddedPkg/PrePiLib: break section extraction info into helper
    function

 EmbeddedPkg/Library/PrePiLib/FwVol.c | 214 ++++++++++++++++-----------
 1 file changed, 125 insertions(+), 89 deletions(-)

-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61923): https://edk2.groups.io/g/devel/message/61923
Mute This Topic: https://groups.io/mt/75244267/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection

Posted by Ard Biesheuvel 3 years, 9 months ago

On 7/1/20 10:01 PM, Leif Lindholm wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2820 describes a build
> failure caused by misanalysis by the compiler, but the problematic code
> was pretty grotty, so here's an attempt at cleaning it up.
> 
> This set can also be accessed at:
> https://github.com/leiflindholm/edk2/tree/embedded-fwvol-cleanup
> 
> Note: this code is only build tested.
> 
> Leif Lindholm (5):
>    EmbeddedPkg/PrePiLib: style cleanup in FwVol.c
>    EmbeddedPkg/PrePiLib: drop else if after return
>    EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling
>    EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData
>    EmbeddedPkg/PrePiLib: break section extraction info into helper
>      function
> 

For the series:

Tested-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>


>   EmbeddedPkg/Library/PrePiLib/FwVol.c | 214 ++++++++++++++++-----------
>   1 file changed, 125 insertions(+), 89 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61955): https://edk2.groups.io/g/devel/message/61955
Mute This Topic: https://groups.io/mt/75244267/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-