Hi Sean,
Thank you for the inputs.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
-----Original Message-----
From: Sean Brogan <spbrogan@outlook.com>
Sent: 29 June 2020 07:56 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; liming.gao@intel.com; michael.d.kinney@intel.com; Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 0/3] Add EDKII CI support for DynamicTablesPkg
Two additional questions/comments with this patch set.
1. Is this package not compatible with MSVC toolchain? From the readme update it looks like GCC/Ubuntu only. From the DSC it looks like
ARM|AARCH64 only? Is there any reason this isn't compatible?
[SAMI] There are a few dependencies that need to be fixed before DynamicTablesPkg can build with MSVC toolchain. I will submit them as a separate patch series.
2. You need one more patch to get this run as part of CI.
You need to add the package to the matrix.
https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L38
It can probably be added in with an existing package. Usually i look
over the build job summary and find a job with less than the max time
and has similar packages and then add it there.
For example looking at the CI GCC build here:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=8964&view=results
It looks like adding to FMP_FAT_TEST would work.
[SAMI] I have included this in the v2 series and will be posting it shortly.
Thanks
Sean
On 6/29/2020 6:27 AM, Sami Mujawar wrote:
> The TianoCore EDKII project has introduced a Core CI infrastructure
> using TianoCore EDKII Tools PIP modules.
>
> This patch series adds support for building DynamicTablesPkg using
> the EKDII Core CI.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v1
>
>
> Sami Mujawar (3):
> DynamicTablesPkg: Fix issues reported by EDKII CI
> DynamicTablesPkg: Add EDK2 Core CI support
> .pytool: CI Settings to support DynamicTablesPkg
>
> .pytool/CISettings.py | 2 +
> .pytool/Readme.md | 2 +-
> DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 103 ++++++++++++++++++++
> DynamicTablesPkg/DynamicTablesPkg.dec | 7 +-
> DynamicTablesPkg/DynamicTablesPkg.dsc | 4 +-
> DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 6 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 4 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 8 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 12 +--
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 6 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 4 +-
> DynamicTablesPkg/Readme.md | 73 +++++++++++++-
> 12 files changed, 205 insertions(+), 26 deletions(-)
> create mode 100644 DynamicTablesPkg/DynamicTablesPkg.ci.yaml
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61862): https://edk2.groups.io/g/devel/message/61862
Mute This Topic: https://groups.io/mt/75191110/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-