.../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 + 1 file changed, 1 insertion(+)
Update GetPciSegmentInfo() API to match its library class definition
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
.../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
index 6a6218d906..398f4d4b78 100644
--- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
+++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
@@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo;
@retval A callee owned array holding the segment information.
**/
PCI_SEGMENT_INFO *
+EFIAPI
GetPciSegmentInfo (
OUT UINTN *Count
)
--
2.13.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61680): https://edk2.groups.io/g/devel/message/61680
Mute This Topic: https://groups.io/mt/75082470/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Gao, Liming <liming.gao@intel.com> Sent: Wednesday, June 24, 2020 7:22 AM To: devel@edk2.groups.io Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com> Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Update GetPciSegmentInfo() API to match its library class definition Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Eric Dong <eric.dong@intel.com> --- .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c index 6a6218d906..398f4d4b78 100644 --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( OUT UINTN *Count ) -- 2.13.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61690): https://edk2.groups.io/g/devel/message/61690 Mute This Topic: https://groups.io/mt/75082470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Liming, Thank you! I didn't realize MinPlatformPkg contain an implementation of PciSegmentInfoLib when adding missing EFIAPI to the API prototype. Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Wednesday, June 24, 2020 10:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com> > Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API > > Update GetPciSegmentInfo() API to match its library class definition > > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > --- > .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > index 6a6218d906..398f4d4b78 100644 > --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; > @retval A callee owned array holding the segment information. > **/ > PCI_SEGMENT_INFO * > +EFIAPI > GetPciSegmentInfo ( > OUT UINTN *Count > ) > -- > 2.13.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61699): https://edk2.groups.io/g/devel/message/61699 Mute This Topic: https://groups.io/mt/75082470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hey Liming, Any chance we could push this? All MinPlatform builds are currently broken. Thanks, Nate On 6/24/20, 7:21 AM, "Gao, Liming" <liming.gao@intel.com> wrote: Update GetPciSegmentInfo() API to match its library class definition Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Eric Dong <eric.dong@intel.com> --- .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c index 6a6218d906..398f4d4b78 100644 --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( OUT UINTN *Count ) -- 2.13.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61728): https://edk2.groups.io/g/devel/message/61728 Mute This Topic: https://groups.io/mt/75082470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
It has been pushed @ edde5826b0d2a733ed1b341ffb882969a9130958 > -----Original Message----- > From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> > Sent: Thursday, June 25, 2020 11:23 PM > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com> > Subject: Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API > > Hey Liming, > > Any chance we could push this? All MinPlatform builds are currently broken. > > Thanks, > Nate > > On 6/24/20, 7:21 AM, "Gao, Liming" <liming.gao@intel.com> wrote: > > Update GetPciSegmentInfo() API to match its library class definition > > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > --- > .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > index 6a6218d906..398f4d4b78 100644 > --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; > @retval A callee owned array holding the segment information. > **/ > PCI_SEGMENT_INFO * > +EFIAPI > GetPciSegmentInfo ( > OUT UINTN *Count > ) > -- > 2.13.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61735): https://edk2.groups.io/g/devel/message/61735 Mute This Topic: https://groups.io/mt/75082470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com> > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Wednesday, June 24, 2020 10:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric > <eric.dong@intel.com> > Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update > GetPciSegmentInfo() API > > Update GetPciSegmentInfo() API to match its library class definition > > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > --- > .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c > | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe > gmentInfoLibSimple.c > b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe > gmentInfoLibSimple.c > index 6a6218d906..398f4d4b78 100644 > --- > a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe > gmentInfoLibSimple.c > +++ > b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe > gmentInfoLibSimple.c > @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; > @retval A callee owned array holding the segment information. > **/ > PCI_SEGMENT_INFO * > +EFIAPI > GetPciSegmentInfo ( > OUT UINTN *Count > ) > -- > 2.13.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61684): https://edk2.groups.io/g/devel/message/61684 Mute This Topic: https://groups.io/mt/75082470/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.