[edk2-devel] [PATCH v4 0/7] Standalone AcpiView Application

Tomas Pilar (tpilar) posted 7 patches 2 weeks ago
Failed in applying to current master (apply log)
.../Application/AcpiViewApp/AcpiViewApp.c     |  40 ++
.../Application/AcpiViewApp/AcpiViewApp.inf   |  34 ++
.../Application/AcpiViewApp/AcpiViewApp.uni   | 122 +++++
ShellPkg/Include/Library/AcpiViewCommandLib.h |  46 ++
.../UefiShellAcpiViewCommandLib/AcpiParser.c  |   1 +
.../AcpiTableParser.c                         |   1 +
.../UefiShellAcpiViewCommandLib/AcpiView.c    | 474 ++----------------
.../UefiShellAcpiViewCommandLib/AcpiView.h    | 113 +----
.../AcpiViewConfig.c                          | 246 +++++++++
.../AcpiViewConfig.h                          | 177 +++++++
.../Parsers/Gtdt/GtdtParser.c                 |   1 +
.../Parsers/Iort/IortParser.c                 |   1 +
.../Parsers/Madt/MadtParser.c                 |   1 +
.../Parsers/Pptt/PpttParser.c                 |   1 +
.../Parsers/Srat/SratParser.c                 |   1 +
.../UefiShellAcpiViewCommandLib.c             | 279 ++++++++++-
.../UefiShellAcpiViewCommandLib.h             |  26 -
.../UefiShellAcpiViewCommandLib.inf           |  33 +-
ShellPkg/ShellPkg.dec                         |   3 +
ShellPkg/ShellPkg.dsc                         |   4 +-
20 files changed, 1019 insertions(+), 585 deletions(-)
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf
create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni
create mode 100644 ShellPkg/Include/Library/AcpiViewCommandLib.h
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c
create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h
delete mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.h

[edk2-devel] [PATCH v4 0/7] Standalone AcpiView Application

Posted by Tomas Pilar (tpilar) 2 weeks ago
This patchset adds a new application module to the 
ShellPkg with the functionality of the 'acpiview' command.

The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.

The motivation for a standalone AcpiView application lies
in the desire to test implementation of the Acpi tables on 
a wide selection of platforms, particularly platforms still
in development, platforms that might have an older implementation
of the UEFI shell or platforms that might not include the 'acpiview'
command in the internal build of the UEFI shell. Furthermore,
this application can then be integrated in larger firmware
testing frameworks.

---
v4: Minor formatting.
v3: Fix pointer dereference in GetSelectedTable. Create library
    interface for the UefiShellAcpiViewCommandLib and convert to
    named library. Tidy help text shell hook in standalone app.
v2: Patch formatting

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>

Tomas Pilar (7):
  ShellPkg/AcpiView: Move log reset to main method
  ShellPkg/AcpiView: Refactor configuration
  ShellPkg/AcpiView: Move table count reset
  ShellPkg/AcpiView: Move parameter parsing
  ShellPkg/AcpiView: Refactor DumpAcpiTableToFile
  ShellPkg: Add AcpiViewCommandLib
  ShellPkg/AcpiView: Add application wrapper

 .../Application/AcpiViewApp/AcpiViewApp.c     |  40 ++
 .../Application/AcpiViewApp/AcpiViewApp.inf   |  34 ++
 .../Application/AcpiViewApp/AcpiViewApp.uni   | 122 +++++
 ShellPkg/Include/Library/AcpiViewCommandLib.h |  46 ++
 .../UefiShellAcpiViewCommandLib/AcpiParser.c  |   1 +
 .../AcpiTableParser.c                         |   1 +
 .../UefiShellAcpiViewCommandLib/AcpiView.c    | 474 ++----------------
 .../UefiShellAcpiViewCommandLib/AcpiView.h    | 113 +----
 .../AcpiViewConfig.c                          | 246 +++++++++
 .../AcpiViewConfig.h                          | 177 +++++++
 .../Parsers/Gtdt/GtdtParser.c                 |   1 +
 .../Parsers/Iort/IortParser.c                 |   1 +
 .../Parsers/Madt/MadtParser.c                 |   1 +
 .../Parsers/Pptt/PpttParser.c                 |   1 +
 .../Parsers/Srat/SratParser.c                 |   1 +
 .../UefiShellAcpiViewCommandLib.c             | 279 ++++++++++-
 .../UefiShellAcpiViewCommandLib.h             |  26 -
 .../UefiShellAcpiViewCommandLib.inf           |  33 +-
 ShellPkg/ShellPkg.dec                         |   3 +
 ShellPkg/ShellPkg.dsc                         |   4 +-
 20 files changed, 1019 insertions(+), 585 deletions(-)
 create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c
 create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf
 create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni
 create mode 100644 ShellPkg/Include/Library/AcpiViewCommandLib.h
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h
 delete mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.h

-- 
2.24.1.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61600): https://edk2.groups.io/g/devel/message/61600
Mute This Topic: https://groups.io/mt/75059838/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-