ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

[edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

Posted by Ard Biesheuvel 3 years, 10 months ago

PlatformBootManagerLib now asserts at build time that the correct
terminal type is used, and so leaving it unset breaks the ArmPkg
DSC build. So fix that.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 ArmPkg/ArmPkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 549a2d29ab61..bac1306af61f 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -29,6 +29,9 @@ [BuildOptions]
   RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG
   *_*_*_CC_FLAGS  = -DDISABLE_NEW_DEPRECATED_INTERFACES
 
+[PcdsFixedAtBuild]
+  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
+
 [LibraryClasses.common]
   BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
-- 
2.26.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60695): https://edk2.groups.io/g/devel/message/60695
Mute This Topic: https://groups.io/mt/74657446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

Posted by Leif Lindholm 3 years, 10 months ago

On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote:
> PlatformBootManagerLib now asserts at build time that the correct
> terminal type is used, and so leaving it unset breaks the ArmPkg
> DSC build. So fix that.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  ArmPkg/ArmPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 549a2d29ab61..bac1306af61f 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -29,6 +29,9 @@ [BuildOptions]
>    RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG
>    *_*_*_CC_FLAGS  = -DDISABLE_NEW_DEPRECATED_INTERFACES
>  
> +[PcdsFixedAtBuild]
> +  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
> +
>  [LibraryClasses.common]
>    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>    BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> -- 
> 2.26.2
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60696): https://edk2.groups.io/g/devel/message/60696
Mute This Topic: https://groups.io/mt/74657446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

Posted by Ard Biesheuvel 3 years, 10 months ago

On 6/3/20 10:18 PM, Leif Lindholm wrote:
> On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote:
>> PlatformBootManagerLib now asserts at build time that the correct
>> terminal type is used, and so leaving it unset breaks the ArmPkg
>> DSC build. So fix that.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 

Thanks

Pushed as #657

>> ---
>>   ArmPkg/ArmPkg.dsc | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
>> index 549a2d29ab61..bac1306af61f 100644
>> --- a/ArmPkg/ArmPkg.dsc
>> +++ b/ArmPkg/ArmPkg.dsc
>> @@ -29,6 +29,9 @@ [BuildOptions]
>>     RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG
>>     *_*_*_CC_FLAGS  = -DDISABLE_NEW_DEPRECATED_INTERFACES
>>   
>> +[PcdsFixedAtBuild]
>> +  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
>> +
>>   [LibraryClasses.common]
>>     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>> -- 
>> 2.26.2
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60697): https://edk2.groups.io/g/devel/message/60697
Mute This Topic: https://groups.io/mt/74657446/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-