V8 Add DEBUG_VERBOSE message and unit test
V7 addressed review comments (only documentation changes).
Current implementation of SafeString does not let one parse untrusted
data with its interfaces as they ASSERT on failing runtime checks and
require one to effectively reimplement the function on the caller side.
All the former proposals made it clear that the attempts to introduce
a solution preserving this behavior require a lot of changes
throughout the codebase including platform code (e.g. introducing
constraint assertions and updating all DebugLib implementations)
or require all sorts of hacks.
Since the original code has roughly no benefit except in some very
special cases and the effort required to preserve it is very high,
I propose to remove it as agreed on with several other parties.
Please note, that this patch does not change the behaviour of the
functions in RELEASE builds. I.e. they will still check for NULL
and return RETURN_INVALID_PARAMETER. In the future we may (or may
not) want them to simply ASSERT in this case. Regardless this should
be done in a separate BZ entry and a separate commit. For this reason
I ask everyone not to touch this subject.
Due to the amount of discussion this has already undergone after
almost a year I kindly request everyone to reduce the communication
to the minimum and abstain from proposing another approach.
Requesting to merge this into edk2-stable202005.
Cc: Andrew Fish email@example.com
Cc: Ard Biesheuvel firstname.lastname@example.org
Cc: Bret Barkelew email@example.com
Cc: Brian J. Johnson firstname.lastname@example.org
Cc: Chasel Chiu email@example.com
Cc: Jordan Justen firstname.lastname@example.org
Cc: Laszlo Ersek email@example.com
Cc: Leif Lindholm firstname.lastname@example.org
Cc: Liming Gao email@example.com
Cc: Marvin Häuser firstname.lastname@example.org
Cc: Michael D Kinney email@example.com
Cc: Vincent Zimmer firstname.lastname@example.org
Cc: Zhichao Gao email@example.com
Cc: Jiewen Yao firstname.lastname@example.org
Signed-off-by: Vitaly Cheptsov email@example.com
Michael D Kinney (1):
MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test
Vitaly Cheptsov (1):
MdePkg: Fix SafeString performing assertions on runtime checks
MdePkg/Include/Library/BaseLib.h | 111 -----------------
MdePkg/Library/BaseLib/SafeString.c | 115 +-----------------
.../UnitTest/Library/BaseLib/Base64UnitTest.c | 85 +++++++++++++
3 files changed, 88 insertions(+), 223 deletions(-)
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59916): https://edk2.groups.io/g/devel/message/59916
Mute This Topic: https://groups.io/mt/74341928/1787277
Group Owner: firstname.lastname@example.org
Unsubscribe: https://edk2.groups.io/g/devel/unsub [email@example.com]