[edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Ard Biesheuvel posted 2 patches 18 weeks ago
Failed in applying to current master (apply log)
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

[edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Posted by Ard Biesheuvel 18 weeks ago
Add build time checks for serial terminal settings, so we don't end up
with a non-functional serial console if the PCDs are set incorrectly

v1 was just the second patch. v2 adds the first patch switching to
STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
as well.

Ard Biesheuvel (2):
  ArmPkg/PlatformBootManagerLib: use static assertion for console type
  ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
    count

 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59814): https://edk2.groups.io/g/devel/message/59814
Mute This Topic: https://groups.io/mt/74323488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Posted by Ard Biesheuvel 15 weeks ago
On 5/19/20 2:23 PM, Ard Biesheuvel wrote:
> Add build time checks for serial terminal settings, so we don't end up
> with a non-functional serial console if the PCDs are set incorrectly
> 
> v1 was just the second patch. v2 adds the first patch switching to
> STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
> as well.
> 
> Ard Biesheuvel (2):
>    ArmPkg/PlatformBootManagerLib: use static assertion for console type
>    ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
>      count
> 
>   ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 

Pushed as #655

Thanks all.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60664): https://edk2.groups.io/g/devel/message/60664
Mute This Topic: https://groups.io/mt/74323488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Posted by Laszlo Ersek 17 weeks ago
On 05/19/20 14:23, Ard Biesheuvel wrote:
> Add build time checks for serial terminal settings, so we don't end up
> with a non-functional serial console if the PCDs are set incorrectly
> 
> v1 was just the second patch. v2 adds the first patch switching to
> STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
> as well.
> 
> Ard Biesheuvel (2):
>   ArmPkg/PlatformBootManagerLib: use static assertion for console type
>   ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
>     count
> 
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59834): https://edk2.groups.io/g/devel/message/59834
Mute This Topic: https://groups.io/mt/74323488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Posted by Sami Mujawar 18 weeks ago
Reviewed-by: Sami Mujawar <Sami.Mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@arm.com>
Sent: 19 May 2020 01:24 PM
To: devel@edk2.groups.io
Cc: leif@nuviainc.com; graeme.gregory@linaro.org; tanmay.jagdale@linaro.org; lersek@redhat.com; Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Subject: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Add build time checks for serial terminal settings, so we don't end up with a non-functional serial console if the PCDs are set incorrectly

v1 was just the second patch. v2 adds the first patch switching to STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one as well.

Ard Biesheuvel (2):
  ArmPkg/PlatformBootManagerLib: use static assertion for console type
  ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
    count

 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59822): https://edk2.groups.io/g/devel/message/59822
Mute This Topic: https://groups.io/mt/74323488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Posted by Leif Lindholm 18 weeks ago
On Tue, May 19, 2020 at 14:23:49 +0200, Ard Biesheuvel wrote:
> Add build time checks for serial terminal settings, so we don't end up
> with a non-functional serial console if the PCDs are set incorrectly
> 
> v1 was just the second patch. v2 adds the first patch switching to
> STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
> as well.

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Thanks Ard, and Laszlo!

> Ard Biesheuvel (2):
>   ArmPkg/PlatformBootManagerLib: use static assertion for console type
>   ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
>     count
> 
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59817): https://edk2.groups.io/g/devel/message/59817
Mute This Topic: https://groups.io/mt/74323488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-