On 5/12/20 9:55 AM, Ard Biesheuvel wrote:
> This is a followup to Samer's v1 [0], and incorporates all the delta
> changes posted for review over the past couple of days. This is a
> roundup of all that work, and therefore supersedes it.
>
> It provides an implementation of the SimpleNetworkProtocol for the
> Raspberry Pi4's GENET network controller, in a way that adheres to the
> UEFI driver model.
>
> The original submission was provided by Jared, based on Jeremy's MAC
> programming-only driver and the existing BSD driver for the GENET IP.
> Cumulative changes and fixes as well as review feedback were provided
> by all of the below.
>
> https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v2
>
FYI in an off list discussion, Leif pointed out the the practice of
having one 'master' .h file including everything, which is included by
the .c files is not acceptable practice, even though it is widespread in
EDK2.
I pushed a delta patch to the branch above that fixes this, but I will
wait for other feedback before sending it out, or sending out a v3,
whichever is more appropriate.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59283): https://edk2.groups.io/g/devel/message/59283
Mute This Topic: https://groups.io/mt/74154329/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-