We have moved most of our RISC-V implementation to edk2-platforms now, only the
absolute minimum is in edk2, already merged.
All other patches going into edk2-platforms have already been merged, these are new.

The first adds opensbi as a submodule. We wanted to have it reviewed because it
would be the first submodule in the edk2-platforms repository. Is that okay?

Since we are now running PEI in addition to DXE in S-Mode (like Ring 3 in x86),
we need to call into the SBI interface. The new library provides an interface
for EDK2 code to do that. It just wraps the ecall assembly instruction as a C
interface with EDK2-style return codes.

Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Daniel Schaefer (2):
  ProcessorPkg/RiscVOpensbLlib: Add submodule opensbi
  ProcessorPkg/Library: Add EDK2 RISC-V OpenSBI library.

 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf | 60 +++++++++++++++
 Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h     | 79 ++++++++++++++++++++
 Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h                      | 66 ++++++++++++++++
 .gitmodules                                                             |  3 +
 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi             |  1 +
 5 files changed, 209 insertions(+)
 create mode 100644 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
 create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h
 create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h
 create mode 100644 .gitmodules
 create mode 160000 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi

-- 
2.26.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59153): https://edk2.groups.io/g/devel/message/59153
Mute This Topic: https://groups.io/mt/74140930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Mon, May 11, 2020 at 19:20:13 +0200, Daniel Schaefer wrote:
> We have moved most of our RISC-V implementation to edk2-platforms now, only the
> absolute minimum is in edk2, already merged.
> All other patches going into edk2-platforms have already been merged, these are new.

Please be explicit on what has been merged to edk2/edk2-platforms and
what has been merged to edk2-staging/edk2-platforms-devel.

> The first adds opensbi as a submodule. We wanted to have it reviewed because it
> would be the first submodule in the edk2-platforms repository. Is that okay?

I have no objection to submodules in edk2-platforms, although this will
be the first one. Just remember to call this out explicitly in any
instructions.

/
    Leif

> Since we are now running PEI in addition to DXE in S-Mode (like Ring 3 in x86),
> we need to call into the SBI interface. The new library provides an interface
> for EDK2 code to do that. It just wraps the ecall assembly instruction as a C
> interface with EDK2-style return codes.
> 
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Daniel Schaefer (2):
>   ProcessorPkg/RiscVOpensbLlib: Add submodule opensbi
>   ProcessorPkg/Library: Add EDK2 RISC-V OpenSBI library.
> 
>  Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf | 60 +++++++++++++++
>  Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h     | 79 ++++++++++++++++++++
>  Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h                      | 66 ++++++++++++++++
>  .gitmodules                                                             |  3 +
>  Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi             |  1 +
>  5 files changed, 209 insertions(+)
>  create mode 100644 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
>  create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h
>  create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h
>  create mode 100644 .gitmodules
>  create mode 160000 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
> 
> -- 
> 2.26.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59159): https://edk2.groups.io/g/devel/message/59159
Mute This Topic: https://groups.io/mt/74140930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

> -----Original Message-----
> From: Leif Lindholm [mailto:leif@nuviainc.com]
> Sent: Tuesday, May 12, 2020 1:39 AM
> To: Schaefer, Daniel (DualStudy) <daniel.schaefer@hpe.com>
> Cc: devel@edk2.groups.io; Chen, Gilbert <gilbert.chen@hpe.com>; Chang,
> Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Michael D
> Kinney <michael.d.kinney@intel.com>
> Subject: Re: [platform/devel-riscvplatforms PATCHv1 0/2] New RISC-V
> patches
> 
> On Mon, May 11, 2020 at 19:20:13 +0200, Daniel Schaefer wrote:
> > We have moved most of our RISC-V implementation to edk2-platforms
> now,
> > only the absolute minimum is in edk2, already merged.
> > All other patches going into edk2-platforms have already been merged,
> these are new.
> 
> Please be explicit on what has been merged to edk2/edk2-platforms and
> what has been merged to edk2-staging/edk2-platforms-devel.
Daniel, we can mention this in cover letter.
> 
> > The first adds opensbi as a submodule. We wanted to have it reviewed
> > because it would be the first submodule in the edk2-platforms repository.
> Is that okay?
> 
> I have no objection to submodules in edk2-platforms, although this will be
> the first one. Just remember to call this out explicitly in any instructions.
Daniel, we can add Submodule section in Readme.md which as same as the readme under edk2.
> 
> /
>     Leif
> 
> > Since we are now running PEI in addition to DXE in S-Mode (like Ring 3
> > in x86), we need to call into the SBI interface. The new library
> > provides an interface for EDK2 code to do that. It just wraps the
> > ecall assembly instruction as a C interface with EDK2-style return codes.
> >
> > Cc: Gilbert Chen <gilbert.chen@hpe.com>
> > Cc: Abner Chang <abner.chang@hpe.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Daniel Schaefer (2):
> >   ProcessorPkg/RiscVOpensbLlib: Add submodule opensbi
> >   ProcessorPkg/Library: Add EDK2 RISC-V OpenSBI library.
> >
> >  Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
> | 60 +++++++++++++++
> >  Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h
> | 79 ++++++++++++++++++++
> >  Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h                      | 66
> ++++++++++++++++
> >  .gitmodules                                                             |  3 +
> >  Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi             |  1 +
> >  5 files changed, 209 insertions(+)
> >  create mode 100644
> > Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.in
> > f  create mode 100644
> > Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h
> >  create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h
> >  create mode 100644 .gitmodules
> >  create mode 160000
> > Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
> >
> > --
> > 2.26.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59224): https://edk2.groups.io/g/devel/message/59224
Mute This Topic: https://groups.io/mt/74140930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-