1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
  4. View patch

[edk2-devel] [PATCH 1/5] MdePkg: New Status Codes

Oleksiy Yakovlev posted 5 patches 5 years, 9 months ago
There is a newer version of this series
[edk2-devel] [PATCH 1/5] MdePkg: New Status Codes
Posted by Oleksiy Yakovlev 5 years, 9 months ago 
From: Robert Phelps <robert@ami.com>

Updated PiStatusCodes to reflect changes to PI 1.7 Specification
(PI 1.7 Mantis 1889)

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Pi/PiStatusCode.h b/MdePkg/Include/Pi/PiStatusCode.h
index 0ffd29a714..81fd24c9ea 100644
--- a/MdePkg/Include/Pi/PiStatusCode.h
+++ b/MdePkg/Include/Pi/PiStatusCode.h
@@ -340,6 +340,7 @@ typedef struct {
 #define EFI_CHIPSET_EC_BAD_BATTERY      (EFI_SUBCLASS_SPECIFIC | 0x00000000)
 #define EFI_CHIPSET_EC_DXE_NB_ERROR     (EFI_SUBCLASS_SPECIFIC | 0x00000001)
 #define EFI_CHIPSET_EC_DXE_SB_ERROR     (EFI_SUBCLASS_SPECIFIC | 0x00000002)
+#define EFI_CHIPSET_EC_INTRUDER_DETECT  (EFI_SUBCLASS_SPECIFIC | 0x00000003)
 ///@}
 
 ///
@@ -361,6 +362,7 @@ typedef struct {
 #define EFI_PERIPHERAL_AUDIO_OUTPUT     (EFI_PERIPHERAL | 0x000A0000)
 #define EFI_PERIPHERAL_LCD_DEVICE       (EFI_PERIPHERAL | 0x000B0000)
 #define EFI_PERIPHERAL_NETWORK          (EFI_PERIPHERAL | 0x000C0000)
+#define EFI_PERIPHERAL_DOCKING          (EFI_PERIPHERAL | 0x000D0000)
 ///@}
 
 ///
@@ -375,6 +377,7 @@ typedef struct {
 #define EFI_P_PC_ENABLE           0x00000004
 #define EFI_P_PC_RECONFIG         0x00000005
 #define EFI_P_PC_DETECTED         0x00000006
+#define EFI_P_PC_REMOVED          0x00000007
 ///@}
 
 //
@@ -464,8 +467,9 @@ typedef struct {
 /// Peripheral Class Keyboard Subclass Error Code definitions.
 ///
 ///@{
-#define EFI_P_KEYBOARD_EC_LOCKED    (EFI_SUBCLASS_SPECIFIC | 0x00000000)
-#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_LOCKED      (EFI_SUBCLASS_SPECIFIC | 0x00000000)
+#define EFI_P_KEYBOARD_EC_STUCK_KEY   (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC | 0x00000002)
 ///@}
 
 ///
@@ -762,6 +766,7 @@ typedef struct {
 #define EFI_SW_PEI_PC_RECOVERY_AUTO   (EFI_SUBCLASS_SPECIFIC | 0x00000004)
 #define EFI_SW_PEI_PC_S3_BOOT_SCRIPT  (EFI_SUBCLASS_SPECIFIC | 0x00000005)
 #define EFI_SW_PEI_PC_OS_WAKE         (EFI_SUBCLASS_SPECIFIC | 0x00000006)
+#define EFI_SW_PEI_PC_S3_STARTED      (EFI_SUBCLASS_SPECIFIC | 0x00000007)
 ///@}
 
 ///
@@ -784,7 +789,11 @@ typedef struct {
 #define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT            (EFI_SUBCLASS_SPECIFIC | 0x00000002)
 #define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT     (EFI_SUBCLASS_SPECIFIC | 0x00000003)
 #define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000004)
+#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT       (EFI_SUBCLASS_SPECIFIC | 0x00000005)
+#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM             (EFI_SUBCLASS_SPECIFIC | 0x00000006)
 #define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT     (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_DXE_BS_PC_CONFIG_RESET                 (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_DXE_BS_PC_CSM_INIT                     (EFI_SUBCLASS_SPECIFIC | 0x00000009)
 ///@}
 
 //
@@ -974,6 +983,8 @@ typedef struct {
 #define EFI_SW_EC_PWD_CLR_REQUEST         0x0000000F
 #define EFI_SW_EC_PWD_CLEARED             0x00000010
 #define EFI_SW_EC_EVENT_LOG_FULL          0x00000011
+#define EFI_SW_EC_WRITE_PROTECTED         0x00000012
+#define EFI_SW_EC_FV_CORRUPTED            0x00000013
 ///@}
 
 //
@@ -1005,6 +1016,8 @@ typedef struct {
 #define EFI_SW_PEI_EC_S3_RESUME_FAILED             (EFI_SUBCLASS_SPECIFIC | 0x00000005)
 #define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND       (EFI_SUBCLASS_SPECIFIC | 0x00000006)
 #define EFI_SW_PEI_EC_RECOVERY_FAILED              (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_PEI_EC_RESUME_ERROR                 (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_PEI_EC_INVALID_CAPSULE              (EFI_SUBCLASS_SPECIFIC | 0x00000009)
 ///@}
 
 ///
-- 
2.24.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58803): https://edk2.groups.io/g/devel/message/58803
Mute This Topic: https://groups.io/mt/74057698/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes
Posted by Zhiguang Liu 5 years, 9 months ago 
Hi Oleksiy,
Give my comments inline.

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:03 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH 1/5] MdePkg: New Status Codes
> 
> From: Robert Phelps <robert@ami.com>
> 
> Updated PiStatusCodes to reflect changes to PI 1.7 Specification (PI 1.7
> Mantis 1889)
> 
> Signed-off-by: Robert Phelps <robert@ami.com>
> ---
>  MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Pi/PiStatusCode.h
> b/MdePkg/Include/Pi/PiStatusCode.h
> index 0ffd29a714..81fd24c9ea 100644
> --- a/MdePkg/Include/Pi/PiStatusCode.h
> +++ b/MdePkg/Include/Pi/PiStatusCode.h
> @@ -340,6 +340,7 @@ typedef struct {
>  #define EFI_CHIPSET_EC_BAD_BATTERY      (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
>  #define EFI_CHIPSET_EC_DXE_NB_ERROR     (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
>  #define EFI_CHIPSET_EC_DXE_SB_ERROR     (EFI_SUBCLASS_SPECIFIC |
> 0x00000002)
> +#define EFI_CHIPSET_EC_INTRUDER_DETECT  (EFI_SUBCLASS_SPECIFIC |
> +0x00000003)
>  ///@}
> 
>  ///
> @@ -361,6 +362,7 @@ typedef struct {
>  #define EFI_PERIPHERAL_AUDIO_OUTPUT     (EFI_PERIPHERAL | 0x000A0000)
>  #define EFI_PERIPHERAL_LCD_DEVICE       (EFI_PERIPHERAL | 0x000B0000)
>  #define EFI_PERIPHERAL_NETWORK          (EFI_PERIPHERAL | 0x000C0000)
> +#define EFI_PERIPHERAL_DOCKING          (EFI_PERIPHERAL | 0x000D0000)
>  ///@}
> 
>  ///
> @@ -375,6 +377,7 @@ typedef struct {
>  #define EFI_P_PC_ENABLE           0x00000004
>  #define EFI_P_PC_RECONFIG         0x00000005
>  #define EFI_P_PC_DETECTED         0x00000006
> +#define EFI_P_PC_REMOVED          0x00000007
>  ///@}
> 
>  //
> @@ -464,8 +467,9 @@ typedef struct {
>  /// Peripheral Class Keyboard Subclass Error Code definitions.
>  ///
>  ///@{
> -#define EFI_P_KEYBOARD_EC_LOCKED    (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
> -#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
> +#define EFI_P_KEYBOARD_EC_LOCKED      (EFI_SUBCLASS_SPECIFIC |
> 0x00000000)
> +#define EFI_P_KEYBOARD_EC_STUCK_KEY   (EFI_SUBCLASS_SPECIFIC |
> 0x00000001)
> +#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC |
> +0x00000002)
>  ///@}
> 
>  ///
> @@ -762,6 +766,7 @@ typedef struct {
>  #define EFI_SW_PEI_PC_RECOVERY_AUTO   (EFI_SUBCLASS_SPECIFIC |
> 0x00000004)
>  #define EFI_SW_PEI_PC_S3_BOOT_SCRIPT  (EFI_SUBCLASS_SPECIFIC |
> 0x00000005)
>  #define EFI_SW_PEI_PC_OS_WAKE         (EFI_SUBCLASS_SPECIFIC |
> 0x00000006)
> +#define EFI_SW_PEI_PC_S3_STARTED      (EFI_SUBCLASS_SPECIFIC |
> 0x00000007)
>  ///@}
> 
>  ///
> @@ -784,7 +789,11 @@ typedef struct {
>  #define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000002)
>  #define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000003)
>  #define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000004)
> +#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT
> (EFI_SUBCLASS_SPECIFIC | 0x00000005)
> +#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM
> (EFI_SUBCLASS_SPECIFIC | 0x00000006)
>  #define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT
> (EFI_SUBCLASS_SPECIFIC | 0x00000007)
> +#define EFI_SW_DXE_BS_PC_CONFIG_RESET
> (EFI_SUBCLASS_SPECIFIC | 0x00000008)
> +#define EFI_SW_DXE_BS_PC_CSM_INIT                     (EFI_SUBCLASS_SPECIFIC
> | 0x00000009)
>  ///@}
> 
>  //
> @@ -974,6 +983,8 @@ typedef struct {
>  #define EFI_SW_EC_PWD_CLR_REQUEST         0x0000000F
>  #define EFI_SW_EC_PWD_CLEARED             0x00000010
>  #define EFI_SW_EC_EVENT_LOG_FULL          0x00000011
> +#define EFI_SW_EC_WRITE_PROTECTED         0x00000012
> +#define EFI_SW_EC_FV_CORRUPTED            0x00000013
>  ///@}
> 
>  //
> @@ -1005,6 +1016,8 @@ typedef struct {
>  #define EFI_SW_PEI_EC_S3_RESUME_FAILED
> (EFI_SUBCLASS_SPECIFIC | 0x00000005)
>  #define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND
> (EFI_SUBCLASS_SPECIFIC | 0x00000006)
>  #define EFI_SW_PEI_EC_RECOVERY_FAILED              (EFI_SUBCLASS_SPECIFIC
> | 0x00000007)
> +#define EFI_SW_PEI_EC_RESUME_ERROR                 (EFI_SUBCLASS_SPECIFIC
> | 0x00000008)


The spec defines  EFI_SW_PEI_EC_S3_RESUME_ERROR not define EFI_SW_PEI_EC_RESUME_ERROR                 

> +#define EFI_SW_PEI_EC_INVALID_CAPSULE
> (EFI_SUBCLASS_SPECIFIC | 0x00000009)
>  ///@}
> 
>  ///
> --
> 2.24.1.windows.2
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59033): https://edk2.groups.io/g/devel/message/59033
Mute This Topic: https://groups.io/mt/74057698/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.