[edk2-devel] [PATCH 0/5] EmbeddedPkg spring cleaning

Ard Biesheuvel posted 5 patches 4 years, 6 months ago
Failed in applying to current master (apply log)
EmbeddedPkg/EmbeddedPkg.dec                   |   23 -
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf   |   49 -
.../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf   |   38 -
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf |   51 -
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf   |   52 -
.../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf |   42 -
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h        |  127 -
.../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h     |  116 -
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h   |  297 ---
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h |  394 ---
.../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  276 --
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h   |  272 --
.../Drivers/SataSiI3132Dxe/SataSiI3132.h      |  279 ---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c     |  688 -----
.../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c     |  629 -----
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c   | 1532 -----------
.../Drivers/Lan9118Dxe/Lan9118DxeUtil.c       | 1032 --------
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c     | 2229 -----------------
.../Drivers/SataSiI3132Dxe/ComponentName.c    |  172 --
.../Drivers/SataSiI3132Dxe/SataSiI3132.c      |  539 ----
.../SataSiI3132Dxe/SiI3132AtaPassThru.c       |  827 ------
21 files changed, 9664 deletions(-)
delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf
delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h
delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c
delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c
delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
[edk2-devel] [PATCH 0/5] EmbeddedPkg spring cleaning
Posted by Ard Biesheuvel 4 years, 6 months ago
Delete a couple of obsole driver from EmbeddedPkg. They have been moved
into edk2-platforms alongside the small set of development platforms
that still use them, but they are no long fit for use beyond that.

Diffs have been omitted for files that are completely deleted. The full
set can be found here:
https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning

Ard Biesheuvel (5):
  EmbeddedPkg: remove DwEmmcDxe host controller driver
  EmbeddedPkg: remove Lan91x network controller driver
  EmbeddedPkg: remove Lan9118 network controller driver
  EmbeddedPkg: remove SiI3132 SATA controller driver
  EmbeddedPkg: remove ISP 1716 USB host controller driver

 EmbeddedPkg/EmbeddedPkg.dec                   |   23 -
 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf   |   49 -
 .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf   |   38 -
 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf |   51 -
 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf   |   52 -
 .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf |   42 -
 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h        |  127 -
 .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h     |  116 -
 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h   |  297 ---
 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h |  394 ---
 .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  276 --
 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h   |  272 --
 .../Drivers/SataSiI3132Dxe/SataSiI3132.h      |  279 ---
 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c     |  688 -----
 .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c     |  629 -----
 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c   | 1532 -----------
 .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c       | 1032 --------
 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c     | 2229 -----------------
 .../Drivers/SataSiI3132Dxe/ComponentName.c    |  172 --
 .../Drivers/SataSiI3132Dxe/SataSiI3132.c      |  539 ----
 .../SataSiI3132Dxe/SiI3132AtaPassThru.c       |  827 ------
 21 files changed, 9664 deletions(-)
 delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf
 delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
 delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
 delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
 delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h
 delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
 delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
 delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
 delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
 delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
 delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
 delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c
 delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c
 delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
 delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58555): https://edk2.groups.io/g/devel/message/58555
Mute This Topic: https://groups.io/mt/73975410/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg spring cleaning
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago
On 5/4/20 3:57 PM, Ard Biesheuvel wrote:
> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
> into edk2-platforms alongside the small set of development platforms
> that still use them, but they are no long fit for use beyond that.
> 
> Diffs have been omitted for files that are completely deleted. The full
> set can be found here:
> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
> 
> Ard Biesheuvel (5):
>    EmbeddedPkg: remove DwEmmcDxe host controller driver
>    EmbeddedPkg: remove Lan91x network controller driver
>    EmbeddedPkg: remove Lan9118 network controller driver
>    EmbeddedPkg: remove SiI3132 SATA controller driver
>    EmbeddedPkg: remove ISP 1716 USB host controller driver
> 
>   EmbeddedPkg/EmbeddedPkg.dec                   |   23 -
>   EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf   |   49 -
>   .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf   |   38 -
>   EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf |   51 -
>   EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf   |   52 -
>   .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf |   42 -
>   EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h        |  127 -
>   .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h     |  116 -
>   EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h   |  297 ---
>   EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h |  394 ---
>   .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  276 --
>   EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h   |  272 --
>   .../Drivers/SataSiI3132Dxe/SataSiI3132.h      |  279 ---
>   EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c     |  688 -----
>   .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c     |  629 -----
>   EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c   | 1532 -----------
>   .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c       | 1032 --------
>   EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c     | 2229 -----------------
>   .../Drivers/SataSiI3132Dxe/ComponentName.c    |  172 --
>   .../Drivers/SataSiI3132Dxe/SataSiI3132.c      |  539 ----
>   .../SataSiI3132Dxe/SiI3132AtaPassThru.c       |  827 ------
>   21 files changed, 9664 deletions(-)

Nice diffstat...      ^^^^

Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58627): https://edk2.groups.io/g/devel/message/58627
Mute This Topic: https://groups.io/mt/73975410/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg spring cleaning
Posted by Leif Lindholm 4 years, 6 months ago
On Mon, May 04, 2020 at 15:57:22 +0200, Ard Biesheuvel wrote:
> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
> into edk2-platforms alongside the small set of development platforms
> that still use them, but they are no long fit for use beyond that.
> 
> Diffs have been omitted for files that are completely deleted. The full
> set can be found here:
> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
> 
> Ard Biesheuvel (5):
>   EmbeddedPkg: remove DwEmmcDxe host controller driver
>   EmbeddedPkg: remove Lan91x network controller driver
>   EmbeddedPkg: remove Lan9118 network controller driver
>   EmbeddedPkg: remove SiI3132 SATA controller driver
>   EmbeddedPkg: remove ISP 1716 USB host controller driver

Many thanks for this! For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

>  EmbeddedPkg/EmbeddedPkg.dec                   |   23 -
>  EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf   |   49 -
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf   |   38 -
>  EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf |   51 -
>  EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf   |   52 -
>  .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf |   42 -
>  EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h        |  127 -
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h     |  116 -
>  EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h   |  297 ---
>  EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h |  394 ---
>  .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  276 --
>  EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h   |  272 --
>  .../Drivers/SataSiI3132Dxe/SataSiI3132.h      |  279 ---
>  EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c     |  688 -----
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c     |  629 -----
>  EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c   | 1532 -----------
>  .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c       | 1032 --------
>  EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c     | 2229 -----------------
>  .../Drivers/SataSiI3132Dxe/ComponentName.c    |  172 --
>  .../Drivers/SataSiI3132Dxe/SataSiI3132.c      |  539 ----
>  .../SataSiI3132Dxe/SiI3132AtaPassThru.c       |  827 ------
>  21 files changed, 9664 deletions(-)
>  delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf
>  delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
>  delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
>  delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
>  delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h
>  delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
>  delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
>  delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
>  delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
>  delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
>  delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
>  delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c
>  delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c
>  delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
>  delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
> 
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58628): https://edk2.groups.io/g/devel/message/58628
Mute This Topic: https://groups.io/mt/73975410/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg spring cleaning
Posted by Ard Biesheuvel 4 years, 6 months ago
On 5/5/20 4:08 PM, Leif Lindholm wrote:
> On Mon, May 04, 2020 at 15:57:22 +0200, Ard Biesheuvel wrote:
>> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
>> into edk2-platforms alongside the small set of development platforms
>> that still use them, but they are no long fit for use beyond that.
>>
>> Diffs have been omitted for files that are completely deleted. The full
>> set can be found here:
>> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
>>
>> Ard Biesheuvel (5):
>>    EmbeddedPkg: remove DwEmmcDxe host controller driver
>>    EmbeddedPkg: remove Lan91x network controller driver
>>    EmbeddedPkg: remove Lan9118 network controller driver
>>    EmbeddedPkg: remove SiI3132 SATA controller driver
>>    EmbeddedPkg: remove ISP 1716 USB host controller driver
> 
> Many thanks for this! For the series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 

Cheers

Pushed this, along with the PL180 one you acked earlier.

https://github.com/tianocore/edk2/pull/577

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58641): https://edk2.groups.io/g/devel/message/58641
Mute This Topic: https://groups.io/mt/73975410/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-