[edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions

Ashley E Desimone posted 2 patches 5 years, 9 months ago
Failed in applying to current master (apply log)
edkrepo/commands/clone_command.py       |  3 ++-
edkrepo/commands/sync_command.py        |  3 ++-
edkrepo/common/common_repo_functions.py | 35 +--------------------------------
3 files changed, 5 insertions(+), 36 deletions(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions
Posted by Ashley E Desimone 5 years, 9 months ago
Remove the duplicate definition of functions in
common_repo_functions.py and update imports to use
the definitions in workspace_maintenance.py.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Ashley E Desimone (2):
  EdkRepo: Remove duplicate definition of
    generate_name_for_obsolete_backup
  EdkRepo: Remove duplicate definitions of case_insensitive_single_match
    and case_insensitive_equal

 edkrepo/commands/clone_command.py       |  3 ++-
 edkrepo/commands/sync_command.py        |  3 ++-
 edkrepo/common/common_repo_functions.py | 35 +--------------------------------
 3 files changed, 5 insertions(+), 36 deletions(-)

-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58525): https://edk2.groups.io/g/devel/message/58525
Mute This Topic: https://groups.io/mt/73407242/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions
Posted by Nate DeSimone 5 years, 9 months ago
For the series...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, May 1, 2020 1:40 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions

Remove the duplicate definition of functions in common_repo_functions.py and update imports to use the definitions in workspace_maintenance.py.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Ashley E Desimone (2):
  EdkRepo: Remove duplicate definition of
    generate_name_for_obsolete_backup
  EdkRepo: Remove duplicate definitions of case_insensitive_single_match
    and case_insensitive_equal

 edkrepo/commands/clone_command.py       |  3 ++-
 edkrepo/commands/sync_command.py        |  3 ++-
 edkrepo/common/common_repo_functions.py | 35 +--------------------------------
 3 files changed, 5 insertions(+), 36 deletions(-)

--
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58602): https://edk2.groups.io/g/devel/message/58602
Mute This Topic: https://groups.io/mt/73407242/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions
Posted by Nate DeSimone 5 years, 9 months ago
Pushed as 9120b007~..48a58d54

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, May 1, 2020 1:40 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions

Remove the duplicate definition of functions in common_repo_functions.py and update imports to use the definitions in workspace_maintenance.py.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Ashley E Desimone (2):
  EdkRepo: Remove duplicate definition of
    generate_name_for_obsolete_backup
  EdkRepo: Remove duplicate definitions of case_insensitive_single_match
    and case_insensitive_equal

 edkrepo/commands/clone_command.py       |  3 ++-
 edkrepo/commands/sync_command.py        |  3 ++-
 edkrepo/common/common_repo_functions.py | 35 +--------------------------------
 3 files changed, 5 insertions(+), 36 deletions(-)

--
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58604): https://edk2.groups.io/g/devel/message/58604
Mute This Topic: https://groups.io/mt/73407242/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-